From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73E7BE7718B for ; Wed, 25 Dec 2024 09:35:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D2+4v/zhHwpCte/oLedaaCSL9qFHFSPHf0DPLkx+SV8=; b=lhQ3O+/IN6NmsRmhwYfuo+KVal E4Fp/s89f9g1kErTZqWKmfYD7LtZRZVmCffzeORRCRniTgm8WdJ445JT+KZIEdGDLO2Ktn5wQnf+5 u5n3f2E8BXNLZoal3mkTGglGJ7tMDR0nDeiOAgiJ7lhwWwM6FymW96dtNin/2gf0R1LsS1X5XxJ7r PcHGjKnt2W+9qx+ZjLOAGyyJ/Bzy12x/aQOP6dcv/ut3nxTCTNAGICWA5K/jezxVEDS0Q+xeVQuu0 EAYVX678l1GiwNLRRhIixvaGRATK6ETqccfmN9lX9jozwErupyAr5egbuKALADSLzqVlFv1uJqDtt nPNMbArw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tQNnq-0000000DYz0-4AZs; Wed, 25 Dec 2024 09:35:42 +0000 Received: from mail.manjaro.org ([2a01:4f8:c0c:51f3::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tQNnf-0000000DYxW-28hJ for linux-rockchip@lists.infradead.org; Wed, 25 Dec 2024 09:35:33 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1735119327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fpIa73iwb0+bmyk8l/k9K8qRAzYUQwzwLHgKuu6+iTA=; b=CzvMFrhFpjw048BmP5O7rSRZbXlQiIg8VslRibB+4JdDrHyzErWcVo0lXSn3HtB07hLtcV 5g6C+P7lxXfnnAzAvaYKYDOMGfGlwQP9PUQ+l6gZstPKnFxNzMeZRn80W1j+tUAqaLLfK6 OkvTKkGw1Fyt1q3TB/49hN/hKX+9j1OrjikdRewn+Rb2/Ts7Zq80m9uheG5hQv4l9O4/QA Kqtar8qNCV7P1jVEZdXiFQSFdnfYeZfnhEo25zFyJ9Zepikkqdtu5e968aA72kxQ8043yb xkdtt/dfPsOGQH2ykGuNonQrI2n62LUcAKyPc/1jvEreDxaSQv3ll11mcEZHNA== Date: Wed, 25 Dec 2024 10:35:26 +0100 From: Dragan Simic To: Alexey Charkov Cc: FUKAUMI Naoki , heiko@sntech.de, robh@kernel.org, conor+dt@kernel.org, inindev@gmail.com, liujianfeng1994@gmail.com, jonas@kwiboo.se, dmt.yashin@gmail.com, sebastian.reichel@collabora.com, tim@feathertop.org, kever.yang@rock-chips.com, marcin.juszkiewicz@linaro.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, michael.riesch@wolfvision.net, macromorgan@hotmail.com, krzk+dt@kernel.org Subject: Re: [PATCH 0/3] arm64: dts: rockchip: Add Radxa ROCK 5B+ and rebase Radxa ROCK 5B In-Reply-To: References: <20241224210912.2121-1-naoki@radxa.com> Message-ID: <4bac4d58493cb0e7fc863095e02ffad3@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241225_013531_716713_5191A6B0 X-CRM114-Status: GOOD ( 16.25 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGVsbG8gQWxleGV5IGFuZCBOYW9raSwKCk9uIDIwMjQtMTItMjUgMDk6MzIsIEFsZXhleSBDaGFy a292IHdyb3RlOgo+IE9uIFdlZCwgRGVjIDI1LCAyMDI0IGF0IDEyOjIy4oCvUE0gRlVLQVVNSSBO YW9raSA8bmFva2lAcmFkeGEuY29tPiB3cm90ZToKPj4gCj4+IFRoZSBSYWR4YSBST0NLIDVCKyBp cyBhbiB1cGdyYWRlZCB2ZXJzaW9uIG9mIHRoZSBSYWR4YSBST0NLIDVCLgo+PiAKPj4gVGhpcyBw YXRjaCBzZXJpZXMgaW50cm9kdWNlcyBhIHNoYXJlZCAuZHRzaSB0aGF0IGNhbiBiZSB1c2VkIG9u IHRoZQo+PiBuZXcgUmFkeGEgUk9DSyA1QissIHRoZSBleGlzdGluZyBSYWR4YSBST0NLIDVCLCBh bmQgdGhlIHVwY29taW5nIFJhZHhhCj4+IFJPQ0sgNVQuCj4+IAo+PiBUaGlzIHBhdGNoIHNlcmll cyBpbmNsdWRlcyAiYXJtNjQ6IGR0czogcm9ja2NoaXA6IEFkZCBVU0ItQyBzdXBwb3J0IHRvCj4+ IFJPQ0sgNUIiIGJ5IFNlYmFzdGlhbiBSZWljaGVsWzFdLgo+PiAKPj4gWzFdIAo+PiBodHRwczov L3BhdGNod29yay5rZXJuZWwub3JnL3Byb2plY3QvbGludXgtcm9ja2NoaXAvcGF0Y2gvMjAyNDEy MTAxNjM2MTUuMTIwNTk0LTEtc2ViYXN0aWFuLnJlaWNoZWxAY29sbGFib3JhLmNvbS8KPj4gCj4+ IEZVS0FVTUkgTmFva2kgKDMpOgo+PiAgIGR0LWJpbmRpbmdzOiBhcm06IHJvY2tjaGlwOiBBZGQg UmFkeGEgUk9DSyA1QisKPj4gICBhcm02NDogZHRzOiByb2NrY2hpcDogQWRkIFJhZHhhIFJPQ0sg NUIrCj4+ICAgYXJtNjQ6IGR0czogcm9ja2NoaXA6IENvbnZlcnQgUmFkeGEgUk9DSyA1QiB0byB1 c2Ugc2hhcmVkIC5kdHNpCj4gCj4gVGhpcyBvbmUgZG9lc24ndCBsb29rIGVxdWl2YWxlbnQgdG8g dGhlIGV4aXN0aW5nIFJPQ0sgNUIgZGV2aWNlIHRyZWUKPiBhZnRlciB5b3VyIGNoYW5nZXMgKEkn dmUgbm90aWNlZCBpbiBwYXJ0aWN1bGFyIHRoYXQgZmFuIGNvb2xpbmcgbGV2ZWxzCj4gYXJlIGRp ZmZlcmVudCAtIGJ1dCB0aGF0J3MganVzdCB0aGUgcGFydCBJIHJlbWVtYmVyIHdlbGwgc2luY2Ug SQo+IG1vZGlmaWVkIGl0IGVhcmxpZXIsIHRoZXJlIG1pZ2h0IGJlIG1vcmUgZGlmZmVyZW5jZXMp Lgo+IAo+IFdvdWxkIHlvdSBtaW5kIHJlYXJyYW5naW5nIHRoZSBwYXRjaGVzIHNvIHRoYXQgdGhl IHNwbGl0IG9mIFJPQ0sgNUIKPiBkdHMgaW50byBhIGNvbW1vbiAuZHRzaSBhbmQgcGVyLWJvYXJk IC5kdHMgYWRkaXRpb25zIGNvdWxkIGJlIG1hZGUKPiBvbmUtdG8tb25lIGVxdWl2YWxlbnQgd2l0 aG91dCBmdW5jdGlvbmFsIGNoYW5nZXMsIGFuZCB0aGVuIGFkZCBST0NLCj4gNUIrIGFuZCBhbnkg b3RoZXIgcmVxdWlyZWQgY2hhbmdlcyBvbiB0b3Agb2YgdGhhdD8KPiAKPiBTZWUgd2hhdCBEcmFn YW4gZGlkIHdoZXJlIGhlIHByZXBhcmVkIHBhcmVudCAuZHRzaSBmb3IgcGVyLXZhcmlhbnQgT1BQ cyAKPiBbMV0KPiAKPiBbMV0gCj4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGludXgtcm9ja2No aXAvOWZmZWRjMGUyY2E3ZjE2N2Q5ZDc5NWIyYThmNDNjYjlmNTZhNjUzYi4xNzE3OTIzMzA4Lmdp dC5kc2ltaWNAbWFuamFyby5vcmcvCgpKdXN0IGEgYnJpZWYgbm90ZSB0aGF0IEkgYWdyZWUgd2l0 aCBBbGV4ZXkncyByZWNvbW1lbmRhdGlvbiBhYm92ZS4KVGhlc2UgcGF0Y2hlcyBzaG91bGQgYmUg cmV3b3JrZWQgaW4gYSB3YXkgdGhhdCBtYWtlcyB0aGUgdHJhbnNpdGlvbgp0byB1c2luZyB0aGUg c2hhcmVkIGR0c2kgZmlsZSBtdWNoIG1vcmUgb2J2aW91cy4KCkJlc2lkZXMgbWFraW5nIHRoZXNl IGNoYW5nZXMgZWFzaWVyIHRvIHJldmlldyB0aGF0IHdheSwgYW5kIGdpdmluZwpiZXR0ZXIgY2hh bmNlcyB0byBlbnN1cmluZyB0aGVyZSBhcmUgbm8gaXNzdWVzIHRoYXQgbWFuYWdlZCB0byBzbGlw CnRocm91Z2ggdGhlIGNyYWNrcywgaXQgd2lsbCBhbHNvIGJlIG11Y2ggZWFzaWVyIGxhdGVyIHRv IHRyYWNrIGRvd24KYW55IHBvc3NpYmxlIHJlZ3Jlc3Npb25zLCBpbiBjYXNlIHRoZXkgZXZlbnR1 YWxseSBhcmUgZGlzY292ZXJlZC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEC50A935 for ; Wed, 25 Dec 2024 09:35:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735119337; cv=none; b=p3l5eD16kPDF28y+dvIBzgN9sFqWv/13ZkSed8agm02dm7M3fS5/BzAXrsr5R/x2hHME3q9H8hGR0tLXF1gg8f8VLYgKDLvLjlGGr1TA5BPD1AnTPkIuT8ptMH57cG0Tyoz4VWFtC9eneOT+4L8j8Fx5gwGXz5LQBD4t81m4BYQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735119337; c=relaxed/simple; bh=qqfBQZnZKdJYvrR11UaMqbURB2C8KRdXO2UyYd632Xc=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=d4DBFLAR9OnUVJ8gq80blW2oRnClVLJQgS3wOioRxP6sPxwFb/emU4oP6aWvn/HMkGQRBTHIvTQ6WhgGc7NuCBhr6JWnIQ+lSaHUmo+pDM3f8SiVpdpCLVxwemAUT1SZXFAzIDq47/5RpwBjs6/98c3GT4e+IduHP4qMGkEpHW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=CzvMFrhF; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="CzvMFrhF" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1735119327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fpIa73iwb0+bmyk8l/k9K8qRAzYUQwzwLHgKuu6+iTA=; b=CzvMFrhFpjw048BmP5O7rSRZbXlQiIg8VslRibB+4JdDrHyzErWcVo0lXSn3HtB07hLtcV 5g6C+P7lxXfnnAzAvaYKYDOMGfGlwQP9PUQ+l6gZstPKnFxNzMeZRn80W1j+tUAqaLLfK6 OkvTKkGw1Fyt1q3TB/49hN/hKX+9j1OrjikdRewn+Rb2/Ts7Zq80m9uheG5hQv4l9O4/QA Kqtar8qNCV7P1jVEZdXiFQSFdnfYeZfnhEo25zFyJ9Zepikkqdtu5e968aA72kxQ8043yb xkdtt/dfPsOGQH2ykGuNonQrI2n62LUcAKyPc/1jvEreDxaSQv3ll11mcEZHNA== Date: Wed, 25 Dec 2024 10:35:26 +0100 From: Dragan Simic To: Alexey Charkov Cc: FUKAUMI Naoki , heiko@sntech.de, robh@kernel.org, conor+dt@kernel.org, inindev@gmail.com, liujianfeng1994@gmail.com, jonas@kwiboo.se, dmt.yashin@gmail.com, sebastian.reichel@collabora.com, tim@feathertop.org, kever.yang@rock-chips.com, marcin.juszkiewicz@linaro.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, michael.riesch@wolfvision.net, macromorgan@hotmail.com, krzk+dt@kernel.org Subject: Re: [PATCH 0/3] arm64: dts: rockchip: Add Radxa ROCK 5B+ and rebase Radxa ROCK 5B In-Reply-To: References: <20241224210912.2121-1-naoki@radxa.com> Message-ID: <4bac4d58493cb0e7fc863095e02ffad3@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org Hello Alexey and Naoki, On 2024-12-25 09:32, Alexey Charkov wrote: > On Wed, Dec 25, 2024 at 12:22 PM FUKAUMI Naoki wrote: >> >> The Radxa ROCK 5B+ is an upgraded version of the Radxa ROCK 5B. >> >> This patch series introduces a shared .dtsi that can be used on the >> new Radxa ROCK 5B+, the existing Radxa ROCK 5B, and the upcoming Radxa >> ROCK 5T. >> >> This patch series includes "arm64: dts: rockchip: Add USB-C support to >> ROCK 5B" by Sebastian Reichel[1]. >> >> [1] >> https://patchwork.kernel.org/project/linux-rockchip/patch/20241210163615.120594-1-sebastian.reichel@collabora.com/ >> >> FUKAUMI Naoki (3): >> dt-bindings: arm: rockchip: Add Radxa ROCK 5B+ >> arm64: dts: rockchip: Add Radxa ROCK 5B+ >> arm64: dts: rockchip: Convert Radxa ROCK 5B to use shared .dtsi > > This one doesn't look equivalent to the existing ROCK 5B device tree > after your changes (I've noticed in particular that fan cooling levels > are different - but that's just the part I remember well since I > modified it earlier, there might be more differences). > > Would you mind rearranging the patches so that the split of ROCK 5B > dts into a common .dtsi and per-board .dts additions could be made > one-to-one equivalent without functional changes, and then add ROCK > 5B+ and any other required changes on top of that? > > See what Dragan did where he prepared parent .dtsi for per-variant OPPs > [1] > > [1] > https://lore.kernel.org/linux-rockchip/9ffedc0e2ca7f167d9d795b2a8f43cb9f56a653b.1717923308.git.dsimic@manjaro.org/ Just a brief note that I agree with Alexey's recommendation above. These patches should be reworked in a way that makes the transition to using the shared dtsi file much more obvious. Besides making these changes easier to review that way, and giving better chances to ensuring there are no issues that managed to slip through the cracks, it will also be much easier later to track down any possible regressions, in case they eventually are discovered.