From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Gamari Subject: Re: [PATCH] scsi: fix lockdep warning Date: Tue, 30 Mar 2010 08:05:28 -0700 (PDT) Message-ID: <4bb21338.0d0db80a.1685.ffffb9e1@mx.google.com> References: <86802c441003081612r2f44efd6n9664b4b7c98a636a@mail.gmail.com> <4B95F37E.6060309@kernel.org> <4B99A6F0.4080203@kernel.org> <4BA47692.7040401@kernel.org> Return-path: Received: from mail-fx0-f223.google.com ([209.85.220.223]:36874 "EHLO mail-fx0-f223.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751813Ab0C3PFb (ORCPT ); Tue, 30 Mar 2010 11:05:31 -0400 In-Reply-To: <4BA47692.7040401@kernel.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Yinghai Lu , "Eric W. Biederman" , James Bottomley , Greg KH Cc: Linux Kernel Mailing List , Linux-Scsi On Sat, 20 Mar 2010 00:17:38 -0700, Yinghai Lu wrote: > > with qlogic and emulex card etc. > > Signed-off-by: Yinghai Lu > As several others have pointed out, you appear to be call sysfs_bin_attr_init() against statically allocated attributes. Is there an updated patchset that you've been meaning to send out? Moreover, there are still failures in the ACPI thermal driver (at very least) on master (9623e5a23724d09283c238960946ec6f65733afe). - Ben [ 3.240692] BUG: key ffff88011b1a9528 not in .data! [ 3.245578] ------------[ cut here ]------------ [ 3.250195] WARNING: at kernel/lockdep.c:2706 lockdep_init_map+0x125/0x140() [ 3.257229] Hardware name: Latitude D830 [ 3.262793] Modules linked in: [ 3.265864] Pid: 1, comm: swapper Not tainted 2.6.34-rc2-ben #137 [ 3.271946] Call Trace: [ 3.274397] [] warn_slowpath_common+0x7b/0xc0 [ 3.280395] [] warn_slowpath_null+0x14/0x20 [ 3.286220] [] lockdep_init_map+0x125/0x140 [ 3.292046] [] sysfs_add_file_mode+0x6f/0xd0 [ 3.297960] [] ? snprintf+0x34/0x40 [ 3.303093] [] sysfs_add_file+0x11/0x20 [ 3.308570] [] sysfs_create_file+0x26/0x30 [ 3.314311] [] device_create_file+0x19/0x20 [ 3.320136] [] thermal_zone_device_register+0x45b/0x860 [ 3.327001] [] acpi_thermal_add+0x245/0x4e4 [ 3.332827] [] ? sysfs_do_create_link+0xd0/0x170 [ 3.339085] [] acpi_device_probe+0x50/0x122 [ 3.344909] [] driver_probe_device+0x96/0x1a0 [ 3.350906] [] ? __driver_attach+0x0/0xa0 [ 3.356557] [] __driver_attach+0x9b/0xa0 [ 3.362121] [] ? __driver_attach+0x0/0xa0 [ 3.367773] [] bus_for_each_dev+0x6c/0xa0 [ 3.373423] [] driver_attach+0x1e/0x20 [ 3.378814] [] bus_add_driver+0xe1/0x280 [ 3.384380] [] driver_register+0x78/0x140 [ 3.390031] [] ? acpi_thermal_init+0x0/0x7b [ 3.395855] [] acpi_bus_register_driver+0x43/0x45 [ 3.402199] [] acpi_thermal_init+0x59/0x7b [ 3.407938] [] do_one_initcall+0x3c/0x1a0 [ 3.413591] [] kernel_init+0x15a/0x1e4 [ 3.418984] [] kernel_thread_helper+0x4/0x10 [ 3.424895] [] ? restore_args+0x0/0x30 [ 3.430286] [] ? kernel_init+0x0/0x1e4 [ 3.435678] [] ? kernel_thread_helper+0x0/0x10 [ 3.441765] ---[ end trace a22d306b065d4a66 ]--- [ 3.446380] BUG: key ffff88011b1a9570 not in .data!