From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 842F446F48F for ; Fri, 14 Aug 2026 16:55:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786726534; cv=none; b=ml/JZ1wxmcvMaA5O0wcZ1CzkqUiO+PxTHZFTrfddNB/P0Pz3dLnsz5wUJAp98FM06875vHvtp0GB+8E40M3PWBU5BxiqB42OF1YqQfKGxdF5mbtXEEORd8Wks7XXwA/IqCKSJ4lBgSktql+Jg7T8ksqtFdNGCntj7ELTuRS/+Pg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786726534; c=relaxed/simple; bh=k5EloMOSTVAa9CzBTiI/tnt1aw0B//WUVChQ0e1YpDk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ipWhKFgbQ6YSYLdNZSB2RlYZBNVUCMPM4CSHHgpoRZSi1+ZI74Le+ZNi58srNjQKJk/ClT2xyzEf0zcg0YkGGbk9pWtQgBe9uDt8f7MYlsBghQS70FWAe0Dtaf8MirzKgNvYd/nBvg5tuevLUZoDQ74+3wADTwsAxUKH6VWUuqs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=CTmaAcJl; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="CTmaAcJl" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-51c1372f84dso9231031cf.2 for ; Fri, 14 Aug 2026 09:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1786726532; x=1787331332; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=PTW05gzNIpG2NVGNH+SKktP5f5MLzIfsgAEdY/wEjzU=; b=CTmaAcJleqxEnKYz3WBrXorkx+ByXEpbjMMbQNZelj6TbqSPWjUqYtFmrI1qpJgGkv TKPAMRNNLIQWw3ekDT2Im+6WGAPPhFJCQrnT7ZhkD+DAsIbvnaXr3o+TuFpT7gBO745P gnTYG4A4Y7lpYRZmD9kfITzxPc36zTgHlPh4K8m3bZ6bw94SH3hv9buYgUjx0KVjmf6Q DrRO9SvcDwi8mBg/ioggEWW0fIYiluhZbOJTQQLuh9VgHxj9i5z2XHXn+JfwKmFsDoNC sZgGE3x9MvH5SCVaLs4RRCiTunSKA+6YsU5POJ5tD7sijsUjozid50Or0xFU4rwaLBi+ a35w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786726532; x=1787331332; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PTW05gzNIpG2NVGNH+SKktP5f5MLzIfsgAEdY/wEjzU=; b=ZTz97LX/xV9FcFbT+gmF2CNYzmJrHAOO/OeFklttvj5SAqMmkqsf/jVmk6sGs97U+L XgOyDpfgFjZGGCSVVff6yREXchXbF6dWoQrn429kjjLVBR7+Lp8NEnhGaLihxX1sPpMM rhDfY6qtH3MaI9NsuZS38rL210FFWxKvm9ZXYGQV8BYXq6GySAw85SvfF4LjQ5Znxbzy ltxFzCau1SGeqwJGM/q4a9+uEVljxuwFZX6n8nWhzC4W8etdi6ajPCbFBg+KjKCYBn/1 oUqWGMqTIm9hCUrs4nq5oAfgm0QJzUisjEYOuaItje6YS2Od/vO+Ywcs2B7EypKfPaHY X/wg== X-Forwarded-Encrypted: i=1; AHgh+Rrob9tlTu2PHzyMDJhasmZPrsYbtbq5Vr96fAX33GEro8sSm7QsYChsPse+/OEBqhjbH3YPZBIKJufR4bo=@vger.kernel.org X-Gm-Message-State: AOJu0YzQZNOS/ikkbfc20qUZlP+A0/BiomEUEFgb63ctH7x18N7E8VPH 6VrE8dy/705PzRa4vbF2l4hbzUq551TneH9zZhfCHcAPj6nYhk1C8sbAx2ZFUlV8Xcg= X-Gm-Gg: AR+sD13/9fqg4xvh1sd6ACdgJ3HhigI9G7HmpwSoq1GZlx+zRTnmXcc6Tu1o22f+WjE uMpdB2x1xswJ+ggB9iL4C31I3YhAccXWe2y8UXiOCb3qKQ0U2e1vsSh2rBREBjIGuvYBJeRHb5I vt7Qs7vFLsZaoXOYxDnfeQMwTFOtx2fRE6qcuJ9j5LBwD1OR1I51LBV/O+pnvkcDzGpVpsPbKMd qJnz/RZoxBi9q9kN44KORwL09WzuwV1mI9+cQZH1o01GZOY+jDuDbyTO9rExUHtiNVy2qcS44uY PmtLvdofXaUCVpwrGkHDlfG/lHGLwkgveeedBPuR4t10n12xf2xz307zsBfkz8GCYqxpc/0aprP JJYegzdJEewwbW1/6e0Jlj7A8LaNnMKE1yarOFuz4xIizFtgDT1R4t6v+L7RyS3foZl3NscAQjc Zkw6oIayMGfoqVVDOT0zwtB3462BBs0mvxZh2Nj+PawXOhF7B38T1foJH1gGYP X-Received: by 2002:a05:622a:608a:b0:52d:8257:666d with SMTP id d75a77b69052e-52d8541dcd5mr85954931cf.11.1786726532365; Fri, 14 Aug 2026 09:55:32 -0700 (PDT) Received: from [172.22.22.28] ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52d84071799sm24476161cf.20.2026.08.14.09.55.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Aug 2026 09:55:31 -0700 (PDT) Message-ID: <4bb8bd0a-3e33-4fe4-903a-69b2c708a017@riscstar.com> Date: Fri, 14 Aug 2026 11:55:31 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] misc: tc9564: introduce base PCI driver To: Arnd Bergmann , Greg Kroah-Hartman Cc: Rob Herring , krzk+dt@kernel.org, Conor Dooley , bhelgaas@google.com, daniel@riscstar.com, mohdayaa@qti.qualcomm.com, lbiancon@qti.qualcomm.com, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260813222943.1655453-1-elder@riscstar.com> <20260813222943.1655453-3-elder@riscstar.com> <2026081455-eternity-douche-900b@gregkh> <56aef294-8d1d-40f2-a371-ea3f5ede2ccf@app.fastmail.com> Content-Language: en-US From: Alex Elder In-Reply-To: <56aef294-8d1d-40f2-a371-ea3f5ede2ccf@app.fastmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/14/26 2:31 AM, Arnd Bergmann wrote: > On Fri, Aug 14, 2026, at 03:11, Greg KH wrote: >> On Thu, Aug 13, 2026 at 05:29:42PM -0500, Alex Elder wrote: >>> +#define DRIVER_NAME "tc9564-pci" >> >> What about just using KBUILD_MODNAME? >> >>> +static int >>> +tc9564_function_probe(struct pci_dev *pdev, const struct pci_device_id *id) >> >> But wow, this is a tiny driver, feels odd to have it in misc/ but ok, if >> you think it should be here... > > We have drivers/misc/rp1/ and drivers/misc/lan966x_pci*.c with similar > functionality, so at least there is precedence for putting them here. Yes, exactly. > From the old days, we still have drivers/mfd/sm501.c, drivers/mfd/cs5535-mfd.c, > and a few others that open-code the on-chip components as mfd cels > instead of using devicetree description. > > At some point, we should think about grouping them into a separate > subdirectory. You mean for systems modeled with PCI endpoint bus, right? If there is consensus that now is a good time to do that I don't mind doing that work, but won't unless it's clearly requested. -Alex > > Arnd