Re: [PATCH v4] knownnetworks: sanitize known_network.freq on load

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]

Hi James,

On 1/29/21 5:47 PM, James Prestwood wrote:
> An invalid known_network.freq file containing several UUID
> groups which have the same 'name' key results in memory leaks
> in IWD. This is because the file is loaded and the group's
> are iterated without detecting duplicates. This leads to the
> same network_info's known_frequencies being set/overridden
> multiple times.
> 
> To fix this we just check if the network_info already has a
> UUID set. If so remove the stale entry.
> 
> There may be other old, invalid, or stale entries from previous
> versions of IWD, or a user misconfiguring the file. These will
> now also be removed during load.
> ---
>   src/knownnetworks.c | 25 +++++++++++++++++--------
>   1 file changed, 17 insertions(+), 8 deletions(-)
> 
> v4:
>   * Fixed a few memory leak issues
> 

Applied, thanks.

Regards,
-Denis