From: Kory Maincent <kory.maincent@bootlin.com>
To: "Vincent Stehlé" <vincent.stehle@arm.com>,
"Sughosh Ganu" <sughosh.ganu@arm.com>,
u-boot@lists.u-boot-project.org
Cc: Etienne Carriere <etienne.carriere@linaro.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH] fwu: fix read buffer size
Date: Tue, 15 Sep 2026 16:32:39 +0200 [thread overview]
Message-ID: <4c01c2e2-fa76-49fe-b33c-e3df9d569159@bootlin.com> (raw)
In-Reply-To: <20260915-fwu-v1-1-cc1fe9640334@arm.com>
On 9/15/26 16:29, Vincent Stehlé wrote:
> When the trial_counter_read() function reads its counter from the
> TrialStateCtr UEFI Variable, it erroneously computes the return buffer
> size to be the size of a pointer instead of a u16.
>
> As the UEFI Variable is always created by trial_counter_update() with
> the right size before any read attempt, overflow cannot happen in
> practice, but fix the size computation for correctness.
Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
Thank you!
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-09-15 14:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 14:29 [PATCH] fwu: fix read buffer size Vincent Stehlé
2026-09-15 14:32 ` Kory Maincent [this message]
2026-09-17 15:26 ` Ilias Apalodimas
2026-09-18 13:45 ` Vincent Stehlé
2026-09-18 14:38 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c01c2e2-fa76-49fe-b33c-e3df9d569159@bootlin.com \
--to=kory.maincent@bootlin.com \
--cc=etienne.carriere@linaro.org \
--cc=ilias.apalodimas@linaro.org \
--cc=sughosh.ganu@arm.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
--cc=vincent.stehle@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.