All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 4/8] wic: remove unused API DirectImageCreator.get_disk_names
Date: Tue, 24 Jan 2017 15:43:52 +0200	[thread overview]
Message-ID: <4c417d955a79593025280334e54e4594de2e4ac3.1485264964.git.ed.bartosh@linux.intel.com> (raw)
In-Reply-To: <cover.1485264964.git.ed.bartosh@linux.intel.com>

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
 scripts/lib/wic/imager/direct.py | 26 --------------------------
 1 file changed, 26 deletions(-)

diff --git a/scripts/lib/wic/imager/direct.py b/scripts/lib/wic/imager/direct.py
index 63f1fa1..6340a59 100644
--- a/scripts/lib/wic/imager/direct.py
+++ b/scripts/lib/wic/imager/direct.py
@@ -185,32 +185,6 @@ class DirectImageCreator:
         # partitions list from kickstart file
         return self.ks.partitions
 
-    def get_disk_names(self):
-        """ Returns a list of physical target disk names (e.g., 'sdb') which
-        will be created. """
-
-        if self._disk_names:
-            return self._disk_names
-
-        #get partition info from ks handler
-        parts = self._get_parts()
-
-        for i in range(len(parts)):
-            if parts[i].disk:
-                disk_name = parts[i].disk
-            else:
-                raise CreatorError("Failed to create disks, no --ondisk "
-                                   "specified in partition line of ks file")
-
-            if parts[i].mountpoint and not parts[i].fstype:
-                raise CreatorError("Failed to create disks, no --fstype "
-                                   "specified for partition with mountpoint "
-                                   "'%s' in the ks file")
-
-            self._disk_names.append(disk_name)
-
-        return self._disk_names
-
     def _full_name(self, name, extention):
         """ Construct full file name for a file we generate. """
         return "%s-%s.%s" % (self.name, name, extention)
-- 
2.1.4



  parent reply	other threads:[~2017-01-24 14:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24 13:43 [PATCH 0/8] Fix for #10783 wic should not be writing out to /var/tmp/wic Ed Bartosh
2017-01-24 13:43 ` [PATCH 1/8] wic: change default output directory Ed Bartosh
2017-01-24 13:43 ` [PATCH 2/8] wic: get rid of baseimager inheritance Ed Bartosh
2017-01-24 13:43 ` [PATCH 3/8] wic: make workdir a temporary directory Ed Bartosh
2017-01-24 13:43 ` Ed Bartosh [this message]
2017-01-24 13:43 ` [PATCH 5/8] wic: direct.py: get rid of names with two underscores Ed Bartosh
2017-01-24 13:43 ` [PATCH 6/8] image_types: use correct output directory Ed Bartosh
2017-01-24 13:43 ` [PATCH 7/8] selftest: wic: explicitly specify " Ed Bartosh
2017-01-24 13:43 ` [PATCH 8/8] selftest: wic: test default " Ed Bartosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c417d955a79593025280334e54e4594de2e4ac3.1485264964.git.ed.bartosh@linux.intel.com \
    --to=ed.bartosh@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.