From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5AF17C0218F for ; Sun, 2 Feb 2025 15:26:15 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tebrQ-0006rk-BM; Sun, 02 Feb 2025 15:26:13 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tebrP-0006rd-7I for linux-f2fs-devel@lists.sourceforge.net; Sun, 02 Feb 2025 15:26:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nAuHDWmks/PdDVRNMLxmVkyazEwen7unn+lyClwJsgI=; b=QntiPldi7s8tEHlqvusMLEWxYN i3cEY2EII3XkTDF5DhknqOQhVbMN51AGwPBbH3sL0v2H09G23LfpUNu19osveWUJL2qJ3a5RxBOaO Wi1iCDIy1qx1mNZMft9k7Y+kkdjFCYJUpMt5OclmnjcdQu6XbwVrllNye4Ti5rbQJg9o=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nAuHDWmks/PdDVRNMLxmVkyazEwen7unn+lyClwJsgI=; b=lz1uD1Iyv53Nyhbeyb62fJuImX Rl/ze4nxDu4TAIxndfcTQI5xmoSjLNCfdpdIxMKlMgdvncnJOvH69yaYBB0MjMZtJsP2jSqQoxqCR piBSO3Xmyxf2wfQLFjZi7NrY1hOhVH9daDwhtc0yNxpp8iIgoxhpByYWYAGH5VqpcUxo=; Received: from mail-qt1-f174.google.com ([209.85.160.174]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1tebrM-0001kO-GB for linux-f2fs-devel@lists.sourceforge.net; Sun, 02 Feb 2025 15:26:11 +0000 Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-46fa764aac2so31710241cf.1 for ; Sun, 02 Feb 2025 07:26:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1738509957; x=1739114757; darn=lists.sourceforge.net; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nAuHDWmks/PdDVRNMLxmVkyazEwen7unn+lyClwJsgI=; b=frODVAY1jrIn2TwojMv5CClABhepZajoJHJD1yr5CwGMZ3YW18Bj4gI2u5OSm0cXyN Qe7pWPiQB8O37F0kO+w3tgsYafKTPWiRG7j9LllOChbpaSZoUDH1C1DK0ExF3GWHG3xs 3yz2dCSy8RBUVYh4xKdr1eyMJxKjTu8M1Mm8GQWuGUgKbpmHHArLPw1cpFquXItqgtzT 47EedimkbZK4iTSB/YRqjkVo8aSCqSd3B7tTH1k/I57XQtPB9JfsrA+zPHCLbqCgFr0N eU1mVGV5Zg79fBVJblbtKN3UEDDbUip1ay/Z+iEWe98wyS/MgZuVu8S0LMn+F3/5irtz qR2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738509957; x=1739114757; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nAuHDWmks/PdDVRNMLxmVkyazEwen7unn+lyClwJsgI=; b=r5Xiibx40xEbGzDaVbwd3ihgY0c9VLiZkN4ekR2IfWrxTipb8estUa3tzHXVj46ZPL Ci7CWo4zRDUpbZeMSIWN1xtBxkgYwiXEde5V9O9DeTwL32kLaIf1v+qfjGA/BnK4AwjM 6r5mo0SI0fyknV5PBa5Y0D7uMhf6s5gkpobXIt1F3BYviF8cTgmYfO9mPglHqViXVGf4 DI1eohL7Hts6d6DTmzO+YjdKK6IcMABJ3VXovBZ7tBPlDL55szgsRhoqw7i5JmX2FTc1 uZM4ZUiIA5v/fNfKa4+kheN41Zov2CpHzWX+Ki9xm6yB/f/WWd7vXTBFtPZNXbnxeNJJ NOig== X-Forwarded-Encrypted: i=1; AJvYcCUxZxOavF7t3dwilO/03Hl1FqUtBalMBs4UtwanXP9VHMlOkOgUb5R0/4m2upOM6Fk0fF7eZf8KjusimvwQI2Wu@lists.sourceforge.net X-Gm-Message-State: AOJu0Yw2AmtpsZyUNPmawb5/OxYdL0/BwZ+SZZDBHrVQNY6PV4Ku4ZA6 keLdfl9YBTtOAUQ+/Gy51tJPfyhCPzSOWP3CcWjs3lwz79GDYPpGONGlxrgcuz0oEZgOch3+L9X L X-Gm-Gg: ASbGncvcgw0rTe0Oer5Le2IMZ7rp8Ge8/jWT4WKFTLh821pMNY6z807Imwx/g5lcnjX XY20rhJXkX6Quv856/+wu++3e41X6v2FfaayZAKrL46YQTJwvO2oOp4EuVKIIo9E3u0KLmvq96i itZvYFOFuYc0vioDCltYDWFH1FDR9pmyB7woUuZmB3dgypUsHIDIwbydR15GGtotnJ0mWSrtyqg C8Bb50+9IYh78wNrnGqAgYvLTlMcOFJV4lS7dhcv8X7+gccjuFEYNVptoS/dovEkzyD262sHZg9 CUyO7GFEBQ6U X-Google-Smtp-Source: AGHT+IGukiziiC1rLjM6JzNMSPR3ZwXkwHF2OgEI6BKabzKWh1pSdyxOGKbkMwtPxxnvRPz9dK83Ig== X-Received: by 2002:a05:6602:418b:b0:843:e8d0:a728 with SMTP id ca18e2360f4ac-8541111199cmr2011722539f.4.1738508713097; Sun, 02 Feb 2025 07:05:13 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-854a15cf87dsm197686139f.5.2025.02.02.07.05.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Feb 2025 07:05:12 -0800 (PST) Message-ID: <4c45eff4-e87a-4eff-a760-b3b7d86b1987@kernel.dk> Date: Sun, 2 Feb 2025 08:05:11 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Kohei Enju , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20250202043253.64389-1-enjuk@amazon.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <20250202043253.64389-1-enjuk@amazon.com> X-Headers-End: 1tebrM-0001kO-GB Subject: Re: [f2fs-dev] [PATCH v1] f2fs: remove unnecessary null checking X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Le Moal , Chaitanya Kulkarni , Johannes Thumshirn , Jaegeuk Kim , Kohei Enju Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2/1/25 9:32 PM, Kohei Enju wrote: > When __GFP_DIRECT_RECLAIM (included in both GFP_NOIO and GFP_KERNEL) is > specified, bio_alloc_bioset() never fails to allocate a bio. > Commit 67883ade7a98 ("f2fs: remove FAULT_ALLOC_BIO") replaced > f2fs_bio_alloc() with bio_alloc_bioset(), but null checking after > bio_alloc_bioset() was still left. Reviewed-by: Jens Axboe -- Jens Axboe _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 391A615ECD7 for ; Sun, 2 Feb 2025 15:05:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738508716; cv=none; b=Iru4q5HWKjT0/Tv2aCyefv8qZGiM8/BLU0/r9xkmzBuFrE2UdhC1y/9Lie2v3ZI+vFKMygd9R3eaVwMaKTNWDc4OzR+R7k7wJvLw8g5y10YhzkiFAeEsZs7Sf3c5ebb9MIVCjgaXw4tCsFEhvP10zV/XtnkIgOC6zjPKbrePKz8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738508716; c=relaxed/simple; bh=EsKzWtXGXEFwMb2VmpbcTurGkOqRVIJgXPTfV5VZUvY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mr8a/d01zCmD8C3d3glQMFdgpg7FQgU1jFK/LPDrsDOiCyVy32SdzGwzyYvexuEreDTUCZdS/318OhrI/IRpLhza+WZCRpPo/s5AvKnPRvci5EGJYx2w7N3XDxlbfqN4tBWmHM29lUPI0QZm5W1A5ndOkiLW2/svqddobemkTow= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=gNmFzeBF; arc=none smtp.client-ip=209.85.166.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="gNmFzeBF" Received: by mail-io1-f42.google.com with SMTP id ca18e2360f4ac-8521df70be6so320525639f.1 for ; Sun, 02 Feb 2025 07:05:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1738508713; x=1739113513; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nAuHDWmks/PdDVRNMLxmVkyazEwen7unn+lyClwJsgI=; b=gNmFzeBF2xwWOzOxeSSzdQQr/SzSMoNyrRJvQY/Ep/ok91qcu1B303GETvH4/o0pUO dDrBjW2WZzPmdgVbHIIrl8RMUGZf8oveSghd/xVqqUC+X3nM9VJh9gEtU6fiIBG9Yiyh kusQTjvbUMc6K61nG+Ec0tPaiYP96/p5soNWoVd9pY4GjXJeEXjIJQAKTlWGVz+Iyhpx 7BkEeWfSNgYwqHhPjCn1uMpoeNekW719r8rpuSua34rSBefvfUmV5cmpg6mb/Tw8xnm/ Oi62D4Cwv6PPp0hPU0jxr9Kbu5CVYHu2c8qUhNErxLY3FvoRqIelAxI3Ji5KmvrFji41 tuzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738508713; x=1739113513; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nAuHDWmks/PdDVRNMLxmVkyazEwen7unn+lyClwJsgI=; b=NV7w2atSDgLqPlXhRKWIlBFFtIU2d+P8YodWtRghTwOtKQq+YWQSm0sGK9GnxHnS6l bn+h4PY33TlRjdMFemay/lpXnOrBfH42OnZyydu3lkVSW7nrR4lZXDPxmjYTu7qc8V2z nJuZswUMvkFkDFhbyvRAd+0WuZuz2AGBmFcl/9WKrVO2TbIzH3P0EcOQdpgFRyJFMleR LKez5i/ys2yFa6MfuTQfYCHpP1rb8lkWKAzGpgv1skFMD+ElZd1DmRO1CVpb4Af1g8wc NFbpmydcAp9LS0sHibbKLMt23jmqeKht+qV6G6VBXaa6BUituGUkxlWI9VJR/OQj5ATH p26Q== X-Forwarded-Encrypted: i=1; AJvYcCUD6HHuUEX2sQ+IGURWppD1I/GRqbSczf4heX/Pbh0EFgJlwMN2rG6Ld7Q9v39/6eeKIf/k+OfwYjFlztY=@vger.kernel.org X-Gm-Message-State: AOJu0YyHQbzPSUPSXGLdWipeqMwss6QE4dweBCVSrcGRPmegVDM6nkcj fW3tzIj9B7qDTGYY2Yr5Ei9oO/baP2FTM58Lp6A1WN+n7f9Vr7byvSxcTtZGE8Y= X-Gm-Gg: ASbGncv4j9Eawaomvm/zDQ3EpJgCNHk0Dlg8ZJgXUOqmsEWu5j/eLsTx99fPDdAZV6h R5T9/8oNFX5qPoYhmcGVPHOMXXOen37SXyBfQ/fAE3c8SW62OfEKIuEXAEdo8s5u/ikI1agDSet F3aJrrpOkmxOL7FMDi5xD2knn4CpH/vr/n/O6cuVPpMLizI4IFNPBkbkp3i3Ps9j6H65j+P5BW0 NxWW76V8aLagD01DUhflA5a3o6wKjRXxsI83Pv4Sflv+YGy28H5kOO15Lvii5lzI+okxzG2R8FV HsFbo79CiEbI X-Google-Smtp-Source: AGHT+IGukiziiC1rLjM6JzNMSPR3ZwXkwHF2OgEI6BKabzKWh1pSdyxOGKbkMwtPxxnvRPz9dK83Ig== X-Received: by 2002:a05:6602:418b:b0:843:e8d0:a728 with SMTP id ca18e2360f4ac-8541111199cmr2011722539f.4.1738508713097; Sun, 02 Feb 2025 07:05:13 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-854a15cf87dsm197686139f.5.2025.02.02.07.05.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Feb 2025 07:05:12 -0800 (PST) Message-ID: <4c45eff4-e87a-4eff-a760-b3b7d86b1987@kernel.dk> Date: Sun, 2 Feb 2025 08:05:11 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] f2fs: remove unnecessary null checking To: Kohei Enju , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Cc: Jaegeuk Kim , Chao Yu , Damien Le Moal , Chaitanya Kulkarni , Johannes Thumshirn , Kohei Enju References: <20250202043253.64389-1-enjuk@amazon.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <20250202043253.64389-1-enjuk@amazon.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/1/25 9:32 PM, Kohei Enju wrote: > When __GFP_DIRECT_RECLAIM (included in both GFP_NOIO and GFP_KERNEL) is > specified, bio_alloc_bioset() never fails to allocate a bio. > Commit 67883ade7a98 ("f2fs: remove FAULT_ALLOC_BIO") replaced > f2fs_bio_alloc() with bio_alloc_bioset(), but null checking after > bio_alloc_bioset() was still left. Reviewed-by: Jens Axboe -- Jens Axboe