All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andy Chittenden" <andyc.bluearc@gmail.com>
To: "'David S. Miller'" <davem@davemloft.net>,
	"'Alexey Kuznetsov'" <kuznet@ms2.inr.ac.ru>,
	"'Pekka Savola (ipv6'" <pekkas@netcore.fi>,
	"'James Morris'" <jmorris@namei.org>,
	"'Hideaki YOSHIFUJI'" <yoshfuji@linux-ipv6.org>,
	"'Patrick McHardy'" <kaber@trash.net>,
	"'Eric Dumazet'" <eric.dumazet@gmail.com>,
	William.Allen.Simpson@gmail.com,
	"'Gilad Ben-Yossef'" <gilad@codefidence.com>,
	"'Ilpo Järvinen'" <ilpo.jarvinen@helsinki.fi>,
	netdev@vger.kernel.org,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Cc: <akpm@linux-foundation.org>
Subject: [PATCH] [Bug 16494] NFS client over TCP hangs due to packet loss
Date: Tue, 3 Aug 2010 09:14:31 +0100	[thread overview]
Message-ID: <4c57cfe8.887b0e0a.2f79.4772@mx.google.com> (raw)

I don't know whether this patch is the correct fix or not but it enables the
NFS client to recover.

Kernel version: 2.6.34.1 and 2.6.32.

Fixes <https://bugzilla.kernel.org/show_bug.cgi?id=16494>. It clears down
any previous shutdown attempts so that reconnects on a socket that's been
shutdown leave the socket in a usable state (otherwise tcp_sendmsg() returns
-EPIPE).

# diff -up /home/company/software/src/linux-2.6.34.1/net/ipv4/tcp_output.c
net/ipv4
--- /home/company/software/src/linux-2.6.34.1/net/ipv4/tcp_output.c
2010-07-27 08:46:46.917000000 +0100
+++ net/ipv4/tcp_output.c       2010-07-27 09:19:16.000000000 +0100
@@ -2522,6 +2522,13 @@ static void tcp_connect_init(struct sock
        struct tcp_sock *tp = tcp_sk(sk);
        __u8 rcv_wscale;

+       /* clear down any previous shutdown attempts so that
+        * reconnects on a socket that's been shutdown leave the
+        * socket in a usable state (otherwise tcp_sendmsg() returns
+        * -EPIPE).
+        */
+       sk->sk_shutdown = 0;
+
        /* We'll fix this up when we get a response from the other end.
         * See tcp_input.c:tcp_rcv_state_process case TCP_SYN_SENT.
         */

Signed-off-by: Andy Chittenden <andyc.bluearc@gmail.com>




             reply	other threads:[~2010-08-03  8:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-03  8:14 Andy Chittenden [this message]
2010-08-03  8:21 ` [PATCH] [Bug 16494] NFS client over TCP hangs due to packet loss David Miller
2010-08-03  9:11   ` Andrew Morton
2010-08-03  9:11     ` Andrew Morton
2010-08-03 10:25     ` Andy Chittenden
2010-08-03 10:25       ` Andy Chittenden
2010-08-05 14:55       ` Andy Chittenden
2010-08-05 14:55         ` Andy Chittenden
2010-08-05 19:50         ` Trond Myklebust
2010-08-05 19:50           ` Trond Myklebust
2010-08-06  9:30           ` Andy Chittenden
2010-08-06  9:30             ` Andy Chittenden
2010-08-09  9:27             ` Andy Chittenden
2010-08-09 16:55               ` Trond Myklebust
2010-08-10  8:40                 ` Andy Chittenden
2010-08-10  8:40                   ` Andy Chittenden
2018-06-19 21:56               ` Joe Perches
2018-06-20 16:40                 ` Andy C
  -- strict thread matches above, loose matches on Subject: below --
2010-08-03  8:14 Andy Chittenden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c57cfe8.887b0e0a.2f79.4772@mx.google.com \
    --to=andyc.bluearc@gmail.com \
    --cc=William.Allen.Simpson@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=gilad@codefidence.com \
    --cc=ilpo.jarvinen@helsinki.fi \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pekkas@netcore.fi \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.