[Qemu-devel] RE: [PATCH] Block: Support creation of SCSI VMDK images in qemu-img.

[Aaron Mason <aaron.mason@thats-too-much.info>]

Hi Kevin,

Yep, I'll be resubmitting that patch in the coming days.  I thought I'd nuked all of the tabs but neglected to check if I was editing the file in the git repo and not the 0.12.5 stable branch...

Also, I'm new to using git so I'm picking this up as I go along.  Expect a patch from me in the coming days.

Cheers

sent from my Telstra NEXTG™ handset

-----Original Message-----
From: Kevin Wolf <kwolf@redhat.com>
Sent: Tuesday, 3 August 2010 10:47 PM
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel List <qemu-devel@nongnu.org>; Aaron Mason <aaron.mason@thats-too-much.info>
Subject: Re: [PATCH] Block: Support creation of SCSI VMDK images in qemu-img.

Hi Alex,

Am 03.08.2010 14:17, schrieb Alexander Graf:
> While looking through patches we have not upstreamed yet, I stumbled over this
> trivial patch that Kevin created back in the day. It allows to specify the
> creation of scsi type vmdk images.
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>

Aaron (CCed) sent a similar patch only a few days ago (subject
"[Qemu-devel] PATCH: Adding options to generate SCSI based VMDK
images"). The only difference I see is that his option went like
interface=[ide|lsilogic|buslogic] instead of hard-coding lsilogic. I
think this is a better interface.

Aaron, I asked you to fix some formal things (including tabs and SoB),
but you haven't resubmitted the patch yet. Are you going to send a fixed
version, or should I rather take Alex' patch?

Kevin

> ---
>  block/vmdk.c |   12 ++++++++++--
>  block_int.h  |    2 ++
>  2 files changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/block/vmdk.c b/block/vmdk.c
> index 2d4ba42..64f1c88 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -686,7 +686,7 @@ static int vmdk_create(const char *filename, QEMUOptionParameter *options)
>          "ddb.geometry.cylinders = \"%" PRId64 "\"\n"
>          "ddb.geometry.heads = \"16\"\n"
>          "ddb.geometry.sectors = \"63\"\n"
> -        "ddb.adapterType = \"ide\"\n";
> +        "ddb.adapterType = \"%s\"\n";
>      char desc[1024];
>      const char *real_filename, *temp_str;
>      int64_t total_size = 0;
> @@ -702,6 +702,8 @@ static int vmdk_create(const char *filename, QEMUOptionParameter *options)
>              backing_file = options->value.s;
>          } else if (!strcmp(options->name, BLOCK_OPT_COMPAT6)) {
>              flags |= options->value.n ? BLOCK_FLAG_COMPAT6: 0;
> +        } else if (!strcmp(options->name, BLOCK_OPT_SCSI)) {
> +            flags |= options->value.n ? BLOCK_FLAG_SCSI: 0;
>          }
>          options++;
>      }
> @@ -799,7 +801,8 @@ static int vmdk_create(const char *filename, QEMUOptionParameter *op

[The entire original message is not included]