All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: netdev-bot+sashiko@kernel.org
Cc: martineau@kernel.org, geliang@kernel.org, davem@davemloft.net,
	edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com,
	horms@kernel.org, fw@strlen.de, dmytro@shytyi.net,
	netdev@vger.kernel.org, mptcp@lists.linux.dev,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	mason@kernel.org
Subject: Re: [PATCH net 7/7] mptcp: fix dummy mapping of overlapping segments
Date: Wed, 18 Nov 2026 23:04:02 +0100	[thread overview]
Message-ID: <4c783bb9-d988-48c3-8849-8ec0c9ea1eb3@kernel.org> (raw)
In-Reply-To: <179495459243.3136.9349092580555178374@kernel.org>

Hello,

On 17/11/2026 23:29, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found more severe
> issue(s) in other patches of this series. This mail is only an FYI, in case
> you want to address the nit picks below when you respin.
> 
> Low priority / nit picks for your consideration:

(...)

> Link: https://lore.kernel.org/4c48d016490d43b6892c622cbae858b48f176cff.1794304840.git.tanggeliang@kylinos.cn [1]
> 
>> Author: Geliang Tang <geliang@kernel.org>
> 
> [ ... ]
> 
>> Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
> 
> [Severity: Low]
> This isn't a bug, but the author address and the address in the author's
> sign-off are different. The author is geliang@kernel.org, and the only
> sign-off from Geliang uses tanggeliang@kylinos.cn. No sign-off uses the
> author address.
> 
> scripts/checkpatch.pl reports this as a FROM_SIGN_OFF_MISMATCH warning
> ("From:/Signed-off-by: email address mismatch"). The names match exactly
> but the addresses do not, and checkpatch does not look at .mailmap.
> 
> .mailmap already maps the two addresses to the same person:
> 
>     Geliang Tang <geliang@kernel.org> <tanggeliang@kylinos.cn>
> 
> So this only affects the consistency of the tags. The DCO itself is not
> in question.
> 
> Since this carries Cc: stable, could the author be set to the kylinos.cn
> address, or the sign-off use geliang@kernel.org (changed or added), before
> the patch is applied?

False positive: the author is tanggeliang@kylinos.cn, see the "From:"
line at the top of the email body. geliang@kernel.org comes from
.mailmap.

This looks like a bug in Clashiko, Sashiko didn't report that.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


  reply	other threads:[~2026-11-18 22:04 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 22:06 [PATCH net 0/7] mptcp: misc fixes for v7.4-rc4 Matthieu Baerts (NGI0)
2026-11-16 22:06 ` [PATCH net 1/7] mptcp: do not use a raised snd_wnd for the send window Matthieu Baerts (NGI0)
2026-11-16 22:06 ` [PATCH net 2/7] mptcp: push pending data after a sendmsg copy fault Matthieu Baerts (NGI0)
2026-11-17 22:09   ` sashiko-bot
2026-11-17 22:29   ` netdev-bot+sashiko
2026-11-18 22:01     ` Matthieu Baerts
2026-11-16 22:06 ` [PATCH net 3/7] mptcp: use sk instead of casting msk in check_fully_established() Matthieu Baerts (NGI0)
2026-11-16 22:06 ` [PATCH net 4/7] mptcp: push queued data on passive TFO subflows becoming established Matthieu Baerts (NGI0)
2026-11-17 22:29   ` netdev-bot+sashiko
2026-11-18 22:02     ` Matthieu Baerts
2026-11-16 22:06 ` [PATCH net 5/7] mptcp: push queued data on subflows falling back at the handshake Matthieu Baerts (NGI0)
2026-11-17 22:09   ` sashiko-bot
2026-11-17 22:29   ` netdev-bot+sashiko
2026-11-18 22:02     ` Matthieu Baerts
2026-11-16 22:06 ` [PATCH net 6/7] mptcp: don't send a FIN before the pending data on fallback Matthieu Baerts (NGI0)
2026-11-17 22:09   ` sashiko-bot
2026-11-17 22:29   ` netdev-bot+sashiko
2026-11-18 22:03     ` Matthieu Baerts
2026-11-16 22:06 ` [PATCH net 7/7] mptcp: fix dummy mapping of overlapping segments Matthieu Baerts (NGI0)
2026-11-17 22:29   ` netdev-bot+sashiko
2026-11-18 22:04     ` Matthieu Baerts [this message]
2026-11-18 22:05 ` [PATCH net 0/7] mptcp: misc fixes for v7.4-rc4 Matthieu Baerts
2026-11-20  2:32   ` Jakub Kicinski
2026-11-20  8:50     ` Matthieu Baerts
2026-11-20  2:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c783bb9-d988-48c3-8849-8ec0c9ea1eb3@kernel.org \
    --to=matttbe@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dmytro@shytyi.net \
    --cc=edumazet@kernel.org \
    --cc=fw@strlen.de \
    --cc=geliang@kernel.org \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martineau@kernel.org \
    --cc=mason@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.