All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleksii Kurochko <oleksii.kurochko@gmail.com>
To: Baptiste Le Duc <baptiste.le-duc@vates.tech>,
	xen-devel@lists.xenproject.org
Cc: Doug Goldstein <cardoe@cardoe.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony PERARD <anthony.perard@vates.tech>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Alistair Francis <alistair.francis@wdc.com>,
	Connor Davis <connojdavis@gmail.com>,
	Alejandro Vallejo <alejandro.garciavallejo@amd.com>,
	Zhang Zheng <zhangzheng@iscas.ac.cn>
Subject: Re: [PATCH v3 1/6] CI: add a Debian 13 riscv64 QTB container
Date: Thu, 19 Nov 2026 12:09:44 +0100	[thread overview]
Message-ID: <4c8566e0-86ca-4c18-90a4-1f44e4db6df2@gmail.com> (raw)
In-Reply-To: <1793714905.8631fc262581453bbf619ec5b2062170.1a1a1bd621c000403d@vates.tech>



On 11/3/26 3:08 PM, Baptiste Le Duc wrote:
> The riscv64 QTB tests use QTB (QEMU Test Bench) Python package. QTB is part
> of AMD's work on the 'safety' branch [1] of their QEMU fork and is not
> upstream in QEMU yet. The tests also need pytest and qemu-system-riscv64.
> 
> Add debian:13-riscv64-qtb, a Debian Trixie container with those packages
> and the QTB package installed from the python/ directory of AMD's QEMU
> fork, at the commit pinned by QEMU_REPO/QEMU_COMMIT. Make it available to
> containerize script as trixie-riscv64-qtb.
> 
> QTB depends on pexpect, ptyprocess, pygdbmi and qemu.qmp. Rather than
> fetching them from PyPI, install them from the wheels vendored in the
> python/wheels/ directory of the same fork commit, with pip --no-index.
> 
> [1] https://gitlab.com/xen-project/people/amd/qemu/-/tree/safety?ref_type=heads
> 
> Suggested-by: Stefano Stabellini <sstabellini@kernel.org>
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Baptiste Le Duc <baptiste.le-duc@vates.tech>
> ---
> The CI jobs running the tests in this container come in a later patch.
> ---
> Changes in v3:
> - Move the container from test-artifacts to xen.git (automation/build/),
>    renamed debian:13-riscv64-qtb.
> - Install the QTB dependencies from the wheels vendored in the fork, with
>    pip --no-index.
> - Add pytest, drop jinja2, yaml and device-tree-compiler.
> - Comment that the pinned commit is the tip of the safety branch.
> - Reword the commit title and message.
> ---
>   automation/build/debian/13-riscv64-qtb.dockerfile | 47 +++++++++++++++++++++++
>   automation/scripts/containerize                   |  1 +
>   2 files changed, 48 insertions(+)
> 
> diff --git a/automation/build/debian/13-riscv64-qtb.dockerfile b/automation/build/debian/13-riscv64-qtb.dockerfile
> new file mode 100644
> index 0000000000..34ca1f2b7d
> --- /dev/null
> +++ b/automation/build/debian/13-riscv64-qtb.dockerfile
> @@ -0,0 +1,47 @@
> +# syntax=docker/dockerfile:1
> +FROM --platform=linux/amd64 debian:trixie-slim
> +LABEL maintainer.name="The Xen Project"
> +LABEL maintainer.email="xen-devel@lists.xenproject.org"
> +
> +ENV DEBIAN_FRONTEND=noninteractive
> +
> +ARG QEMU_REPO=https://gitlab.com/xen-project/people/amd/qemu.git
> +# Tip of the safety branch
> +ARG QEMU_COMMIT=24cd7e5c0d7e4db8e651f091d0b9da2e7c58dbab
> +
> +RUN <<EOF
> +#!/bin/bash
> +    set -eu
> +
> +    useradd --create-home user
> +
> +    apt-get update
> +
> +    DEPS=(# Base environment
> +        ca-certificates
> +        git
> +        python3-minimal
> +        python3-pip

Nit: the other dockerfiles put the comment on its own line after "DEPS=(".
Also, python3-pip already pulls in python3, so python3-minimal looks
redundant.

Other LGTM:
  Reviewed-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>

I've also tested it by:

$ podman build -t qtb-review -f 
automation/build/debian/13-riscv64-qtb.dockerfile automation/build/debian

And it looks everything is on the place so:

Tested-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>

~ Oleksii


  parent reply	other threads:[~2026-11-19 11:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1793714671.8631fc262581453bbf619ec5b2062170.1a1a1b9ce9c000403d@vates.tech/T/#u>
2026-11-03 14:08 ` [PATCH v3 1/6] CI: add a Debian 13 riscv64 QTB container Baptiste Le Duc
2026-11-03 14:15   ` Baptiste Le Duc
2026-11-19 11:09   ` Oleksii Kurochko [this message]
     [not found]   ` <k4hxivkhib6yi7onicgs4ws2earwcawmds3bmp5nefjrw525qo@w6wxrkpdhoru>
2026-11-19 10:38     ` Oleksii Kurochko
2026-11-19 15:28     ` Baptiste Le Duc
2026-11-19 17:21   ` dmukhin
2026-11-03 14:08 ` [PATCH v3 2/6] automation/qtb: add the QTB machine for riscv64 Baptiste Le Duc
2026-11-03 14:08 ` [PATCH v3 3/6] automation/qtb: add the console-test type with a Xen boot test Baptiste Le Duc
2026-11-03 14:08 ` [PATCH v3 4/6] automation/qtb: add QTB framework README Baptiste Le Duc
2026-11-03 14:08 ` [PATCH v3 5/6] CI: add a riscv64 smoke test job using the QTB console-test Baptiste Le Duc
2026-11-03 14:08 ` [PATCH v3 6/6] CI: drop the riscv64 expect-based smoke test Baptiste Le Duc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c8566e0-86ca-4c18-90a4-1f44e4db6df2@gmail.com \
    --to=oleksii.kurochko@gmail.com \
    --cc=alejandro.garciavallejo@amd.com \
    --cc=alistair.francis@wdc.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=anthony.perard@vates.tech \
    --cc=baptiste.le-duc@vates.tech \
    --cc=cardoe@cardoe.com \
    --cc=connojdavis@gmail.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    --cc=zhangzheng@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.