All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>, ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, Kalle Valo <kvalo@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jeff Johnson <jjohnson@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 07/13] wifi: ath12k: add support for fixed QMI firmware memory
Date: Thu, 30 Jan 2025 08:46:30 +0100	[thread overview]
Message-ID: <4c9b512f-59d2-4d96-a899-5af4de2c823e@kernel.org> (raw)
In-Reply-To: <20250130043508.1885026-8-quic_rajkbhag@quicinc.com>

On 30/01/2025 05:35, Raj Kumar Bhagat wrote:
> @@ -2646,6 +2663,136 @@ static int ath12k_qmi_alloc_target_mem_chunk(struct ath12k_base *ab)
>  	return ret;
>  }
>  
> +static int ath12k_qmi_assign_target_mem_chunk(struct ath12k_base *ab)
> +{
> +	struct device_node *mem_node;
> +	struct resource res, m3_res;
> +	u32 bdf_start_addr;
> +	int i, idx, ret;
> +
> +	for (i = 0, idx = 0; i < ab->qmi.mem_seg_count; i++) {
> +		switch (ab->qmi.target_mem[i].type) {
> +		case HOST_DDR_REGION_TYPE:
> +			mem_node = ath12k_core_get_reserved_mem_by_name(ab, "q6-region");


Why cannot you use existing API for reserved memory -
of_reserved_mem_lookup()?

Best regards,
Krzysztof


  reply	other threads:[~2025-01-30  7:47 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-30  4:34 [PATCH v5 00/13] wifi: ath12k: add Ath12k AHB driver support for IPQ5332 Raj Kumar Bhagat
2025-01-30  4:34 ` [PATCH v5 01/13] dt-bindings: net: wireless: describe the ath12k AHB module Raj Kumar Bhagat
2025-01-30  8:28   ` Krzysztof Kozlowski
2025-01-30  8:40     ` Krzysztof Kozlowski
2025-02-03  8:43       ` Raj Kumar Bhagat
2025-02-03 10:05         ` Krzysztof Kozlowski
2025-02-03 10:27           ` Raj Kumar Bhagat
2025-02-03  9:05     ` Raj Kumar Bhagat
2025-02-03 10:09       ` Krzysztof Kozlowski
2025-02-04  5:57         ` Raj Kumar Bhagat
2025-02-04  7:30           ` Krzysztof Kozlowski
2025-01-30 19:07   ` Jeff Johnson
2025-02-03  9:07     ` Raj Kumar Bhagat
2025-01-30  4:34 ` [PATCH v5 02/13] wifi: ath12k: fix incorrect CE addresses Raj Kumar Bhagat
2025-01-30  4:34 ` [PATCH v5 03/13] wifi: ath12k: refactor ath12k_hw_regs structure Raj Kumar Bhagat
2025-01-30  4:34 ` [PATCH v5 04/13] wifi: ath12k: add ath12k_hw_params for IPQ5332 Raj Kumar Bhagat
2025-01-30  4:35 ` [PATCH v5 05/13] wifi: ath12k: avoid m3 firmware download in AHB device IPQ5332 Raj Kumar Bhagat
2025-01-30  4:35 ` [PATCH v5 06/13] wifi: ath12k: Add hw_params to remap CE register space for IPQ5332 Raj Kumar Bhagat
2025-01-30  4:35 ` [PATCH v5 07/13] wifi: ath12k: add support for fixed QMI firmware memory Raj Kumar Bhagat
2025-01-30  7:46   ` Krzysztof Kozlowski [this message]
2025-02-03  9:44     ` Raj Kumar Bhagat
2025-02-03 10:12       ` Krzysztof Kozlowski
2025-02-04  9:06         ` Raj Kumar Bhagat
2025-02-05  9:07           ` Krzysztof Kozlowski
2025-02-05  9:59             ` Raj Kumar Bhagat
2025-01-30  4:35 ` [PATCH v5 08/13] wifi: ath12k: add AHB driver support for IPQ5332 Raj Kumar Bhagat
2025-01-30  7:57   ` Krzysztof Kozlowski
2025-02-04 15:45     ` Raj Kumar Bhagat
2025-01-30  4:35 ` [PATCH v5 09/13] wifi: ath12k: Power up root PD Raj Kumar Bhagat
2025-01-30  7:58   ` Krzysztof Kozlowski
2025-02-04 16:16     ` Raj Kumar Bhagat
2025-01-30  4:35 ` [PATCH v5 10/13] wifi: ath12k: Register various userPD interrupts and save SMEM entries Raj Kumar Bhagat
2025-01-30  4:35 ` [PATCH v5 11/13] wifi: ath12k: Power up userPD Raj Kumar Bhagat
2025-01-30  4:35 ` [PATCH v5 12/13] wifi: ath12k: Power down userPD Raj Kumar Bhagat
2025-01-30  4:35 ` [PATCH v5 13/13] wifi: ath12k: enable ath12k AHB support Raj Kumar Bhagat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c9b512f-59d2-4d96-a899-5af4de2c823e@kernel.org \
    --to=krzk@kernel.org \
    --cc=ath12k@lists.infradead.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jjohnson@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_rajkbhag@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.