From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08E36C27C6E for ; Thu, 13 Jun 2024 15:53:20 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.740084.1147088 (Exim 4.92) (envelope-from ) id 1sHml9-0004Sw-Lp; Thu, 13 Jun 2024 15:53:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 740084.1147088; Thu, 13 Jun 2024 15:53:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sHml9-0004Sp-In; Thu, 13 Jun 2024 15:53:07 +0000 Received: by outflank-mailman (input) for mailman id 740084; Thu, 13 Jun 2024 15:53:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sHml7-0004Sh-Ul for xen-devel@lists.xenproject.org; Thu, 13 Jun 2024 15:53:05 +0000 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [2a00:1450:4864:20::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 054695f3-299d-11ef-90a3-e314d9c70b13; Thu, 13 Jun 2024 17:53:04 +0200 (CEST) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-a6269885572so402393666b.1 for ; Thu, 13 Jun 2024 08:53:04 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f56db6b32sm85095666b.59.2024.06.13.08.53.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jun 2024 08:53:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 054695f3-299d-11ef-90a3-e314d9c70b13 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1718293984; x=1718898784; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=0wkBGFeQc6d141aqiejmspfIqUVIBgsP8HKCCA/h/Sg=; b=BC7wMZZCqQ05L7dzNvHazFhoZWPpH0HMNBZTSOuUG3nKKXD9YJqNJFlC9AQ/mSP+/J 3gq7S0XZu/2iPvjYgN64FkM7cOmg/JMrz8phK8f8+vdws+gSCBRgtfMmGK+gg6Xkej39 6cTna/0hLsarKgyWP5QvSKsIyPc18EBEEse6S7CSdjof22KJ49zlvMEGjX7PEVr8ZUjc BQVRl1pADvs7HSn63MbOXl38eXc26KOlmmWMaMLUFiKMn0G0n+i3HfOLpfyzDSZEEmi6 S0t3iNKhTLkc3nvNgx0vxwxNw1jP1JZ/K6MKcAjnonVmBFyRlmD6gioZp3yidQzi1XVq cFVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718293984; x=1718898784; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0wkBGFeQc6d141aqiejmspfIqUVIBgsP8HKCCA/h/Sg=; b=CBRK61bmAXz8lAwzytnKaDLY1OAz4i2Vqc+jV7vOWj+8Mc61rzPdnuq+zKzW7oF1Do /SwGmzp+ps/P0SKjoedgbThbkvSLPO75aMgyn5oVLGZdHlngNdia1EypAYPVUPgBucEy 5AwhFsdNKzyI3BnnNNJAzevNkHjllleVsUWWS3HwxP3gKedjKwp5hZtWGotS/ugIalh2 om9/Rk8Vh2faGApS+2cxVKh+C7QP4IL0gtKiVwkXe60+5Cv73eZFRMxvqoFpwq+EG1d1 ow3DsTLGw4o0/KCTPcxpG/vEO28xR+8JXBCYg21NgQcm/auQJxy0i5AL4XG4WM4UkNze VLBg== X-Gm-Message-State: AOJu0Yyil/2QPyLufjoJXf9JZHBBDf7KBuX4lhdjI2qhMdw0yuYnyQu9 weHGFRi/5pK8KcsCP1nvI0UDxUOL3Pt7YEv/snsVztBjUQx10KYX6A9lHVhVuLcizCIS+InE4vk = X-Google-Smtp-Source: AGHT+IEsoqNyaRagjRSI18XW8J/p5xP9Sm8+kDFNwdpgzP0l1li/ntQPBI/MeJiblIrAPuWHfm51Yw== X-Received: by 2002:a17:906:57c7:b0:a6e:ffef:b6ab with SMTP id a640c23a62f3a-a6f6080c7b5mr19148566b.7.1718293984278; Thu, 13 Jun 2024 08:53:04 -0700 (PDT) Message-ID: <4cb42dae-430b-4740-bddd-df5c4c783724@suse.com> Date: Thu, 13 Jun 2024 17:53:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH for 4.19?] x86/Intel: unlock CPUID earlier for the BSP To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Oleksii Kurochko References: <82277592-ea96-47c8-a991-7afd97d7a7bc@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 13.06.2024 17:16, Roger Pau Monné wrote: > On Thu, Jun 13, 2024 at 10:19:30AM +0200, Jan Beulich wrote: >> @@ -315,16 +329,7 @@ static void cf_check early_init_intel(st >> bootsym(trampoline_misc_enable_off) & MSR_IA32_MISC_ENABLE_XD_DISABLE) >> printk(KERN_INFO "re-enabled NX (Execute Disable) protection\n"); >> >> - /* Unmask CPUID levels and NX if masked: */ >> - rdmsrl(MSR_IA32_MISC_ENABLE, misc_enable); >> - >> - disable = misc_enable & MSR_IA32_MISC_ENABLE_LIMIT_CPUID; >> - if (disable) { >> - wrmsrl(MSR_IA32_MISC_ENABLE, misc_enable & ~disable); >> - bootsym(trampoline_misc_enable_off) |= disable; >> - printk(KERN_INFO "revised cpuid level: %d\n", >> - cpuid_eax(0)); >> - } >> + intel_unlock_cpuid_leaves(c); > > Do you really need to call intel_unlock_cpuid_leaves() here? > > For the BSP it will be taken care in early_cpu_init(), and for the APs > MSR_IA32_MISC_ENABLE it will be set as part of the trampoline with the > disables from trampoline_misc_enable_off. The way the original code works, it allows to deal with the BSP having the bit clear, but some or all of the APs having it set. I simply didn't want to break that property. Jan