From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932431AbcHJSDJ (ORCPT ); Wed, 10 Aug 2016 14:03:09 -0400 Received: from mga04.intel.com ([192.55.52.120]:54330 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932389AbcHJSCw (ORCPT ); Wed, 10 Aug 2016 14:02:52 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,498,1464678000"; d="scan'208";a="862899844" Subject: Re: [PATCH] perf intel-pt: Fix ip compression To: Arnaldo Carvalho de Melo References: <1469005206-3049-1-git-send-email-adrian.hunter@intel.com> Cc: Jiri Olsa , linux-kernel@vger.kernel.org From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <4cc98408-bf55-439a-e88b-15f1ca57b0ff@intel.com> Date: Wed, 10 Aug 2016 11:32:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1469005206-3049-1-git-send-email-adrian.hunter@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/07/16 12:00, Adrian Hunter wrote: > June 2015 Intel SDM introduced IP Compression types 4 and 6. Refer section > 36.4.2.2 Target IP (TIP) Packet - IP Compression. > > Existing Intel PT packet decoder did not support type 4, and got type 6 > wrong. Because type 3 and type 4 have the same number of bytes, the packet > 'count' has been changed from being the number of ip bytes to being the > type code. That allows the Intel PT decoder to correctly decide whether to > sign-extend or use the last ip. However that also meant the code had to be > adjusted in a number of places. > > Currently hardware is not using the new compression types, so this fix has > no effect on existing hardware. > > Signed-off-by: Adrian Hunter > --- > .../perf/util/intel-pt-decoder/intel-pt-decoder.c | 44 +++++++++++----------- > .../util/intel-pt-decoder/intel-pt-pkt-decoder.c | 24 ++++++++---- > 2 files changed, 40 insertions(+), 28 deletions(-) Hi This is outstanding but still applies. Regards Adrian