Re: [PATCH] staging: r8188eu: simplify control flow

[Pavel Skripkin <paskripkin@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 998 bytes --]

Hi Sevinj,

On 4/3/22 19:12, Sevinj Aghayeva wrote:
>>
>> Looks good, but let's not introduce new checkpatch issue:
>>
>> CHECK: Alignment should match open parenthesis
>> #62: FILE: drivers/staging/r8188eu/core/rtw_mlme.c:1645:
>> +               if ((p->PMKIDList[i].bUsed) &&
>> +                               (!memcmp(p->PMKIDList[i].Bssid, bssid, ETH_ALEN)))
> 
> Thanks for catching this. I wasn't seeing this in my checkpatch
> output, and after some digging, I could reproduce it with --strict
> option. I think the tutorial at
> https://kernelnewbies.org/PatchPhilosophy doesn't mention this option,
> so perhaps we should update it?!
> 

To be honest, I am not checkpatch expert, but checkpatch on my PC shows 
this warning w/o any additional options:

└──$ ./scripts/checkpatch.pl 
./20220403_sevinj_aghayeva_staging_r8188eu_simplify_control_flow.mbx | 
rg Alignment
CHECK: Alignment should match open parenthesis





With regards,
Pavel Skripkin

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]