From: Andrew Lunn <andrew@lunn.ch>
To: Andrei Botila <andrei.botila@oss.nxp.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
s32@nxp.com, Christophe Lizzi <clizzi@redhat.com>,
Alberto Ruiz <aruizrui@redhat.com>,
Enric Balletbo <eballetb@redhat.com>
Subject: Re: [PATCH 1/3] net: phy: nxp-c45-tja11xx: add support for TJA1121
Date: Thu, 27 Feb 2025 17:56:40 +0100 [thread overview]
Message-ID: <4cd91b99-e88e-4f55-8fe7-8308cf6a35eb@lunn.ch> (raw)
In-Reply-To: <9de3e4c3-9f9e-41c0-9e2a-19e95e859c98@oss.nxp.com>
> > Is there a way to tell them apart? Another register somewhere?
>
> Unfortunately no, TJA1120 and TJA1121 share the same hardware the only
> difference being that TJA1121 has MACsec support while TJA1120 does not.
> It is the same for TJA1103 and TJA1104.
So the hardware can do MACsec, but it is disabled in firmware? Golden
screw driver could be used?
So you can tell them apart, otherwise you would offer MACsec on both.
It might be worth adding a .match_phy_device to the driver, so you can
have an entry per device. Just watch out for the semantics of
.match_phy_device, it gets called before the IDs are looked at.
Andrew
next prev parent reply other threads:[~2025-02-27 16:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 16:00 [PATCH 0/3] net: phy: nxp-c45-tja11xx: add support for TJA1121 and errata Andrei Botila
2025-02-27 16:00 ` [PATCH 1/3] net: phy: nxp-c45-tja11xx: add support for TJA1121 Andrei Botila
2025-02-27 16:14 ` Andrew Lunn
2025-02-27 16:30 ` Andrei Botila
2025-02-27 16:56 ` Andrew Lunn [this message]
2025-02-27 16:00 ` [PATCH 2/3] net: phy: nxp-c45-tja11xx: add TJA112X PHY configuration errata Andrei Botila
2025-02-27 16:00 ` [PATCH 3/3] net: phy: nxp-c45-tja11xx: add TJA112XB SGMII PCS restart errata Andrei Botila
2025-02-27 16:11 ` [PATCH 0/3] net: phy: nxp-c45-tja11xx: add support for TJA1121 and errata Andrew Lunn
2025-02-27 16:33 ` Andrei Botila
2025-02-27 16:58 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cd91b99-e88e-4f55-8fe7-8308cf6a35eb@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrei.botila@oss.nxp.com \
--cc=aruizrui@redhat.com \
--cc=clizzi@redhat.com \
--cc=davem@davemloft.net \
--cc=eballetb@redhat.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=s32@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.