From: Michal Simek <michal.simek@xilinx.com>
To: Rob Herring <robh@kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Michal Simek <michal.simek@xilinx.com>
Cc: <devicetree@vger.kernel.org>
Subject: Re: [bug report] of: base: Introduce of_alias_get_alias_list() to check alias IDs
Date: Mon, 21 Mar 2022 17:38:59 +0100 [thread overview]
Message-ID: <4cebcbac-1224-b3a4-a887-81afaf1d3cd6@xilinx.com> (raw)
In-Reply-To: <CAL_JsqLEeM3Wv_a5Ey54rgE5A6bZn85SG5WwiTWXfdH2mSVDYA@mail.gmail.com>
On 3/21/22 17:33, Rob Herring wrote:
> On Tue, Mar 15, 2022 at 10:09 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>>
>> Hello Michal Simek,
>>
>> The patch b1078c355d76: "of: base: Introduce
>> of_alias_get_alias_list() to check alias IDs" from Sep 20, 2018,
>> leads to the following Smatch static checker warning:
>>
>> drivers/of/base.c:2038 of_alias_get_alias_list()
>> warn: passing negative bit value 's32min-(-2),0-s32max' to 'set_bit()'
>
> The 1 user of of_alias_get_alias_list() has since been refactored and
> doesn't use of_alias_get_alias_list() anymore. So I'm just going to
> revert b1078c355d76.
yes. I am fine with it. We can get it back and fix it when it is again needed.
Thanks,
Michal
prev parent reply other threads:[~2022-03-21 16:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 15:09 [bug report] of: base: Introduce of_alias_get_alias_list() to check alias IDs Dan Carpenter
2022-03-21 16:33 ` Rob Herring
2022-03-21 16:38 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cebcbac-1224-b3a4-a887-81afaf1d3cd6@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=dan.carpenter@oracle.com \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.