Re: [RFC PATCH] drm/syncobj: add IOCTL to register an eventfd for a timeline

["Christian König" <christian.koenig@amd.com>]

Am 12.10.22 um 12:25 schrieb Simon Ser:
> On Tuesday, October 11th, 2022 at 14:10, Christian König <christian.koenig@amd.com> wrote:
>
>> Am 10.10.22 um 11:13 schrieb Simon Ser:
>>> On Sunday, October 9th, 2022 at 20:00, Christian König <christian.koenig@amd.com> wrote:
>>>
>>>> Am 09.10.22 um 16:40 schrieb Simon Ser:
>>>>
>>>>> Introduce a new DRM_IOCTL_SYNCOBJ_TIMELINE_REGISTER_EVENTFD IOCTL
>>>>> which signals an eventfd when a timeline point completes.
>>>> I was entertaining the same though for quite a while, but I would even
>>>> go a step further and actually always base the wait before signal
>>>> functionality of the drm_syncobj and the eventfd functionality. That
>>>> would save us quite a bit of complexity I think.
>>> Hm what do you mean exactly? I'm not sure I'm following.
>> Essentially we have the syncobj_wait_entry structure which is added to
>> the list whenever somebody starts to wait for a sequence which hasn't
>> materialized yet.
>>
>> Instead of extending this maybe just completely nuke the
>> syncobj_wait_entry handling and replace it with your implementation here.
> Hm, no sure I understand how that would work. We don't have an eventfd in the
> WAIT IOCTL...
>
> We could merge the two structs and figure out which callback to invoke based
> on which fields are filled, but I figured two separate structs would be make
> for a cleaner split.

In this case feel free to go ahead with this approach.

Just make sure that you always add the eventfd structure to the right 
list. For example the list_add in drm_syncobj_add_eventfd() doesn't seem 
to be correct of hand.

Regards,
Christian.