From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frank Rowand Subject: Re: [PATCH v2 0/7] kunit: create a centralized executor to dispatch all KUnit tests Date: Tue, 4 Feb 2020 17:35:18 -0600 Message-ID: <4d0f42f7-8dbe-3d47-e0df-3e31cc8ebf52@gmail.com> References: <20200130230812.142642-1-brendanhiggins@google.com> <20200204071915.AF32B21582@mail.kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-doc-owner@vger.kernel.org To: Brendan Higgins , Stephen Boyd Cc: Andrew Morton , Alan Maguire , Anton Ivanov , Arnd Bergmann , David Gow , Jeff Dike , Kees Cook , Richard Weinberger , rppt@linux.ibm.com, Shuah Khan , Iurii Zaikin , Greg KH , Logan Gunthorpe , Luis Chamberlain , Knut Omang , linux-um , linux-arch@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , Linux List-Id: linux-arch.vger.kernel.org On 2/4/20 1:35 PM, Brendan Higgins wrote: > On Mon, Feb 3, 2020 at 11:19 PM Stephen Boyd wrote: >> >> Quoting Brendan Higgins (2020-01-30 15:08:05) >>> ## TL;DR >>> >>> This patchset adds a centralized executor to dispatch tests rather than >>> relying on late_initcall to schedule each test suite separately along >>> with a couple of new features that depend on it. >> >> Is there any diff from v1 to v2? I don't know what changed, but I see >> that my Reviewed-by tag has been put on everything, so I guess >> everything I said was addressed or discussed in the previous round. > > Oh yes, sorry about that. I have gotten a bit lazy in regard to > changing logs. I noticed that a lot of people don't seem to care. I'll > make a note that you do. Please ignore those who don't care. Just always include a change log. You may encounter bike shedding about where the log belongs (in patch 0, in the modified patches, in both locations). The color of my bike shed is simply that they exist somewhere, but my most favorite color is both places. > > Changes since last revision: > - On patch 6/7, I flipped the include order and removed braces from the if > statements. > - On patch 7/7, I removed the periods from the short descriptions. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v2 0/7] kunit: create a centralized executor to dispatch all KUnit tests References: <20200130230812.142642-1-brendanhiggins@google.com> <20200204071915.AF32B21582@mail.kernel.org> From: Frank Rowand Message-ID: <4d0f42f7-8dbe-3d47-e0df-3e31cc8ebf52@gmail.com> Date: Tue, 4 Feb 2020 17:35:18 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit To: Brendan Higgins , Stephen Boyd Cc: Andrew Morton , Alan Maguire , Anton Ivanov , Arnd Bergmann , David Gow , Jeff Dike , Kees Cook , Richard Weinberger , rppt@linux.ibm.com, Shuah Khan , Iurii Zaikin , Greg KH , Logan Gunthorpe , Luis Chamberlain , Knut Omang , linux-um , linux-arch@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , Linux Kernel Mailing List , "open list:DOCUMENTATION" List-ID: Message-ID: <20200204233518.0shVsCqOzrFJfoFcWkw8hRkMPyzRIzL2wdE91HNKCOM@z> On 2/4/20 1:35 PM, Brendan Higgins wrote: > On Mon, Feb 3, 2020 at 11:19 PM Stephen Boyd wrote: >> >> Quoting Brendan Higgins (2020-01-30 15:08:05) >>> ## TL;DR >>> >>> This patchset adds a centralized executor to dispatch tests rather than >>> relying on late_initcall to schedule each test suite separately along >>> with a couple of new features that depend on it. >> >> Is there any diff from v1 to v2? I don't know what changed, but I see >> that my Reviewed-by tag has been put on everything, so I guess >> everything I said was addressed or discussed in the previous round. > > Oh yes, sorry about that. I have gotten a bit lazy in regard to > changing logs. I noticed that a lot of people don't seem to care. I'll > make a note that you do. Please ignore those who don't care. Just always include a change log. You may encounter bike shedding about where the log belongs (in patch 0, in the modified patches, in both locations). The color of my bike shed is simply that they exist somewhere, but my most favorite color is both places. > > Changes since last revision: > - On patch 6/7, I flipped the include order and removed braces from the if > statements. > - On patch 7/7, I removed the periods from the short descriptions. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-xc44.google.com ([2607:f8b0:4864:20::c44]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iz7iz-0001Ah-BL for linux-um@lists.infradead.org; Tue, 04 Feb 2020 23:35:22 +0000 Received: by mail-yw1-xc44.google.com with SMTP id 192so730307ywy.0 for ; Tue, 04 Feb 2020 15:35:20 -0800 (PST) Subject: Re: [PATCH v2 0/7] kunit: create a centralized executor to dispatch all KUnit tests References: <20200130230812.142642-1-brendanhiggins@google.com> <20200204071915.AF32B21582@mail.kernel.org> From: Frank Rowand Message-ID: <4d0f42f7-8dbe-3d47-e0df-3e31cc8ebf52@gmail.com> Date: Tue, 4 Feb 2020 17:35:18 -0600 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Brendan Higgins , Stephen Boyd Cc: linux-arch@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" , Kees Cook , Arnd Bergmann , Greg KH , Richard Weinberger , Jeff Dike , "open list:DOCUMENTATION" , Knut Omang , Luis Chamberlain , rppt@linux.ibm.com, linux-um , Logan Gunthorpe , KUnit Development , David Gow , Shuah Khan , Andrew Morton , Iurii Zaikin , Alan Maguire , Linux Kernel Mailing List , Anton Ivanov On 2/4/20 1:35 PM, Brendan Higgins wrote: > On Mon, Feb 3, 2020 at 11:19 PM Stephen Boyd wrote: >> >> Quoting Brendan Higgins (2020-01-30 15:08:05) >>> ## TL;DR >>> >>> This patchset adds a centralized executor to dispatch tests rather than >>> relying on late_initcall to schedule each test suite separately along >>> with a couple of new features that depend on it. >> >> Is there any diff from v1 to v2? I don't know what changed, but I see >> that my Reviewed-by tag has been put on everything, so I guess >> everything I said was addressed or discussed in the previous round. > > Oh yes, sorry about that. I have gotten a bit lazy in regard to > changing logs. I noticed that a lot of people don't seem to care. I'll > make a note that you do. Please ignore those who don't care. Just always include a change log. You may encounter bike shedding about where the log belongs (in patch 0, in the modified patches, in both locations). The color of my bike shed is simply that they exist somewhere, but my most favorite color is both places. > > Changes since last revision: > - On patch 6/7, I flipped the include order and removed braces from the if > statements. > - On patch 7/7, I removed the periods from the short descriptions. > _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um