From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37E17CCD1A5 for ; Mon, 20 Oct 2025 19:47:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=noEHNmyIiYu/ti7gMx6yK3es3HFkaf+4VD2aA1mHnck=; b=vp8/YHVbfB5YJD PPrKUz6NkmhkiMU6n8hblomx09y2zhrxW/Hq86aXnoL+5AqApL1HpNu4WsrosW9WJMgCw2+Z4aag2 kbxVS4QOd1glv3bZSYrEolwXYgVV06nDIV1y8d2AObzBDqRyNkVY9/8KWpSxQ1N9grh+6IK6L93fJ MD2kmYS6QJ8KZM4MrCuvU00mr0wFPTDta+ueujMIXq0f5fvyvIVbXRi7EW++WuDTZ/csrT/qU0lhN sHfHdAn5MatobJHe0SV16/0yveqyzT40q8lK1TBLNnAsmMiQ8XAEePJinfhogLUBynwQKsR6Wlebl HOZ9ukwme95O3EaaeIJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vAvqf-0000000EpUm-3Ziv; Mon, 20 Oct 2025 19:47:17 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vAvqd-0000000EpUO-22c2 for kvm-riscv@lists.infradead.org; Mon, 20 Oct 2025 19:47:17 +0000 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-290d14e5c9aso42504295ad.3 for ; Mon, 20 Oct 2025 12:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1760989635; x=1761594435; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=T29G72fExJyk8VtqV3YJi7ZBrueGLIkeAq2lMcMuWYA=; b=dljiuWTnfVSe2W9hWExSlw/liAVaw6Pt//0lIQHvWA3iW55/tpclKS+sOko+bsE+eX Kw9OmZCtnXdcK6ls3x0gHhVeWjraCFyE1Jp6vJ9FN8Lxb1W9+TT8JZJ3TH2gAe8Lkzq5 94GBCLpfVCSX1tiUv0Ms8jEr9YXtduQWh31S6hcNDBgMXqYXTJHM4mcgDo15FXi1CR/o 6+aCk41/tI0mVtwCQCUqo7DwWj5HTDkxfJxY0HkFIkNgFlzJ+SgH0VGc2YH63dkSlw60 3kCGK9D81N/tAZ4uAP1dJT0guczbRa7XHViaW3u1RXj9k6WIRIgQ/EQnE5pb/CpjM5r0 cagw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760989635; x=1761594435; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T29G72fExJyk8VtqV3YJi7ZBrueGLIkeAq2lMcMuWYA=; b=K1Bi6YEIkkUpj7WtOT4xjAVCN0e0R3XO4zly2+KYqlrv11J7h6sQiJIyE7w4cYnsca TUZQi6f/T9x8mZSN6xr9vlHURBFR+8KTCx9MU7TgPTkQYwCI2qP7Uvg6xruTDC3cnzWN U1Jsv0fZJJfC1LCyFe/L+aQhfMWOXSo7nu9FZRyXx9At0ZgL5ofeKq6FhbVNOwAySP2D v+96frfjQck4ZAXU5NFqQr8FF0SIVPncavCzzpdjB95Sj+gSLZE5fDDpjdvEkfvJh7Ip SgBGpYx207JPddWQhPrq3t7njhI2clFGA458A/UjzodJHWkBgkY8aEKogkjqJOtsNn9n a/Kg== X-Forwarded-Encrypted: i=1; AJvYcCVRf7RFPxOFltb6FlCIw2zIC2qq2amspMTuIHw5lCVwtl8/w7YV3SEZqPd9B4gSqIKzoI9jiWfp5VE=@lists.infradead.org X-Gm-Message-State: AOJu0YwHIDT+XPZSqVPuKnLq5IBF4tVV8FLVjZrM0AKZJPN3ygnEszqg KHH/1IdQSlLpRie7SJ2f0Eoh48xFegvfmNy//gFsXYME5MAuaLPj8/YLt7QW8CQVizk= X-Gm-Gg: ASbGnctwjzvQXMAJdEnmPZv9gB7Is6GZtpJf3knYfBTffLNoodxHkUbn3JCpvHAS5lL 6HY43W/qViUXGMv0mAYdfrs7yzjWurQOms/r8xyZm6xDZdFAkROQAseUBvsMOkKJoIiNiUrX/KL tk2Lq/EvEQrvLhBxl4ytSn7dE9KiWIzS3GA/dl7P0YLE7CMYsqRvUO3cdYnKmlzkICxLkb6Nzhs Utr1xOp3ZqMNfM+96G0tC7oTPy+SLEMEcWzUQTmahTn1xi82x74se2Omnf32Yx9+SzRDqt15ist QObRv+m8x1KqchU8uH7obO3Ow8auV2Yt7zYi+0gUfb2uO/A0o/JtD9NTkILtNTfTXlGp0uCoGQQ IteZbaFXj3hepr5zwRlFUlEACl5Q1hhVoIo08hpMluV3qBOzOTUQrQG4EJw9gNKmjGtkQvCEu/A Ry52rM0fBdFzIAB+ah/0x8BhKsrkfJYkQRp0Z3AKNyyEUJGQy7OTRT7aKF0R+0eE4U X-Google-Smtp-Source: AGHT+IHbuqXK1u6LquvMt8XAnfwihmyV2uHtYn9qEdWcAtI1wb6x8mv/e+BQVy3+n2euvz+X557SNA== X-Received: by 2002:a17:902:e88e:b0:290:a3b9:d4be with SMTP id d9443c01a7336-290c9ce63cbmr161125965ad.24.1760989634647; Mon, 20 Oct 2025 12:47:14 -0700 (PDT) Received: from ?IPV6:2804:7f0:bcc1:8cb8:dfc4:4af0:d7c6:a030? ([2804:7f0:bcc1:8cb8:dfc4:4af0:d7c6:a030]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29246fd5d76sm88303565ad.39.2025.10.20.12.47.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 12:47:14 -0700 (PDT) Message-ID: <4d1e8b55-e404-466b-a2d6-b189de910637@ventanamicro.com> Date: Mon, 20 Oct 2025 16:47:07 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 18/18] DO NOT UPSTREAM: RISC-V: KVM: Workaround kvm_riscv_gstage_ioremap() bug To: fangyu.yu@linux.alibaba.com, ajones@ventanamicro.com Cc: alex.williamson@redhat.com, alex@ghiti.fr, anup@brainfault.org, atish.patra@linux.dev, iommu@lists.linux.dev, jgg@nvidia.com, joro@8bytes.org, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, palmer@dabbelt.com, paul.walmsley@sifive.com, robin.murphy@arm.com, tglx@linutronix.de, tjeznach@rivosinc.com, will@kernel.org, zong.li@sifive.com References: <20250920203851.2205115-38-ajones@ventanamicro.com> <20251020131218.68932-1-fangyu.yu@linux.alibaba.com> From: Daniel Henrique Barboza Content-Language: en-US In-Reply-To: <20251020131218.68932-1-fangyu.yu@linux.alibaba.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251020_124715_644467_8B8F5706 X-CRM114-Status: GOOD ( 15.21 ) X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org Drew, On 10/20/25 10:12 AM, fangyu.yu@linux.alibaba.com wrote: >> Workaround a bug that breaks guest booting with device assignment that >> was introduced with commit 9bca8be646e0 ("RISC-V: KVM: Fix pte settings >> within kvm_riscv_gstage_ioremap()") > > The root cause of the guest booting failure is that an HPA is obtained > in the kvm_arch_prepare_memory_region. > > Here [1] might be the correct fixes for this issue. > [1] https://lore.kernel.org/linux-riscv/20251020130801.68356-1-fangyu.yu@linux.alibaba.com/T/#u This patch fixes the issue we've been seeing with device assignment inside a kvm guest. I suggest folding it into this series and dropping this workaround patch in the next version. Thanks, Daniel > >> --- >> arch/riscv/kvm/mmu.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/riscv/kvm/mmu.c b/arch/riscv/kvm/mmu.c >> index 525fb5a330c0..994f18b92143 100644 >> --- a/arch/riscv/kvm/mmu.c >> +++ b/arch/riscv/kvm/mmu.c >> @@ -56,7 +56,7 @@ int kvm_riscv_mmu_ioremap(struct kvm *kvm, gpa_t gpa, phys_addr_t hpa, >> >> end = (gpa + size + PAGE_SIZE - 1) & PAGE_MASK; >> pfn = __phys_to_pfn(hpa); >> - prot = pgprot_noncached(PAGE_WRITE); >> + prot = pgprot_noncached(__pgprot(_PAGE_PRESENT | _PAGE_ACCESSED | _PAGE_READ | _PAGE_WRITE)); >> >> for (addr = gpa; addr < end; addr += PAGE_SIZE) { >> map.addr = addr; >> -- >> 2.49.0 > > Thanks, > Fangyu > -- kvm-riscv mailing list kvm-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kvm-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75AE76BFCE for ; Mon, 20 Oct 2025 19:47:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760989636; cv=none; b=AuNPuCFDL7vQpUEvwYUPyIKKwPpFgZkSDAFmPxsteXmCeLmaoh9MtFENRtBUlfeDq/zaH+2kmXhRNzAeStz2YdPiXyumbJmww2z3mdGUyf+ThcUrR89gjHSxJbwad9BSnpVDAlMNPBYie/fmq9Ini5lIlBq6S+O7pXWVeO/LIcw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760989636; c=relaxed/simple; bh=Zd72u21sHnlUwvSbRt1SRLx/FrPMlp6pbPmb7VSQ83c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cO4s0vLRGVZgJMNYiP/y8FZTYLF5G3dLVEfZ7M9NOmeXoqw9Iz/Zjxbfrqz39vyWomMguhXURZNYbxgicdfIZ1REl+2m6vldB/E9bTf1kUO2pLosRi3V3G1nWOoUx60Sojuun3QADbYMJqNX2iLd7fdQ3/YNBUAEuDhgwMKEx5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=gxjJWtBk; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="gxjJWtBk" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-33d463e79ddso3816088a91.0 for ; Mon, 20 Oct 2025 12:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1760989635; x=1761594435; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=T29G72fExJyk8VtqV3YJi7ZBrueGLIkeAq2lMcMuWYA=; b=gxjJWtBkv9h62mXNGbPkAETR5GCr3tKT7oGl1/DPsBs5nIeDklzevp4EsweRibDrKu LTb2NWDqmVKxonrJFWiJrxVp8zFBS/v+ein4l4/8z1iHzQ/8pmcT9EqgGlzHnFsZ2yK2 gUzzyEQh2DgdF6RP+Kmn6lXP8AliuAt3tUbjO+G6KH44pn+r2vh7fpXwlTRIR8exHh01 2Zu0XcslntC1f7hLcAjLoiee36cwY2OR5n4IGpnp0FXWEOOYAOaNUzzVpBNW414eb8MC sbrF85Kn7n1oMJzbxito5cV0BdlwgfM+NsfjbFrM9z4m4dC8LcjxX3b/g56QWRRT6hxS HQrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760989635; x=1761594435; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T29G72fExJyk8VtqV3YJi7ZBrueGLIkeAq2lMcMuWYA=; b=h1/y5IQ4a4cu3JbsFkK9DOlxX/nHG0/a7DkrtgKgBNj6IWw8puflxYbU+XzOPmJmPZ cKdi5EGl2F2OvZBi/BF8cN8ZKCOZc7+di4ApZszwxYExpBq9ADFG7gveNBO0BWSFH1dg 0pxVFP9ZSb3lF8L6Umw5WXo0yeh8uuLtQlF5OpQC+Qw8MsewA4Z6JcXdtEfEyQj1kn+s xsgysvTsO768OFkoDrFEVxzRGWnPV6DPYQ/RySAt6pZ33jDem0Qij0KDbiq6HGKMbSDF eYQ6/ntdh4gs41k+QVAWgI+UEcpNVfRPz8Jxklnrqlv0vIHF8bFjjrSMM9hv+gc6irzX wyBg== X-Forwarded-Encrypted: i=1; AJvYcCX6kkyk7utuFKFmNKB5xoAQ+9bLGAHmuF8Mhp/J/e2A0WnSe6V6hJL3yrx0pvFDNB2Aq48=@vger.kernel.org X-Gm-Message-State: AOJu0YwBfxbMcQx7FhpUFWTP5wCw42U9Ss+nYkoZdVGhNO1VX+0ctlcp 5Pwzo9kuFUW7BXW0/98KdtXswNx3keQyZF6zptBLUVKShRnWQ2xIT13pcsZyCigWaeQ= X-Gm-Gg: ASbGncv/GzspBKk7+p39lBKA7/1oIsqrj3J1zFpa96uNWVt0HkeSEebJVgYLmrqS+Zb 9x6CsaYS4Xpd6JPbNIInHL7SPyyXHrxTe4F67xfCgq5tR3P3+BFPn5LWiR1yNVxU/PEmXucUlm1 L/oDKc9PjvGO59/ImGl62PAOCKY8v9U+odTxQwq2/z2ZQtZx1FuO1aR06r9V1TL+5X+y4at0fcH Hg028nOjC/4wRUVoFt8jORRrZeEeGzHOHrnhvlLTawagqfYdqoRtYyjZpysqm4febAxCS0nK/mP MpHldwDn2pDmnIwbI34k63TzWkXmEs7hCre51KLX2X/Nck3MxO5Rp2KP+nDMKhfPfmmTd3ibxAZ DyKdmVXkDY/zHPJ9ARvp7TlYGwR+enwE23ZPGJ3rMADjrF6dab+KSJKI3IU3lL34F5xd3rH04v8 dZUDPy3hiIROR3+HOpVUcNqHWYLXVh420EdxISo6I4uhVjyijkag5G9DZz4nECiyGi X-Google-Smtp-Source: AGHT+IHbuqXK1u6LquvMt8XAnfwihmyV2uHtYn9qEdWcAtI1wb6x8mv/e+BQVy3+n2euvz+X557SNA== X-Received: by 2002:a17:902:e88e:b0:290:a3b9:d4be with SMTP id d9443c01a7336-290c9ce63cbmr161125965ad.24.1760989634647; Mon, 20 Oct 2025 12:47:14 -0700 (PDT) Received: from ?IPV6:2804:7f0:bcc1:8cb8:dfc4:4af0:d7c6:a030? ([2804:7f0:bcc1:8cb8:dfc4:4af0:d7c6:a030]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29246fd5d76sm88303565ad.39.2025.10.20.12.47.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 12:47:14 -0700 (PDT) Message-ID: <4d1e8b55-e404-466b-a2d6-b189de910637@ventanamicro.com> Date: Mon, 20 Oct 2025 16:47:07 -0300 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 18/18] DO NOT UPSTREAM: RISC-V: KVM: Workaround kvm_riscv_gstage_ioremap() bug To: fangyu.yu@linux.alibaba.com, ajones@ventanamicro.com Cc: alex.williamson@redhat.com, alex@ghiti.fr, anup@brainfault.org, atish.patra@linux.dev, iommu@lists.linux.dev, jgg@nvidia.com, joro@8bytes.org, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, palmer@dabbelt.com, paul.walmsley@sifive.com, robin.murphy@arm.com, tglx@linutronix.de, tjeznach@rivosinc.com, will@kernel.org, zong.li@sifive.com References: <20250920203851.2205115-38-ajones@ventanamicro.com> <20251020131218.68932-1-fangyu.yu@linux.alibaba.com> From: Daniel Henrique Barboza Content-Language: en-US In-Reply-To: <20251020131218.68932-1-fangyu.yu@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Drew, On 10/20/25 10:12 AM, fangyu.yu@linux.alibaba.com wrote: >> Workaround a bug that breaks guest booting with device assignment that >> was introduced with commit 9bca8be646e0 ("RISC-V: KVM: Fix pte settings >> within kvm_riscv_gstage_ioremap()") > > The root cause of the guest booting failure is that an HPA is obtained > in the kvm_arch_prepare_memory_region. > > Here [1] might be the correct fixes for this issue. > [1] https://lore.kernel.org/linux-riscv/20251020130801.68356-1-fangyu.yu@linux.alibaba.com/T/#u This patch fixes the issue we've been seeing with device assignment inside a kvm guest. I suggest folding it into this series and dropping this workaround patch in the next version. Thanks, Daniel > >> --- >> arch/riscv/kvm/mmu.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/riscv/kvm/mmu.c b/arch/riscv/kvm/mmu.c >> index 525fb5a330c0..994f18b92143 100644 >> --- a/arch/riscv/kvm/mmu.c >> +++ b/arch/riscv/kvm/mmu.c >> @@ -56,7 +56,7 @@ int kvm_riscv_mmu_ioremap(struct kvm *kvm, gpa_t gpa, phys_addr_t hpa, >> >> end = (gpa + size + PAGE_SIZE - 1) & PAGE_MASK; >> pfn = __phys_to_pfn(hpa); >> - prot = pgprot_noncached(PAGE_WRITE); >> + prot = pgprot_noncached(__pgprot(_PAGE_PRESENT | _PAGE_ACCESSED | _PAGE_READ | _PAGE_WRITE)); >> >> for (addr = gpa; addr < end; addr += PAGE_SIZE) { >> map.addr = addr; >> -- >> 2.49.0 > > Thanks, > Fangyu > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56939CCD193 for ; Mon, 20 Oct 2025 19:47:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/jvftiIF7s1MDcvVJg7C9RE9lRLm+xqm3QQbwR/hUwo=; b=rrUO19YO+iq05D 4FnIyiG6MD58SAT8+KDkx8jMHWju2Chg8SbgLn0wBoUCU2G6aikM3TXow9MAk1j+F3QOxYkr6w0j5 BMOSdwuxMU/ulj2TrndYXjAIj5cvgvqSEuVvcAbz66km72KT1+iYNqRPYyEG6KOrTh1Lm8r0ZbfUu i/Wa9859kgMLeXMjiFV/GZR0QVtJq7csYMyNc+yGzZ5oqcwa6mqkNtuxfk1PKRjWeSs/8aMejdepo VRy2Bmp1w2jStvtvgeamiXZZbz4iKhRI3L7HGADtuB8gPwKRvzDmBzsExehb306MWkHUarkV2JW+q ZbQRs8ojf/NoH+nbMVvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vAvqj-0000000EpVb-0QPG; Mon, 20 Oct 2025 19:47:21 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vAvqh-0000000EpUz-2fTL for linux-riscv@bombadil.infradead.org; Mon, 20 Oct 2025 19:47:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=T29G72fExJyk8VtqV3YJi7ZBrueGLIkeAq2lMcMuWYA=; b=QOEiE1BdBLIvE5QTW5BCTExRvL 1SNWFOzgmxOP7xa1jf7NRlF0akSEavxXqnTEqOZe5qZg9x3Jo452Og7E/IAr9/9NzXtAKoHEI27zH 1YtXq0hFJL93Z2sg6WFW8SmPDblptcNgZWvZbczZCvUsp4SH7coHFqiCVxVTpGHEhlItKyY83GY+m RZ2l9vHuHWPfm/hSljw98a4OQDhdA2i8cT/vXgV2uSDQaV3db8WqY1P5E4OmTfvQ47Gw/CgtwlNwR K3Vl1X1ksUnNHGFak/VOy4QrZuzEg4PpDc4EbbFE/aS4zBeskiaMhgJVj0JE4Xv125wmYX8SpnQxl H5JosZMQ==; Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vAuyy-00000000B6h-13yJ for linux-riscv@lists.infradead.org; Mon, 20 Oct 2025 18:51:50 +0000 Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-33ba38ed94eso5210967a91.1 for ; Mon, 20 Oct 2025 12:47:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1760989635; x=1761594435; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=T29G72fExJyk8VtqV3YJi7ZBrueGLIkeAq2lMcMuWYA=; b=dljiuWTnfVSe2W9hWExSlw/liAVaw6Pt//0lIQHvWA3iW55/tpclKS+sOko+bsE+eX Kw9OmZCtnXdcK6ls3x0gHhVeWjraCFyE1Jp6vJ9FN8Lxb1W9+TT8JZJ3TH2gAe8Lkzq5 94GBCLpfVCSX1tiUv0Ms8jEr9YXtduQWh31S6hcNDBgMXqYXTJHM4mcgDo15FXi1CR/o 6+aCk41/tI0mVtwCQCUqo7DwWj5HTDkxfJxY0HkFIkNgFlzJ+SgH0VGc2YH63dkSlw60 3kCGK9D81N/tAZ4uAP1dJT0guczbRa7XHViaW3u1RXj9k6WIRIgQ/EQnE5pb/CpjM5r0 cagw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760989635; x=1761594435; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T29G72fExJyk8VtqV3YJi7ZBrueGLIkeAq2lMcMuWYA=; b=Rm/K2qCiPiG/kq7Tt9T7YS2JMQpZaq5h/agskioyLfFrqcrfGpA3TeP7Ng/4t0zahI XLVfSv4E31x9+Cv7gjvgKTDXihkO6YZLG709npwUaoKy1WhnqVtJi/4OVptjTZvdoq2X 1mUCt8xDuFcUE4pfvNkilMF8cm/JhvoM1hTSTs5o8Oj/RovgDGy8iZELqd5JCGx1mM9S 31wYdzBWexzj4oxCfFeF/oB6RSJEj6C/NiNDv9NPyP3fqj4hOpoZlkS3AZRUoge09r9J 43s+9WBT+deZZWFJ7nYnz9RHLalUU2tgTgp03Jq8mwLfY90nC43LDU1dVYBE74GBVyNU AXzQ== X-Forwarded-Encrypted: i=1; AJvYcCV8ioscbboERHS9kVIR1mlOtdi4pAgqxUtYtHVwApuK3F5cxBq6YDQ7EF8jdM+Cyil6jKC+8vImDo6SmA==@lists.infradead.org X-Gm-Message-State: AOJu0YyxA2voPTG4LXMiDbqFop+NtOGnvo+L0XnFS5TkE2dL8oyOPK/G XNLToWJhfKZzsyGE6AbNGLvokq9Qam5PbkpDOz5OnFZW1QB0bp0G3mSLBoym4aXn6UQ= X-Gm-Gg: ASbGnctoTLy1YLp0t2C95tITNfa3Fx0lRmZpWpg4Q9bejqiXXVPYz8QCw90Zn2xUVjF lqIrO3IA9n8/lRA6fbO/tgLCjIHjbd8T/MtXQ26vFMgvPP74aivvMcw1kHvJr3zlKDgeBQdGKmM fd2EkC6Nkxz+G64TC/mBlEm2TWIuFb9K/Pltf6PXvgY9k31oZcnom2fsIH8TsVsxCuz4lG7S30x 5MIiUXhBeKUgehO98KTgR/7tXwD8sTfkhl9P1NbzH2+L+TazcnhBH3IjCE4LSsCccMllKuvAqZn JKBnMBCTprvDpoOGIOe6syX1lYBZ1oSJshybDTLPKMgY4GKX7tLMcqJIJqkalVs7VUKNXeVBOqY GeSn+4kGBCJwqFPY1UhtqP+aBbBg9oMhApj/kePABi+o2m2o9dh5yJF923JHQjEUifLG+64IxyN 9Zix/BIXdone+hEPHv/+XATt+M2NCu59l5RCLMoea4F3t1hkQLmnpJwNynTB2FmCeO X-Google-Smtp-Source: AGHT+IHbuqXK1u6LquvMt8XAnfwihmyV2uHtYn9qEdWcAtI1wb6x8mv/e+BQVy3+n2euvz+X557SNA== X-Received: by 2002:a17:902:e88e:b0:290:a3b9:d4be with SMTP id d9443c01a7336-290c9ce63cbmr161125965ad.24.1760989634647; Mon, 20 Oct 2025 12:47:14 -0700 (PDT) Received: from ?IPV6:2804:7f0:bcc1:8cb8:dfc4:4af0:d7c6:a030? ([2804:7f0:bcc1:8cb8:dfc4:4af0:d7c6:a030]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29246fd5d76sm88303565ad.39.2025.10.20.12.47.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 12:47:14 -0700 (PDT) Message-ID: <4d1e8b55-e404-466b-a2d6-b189de910637@ventanamicro.com> Date: Mon, 20 Oct 2025 16:47:07 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 18/18] DO NOT UPSTREAM: RISC-V: KVM: Workaround kvm_riscv_gstage_ioremap() bug To: fangyu.yu@linux.alibaba.com, ajones@ventanamicro.com Cc: alex.williamson@redhat.com, alex@ghiti.fr, anup@brainfault.org, atish.patra@linux.dev, iommu@lists.linux.dev, jgg@nvidia.com, joro@8bytes.org, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, palmer@dabbelt.com, paul.walmsley@sifive.com, robin.murphy@arm.com, tglx@linutronix.de, tjeznach@rivosinc.com, will@kernel.org, zong.li@sifive.com References: <20250920203851.2205115-38-ajones@ventanamicro.com> <20251020131218.68932-1-fangyu.yu@linux.alibaba.com> From: Daniel Henrique Barboza Content-Language: en-US In-Reply-To: <20251020131218.68932-1-fangyu.yu@linux.alibaba.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251020_195148_494953_5E79D063 X-CRM114-Status: GOOD ( 15.16 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Drew, On 10/20/25 10:12 AM, fangyu.yu@linux.alibaba.com wrote: >> Workaround a bug that breaks guest booting with device assignment that >> was introduced with commit 9bca8be646e0 ("RISC-V: KVM: Fix pte settings >> within kvm_riscv_gstage_ioremap()") > > The root cause of the guest booting failure is that an HPA is obtained > in the kvm_arch_prepare_memory_region. > > Here [1] might be the correct fixes for this issue. > [1] https://lore.kernel.org/linux-riscv/20251020130801.68356-1-fangyu.yu@linux.alibaba.com/T/#u This patch fixes the issue we've been seeing with device assignment inside a kvm guest. I suggest folding it into this series and dropping this workaround patch in the next version. Thanks, Daniel > >> --- >> arch/riscv/kvm/mmu.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/riscv/kvm/mmu.c b/arch/riscv/kvm/mmu.c >> index 525fb5a330c0..994f18b92143 100644 >> --- a/arch/riscv/kvm/mmu.c >> +++ b/arch/riscv/kvm/mmu.c >> @@ -56,7 +56,7 @@ int kvm_riscv_mmu_ioremap(struct kvm *kvm, gpa_t gpa, phys_addr_t hpa, >> >> end = (gpa + size + PAGE_SIZE - 1) & PAGE_MASK; >> pfn = __phys_to_pfn(hpa); >> - prot = pgprot_noncached(PAGE_WRITE); >> + prot = pgprot_noncached(__pgprot(_PAGE_PRESENT | _PAGE_ACCESSED | _PAGE_READ | _PAGE_WRITE)); >> >> for (addr = gpa; addr < end; addr += PAGE_SIZE) { >> map.addr = addr; >> -- >> 2.49.0 > > Thanks, > Fangyu > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv