From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3526CD128A for ; Sun, 7 Apr 2024 07:50:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g+gS0Jb6c/36x+pg7JdikHblkLiND7blV4TjWa69DNw=; b=kaxGTkeRVXoQwv 4kC7hvY+cB7L3Ih0+Rm5hF5fC9i8EOBbk82xZDsLpSWmca8VW3hZ0MLEDS4m64DIZQsNuDGVWaotn HDnvvoNlqqwOWP9GShRlaoTIvPArZlNQdIqUOCQTtjYuHXhdy0SSsNg7nKtgfbpihHmG4yGMuTJjH fax/7OT8nuz7KkWmVWbOCjvMoepKdpKRj35NCnGku35Q7NGpM1KbHjtn9k40vyTfMQs9J5i1JngTK o7Yz8/1Q7Jfatibyj4tYACHf/NKjw4xbjGVKHWsx7RRprS7gf+7WXkAhLsiD9RsTt25k+3m4mZoEr J0Ypo/9Oj2PNExMiOnpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtNI7-0000000C2V8-42zq; Sun, 07 Apr 2024 07:50:15 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtNI3-0000000C2Sg-1Or2; Sun, 07 Apr 2024 07:50:13 +0000 Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4VC47C1yhVzwRPw; Sun, 7 Apr 2024 15:47:03 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 5A70414010C; Sun, 7 Apr 2024 15:49:55 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 7 Apr 2024 15:49:54 +0800 Message-ID: <4d45fffc-877a-4ad1-ad02-a33341e467e7@huawei.com> Date: Sun, 7 Apr 2024 15:49:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/7] arch/mm/fault: accelerate pagefault when badaccess Content-Language: en-US To: Andrew Morton CC: Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Dave Hansen , Andy Lutomirski , Peter Zijlstra , , , , , , , References: <20240403083805.1818160-1-wangkefeng.wang@huawei.com> <20240403134539.fde3a6c594f2d88409be30ed@linux-foundation.org> From: Kefeng Wang In-Reply-To: <20240403134539.fde3a6c594f2d88409be30ed@linux-foundation.org> X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm100001.china.huawei.com (7.185.36.93) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240407_005011_896750_14BA352C X-CRM114-Status: UNSURE ( 8.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 2024/4/4 4:45, Andrew Morton wrote: > On Wed, 3 Apr 2024 16:37:58 +0800 Kefeng Wang wrote: > >> After VMA lock-based page fault handling enabled, if bad access met >> under per-vma lock, it will fallback to mmap_lock-based handling, >> so it leads to unnessary mmap lock and vma find again. A test from >> lmbench shows 34% improve after this changes on arm64, >> >> lat_sig -P 1 prot lat_sig 0.29194 -> 0.19198 >> >> Only build test on other archs except arm64. > > Thanks. So we now want a bunch of architectures to runtime test this. Do > we have a selftest in place which will adequately do this? I don't find such selftest, and badaccess would lead to coredump, the performance should not affect most scene, so no selftest is acceptable. lmbench is easy to use to measure the performance. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A4CB7484 for ; Sun, 7 Apr 2024 07:49:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.187 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712476202; cv=none; b=tY7zIu0nEEq+5XbyVG0iaSMllmeHmG7WJxUhEmK5l3ZJ7gswHt9b3AdQkgyjAYCSFP1JCpMjLpzx/kg216i1YeRFxomTwrwS5IeLyIHoeDaMWt/l4KW/VEiXnJrvrgWrRauaBMcESydCuP+mcAiggebIhskr/Y8fnE7OO2qFqCU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712476202; c=relaxed/simple; bh=G2yXjWdg3pJnxsnntQWfuPvLSRSxp8WlVyEALB8Zy6M=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=lvO4gz1GHyKY+eoeh+YDEj0sPOAHXndVhUEYFhIAc+0SW5O/16VQVE54xWCofjD0SKeDY+8kzF9ou34HOXXI4feDaCj86E/KZ7n19nyKX03fMP1F8z5OLXwLnTsNBaeZnZSjIpFGwEAVEtvhxdNLepkYqJk9upbw35mOt2rSFp8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4VC47C1yhVzwRPw; Sun, 7 Apr 2024 15:47:03 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 5A70414010C; Sun, 7 Apr 2024 15:49:55 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 7 Apr 2024 15:49:54 +0800 Message-ID: <4d45fffc-877a-4ad1-ad02-a33341e467e7@huawei.com> Date: Sun, 7 Apr 2024 15:49:53 +0800 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/7] arch/mm/fault: accelerate pagefault when badaccess Content-Language: en-US To: Andrew Morton CC: Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Dave Hansen , Andy Lutomirski , Peter Zijlstra , , , , , , , References: <20240403083805.1818160-1-wangkefeng.wang@huawei.com> <20240403134539.fde3a6c594f2d88409be30ed@linux-foundation.org> From: Kefeng Wang In-Reply-To: <20240403134539.fde3a6c594f2d88409be30ed@linux-foundation.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm100001.china.huawei.com (7.185.36.93) On 2024/4/4 4:45, Andrew Morton wrote: > On Wed, 3 Apr 2024 16:37:58 +0800 Kefeng Wang wrote: > >> After VMA lock-based page fault handling enabled, if bad access met >> under per-vma lock, it will fallback to mmap_lock-based handling, >> so it leads to unnessary mmap lock and vma find again. A test from >> lmbench shows 34% improve after this changes on arm64, >> >> lat_sig -P 1 prot lat_sig 0.29194 -> 0.19198 >> >> Only build test on other archs except arm64. > > Thanks. So we now want a bunch of architectures to runtime test this. Do > we have a selftest in place which will adequately do this? I don't find such selftest, and badaccess would lead to coredump, the performance should not affect most scene, so no selftest is acceptable. lmbench is easy to use to measure the performance. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D56B9CD128A for ; Sun, 7 Apr 2024 07:50:59 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VC4Ck2x0Vz3vc0 for ; Sun, 7 Apr 2024 17:50:58 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=huawei.com (client-ip=45.249.212.187; helo=szxga01-in.huawei.com; envelope-from=wangkefeng.wang@huawei.com; receiver=lists.ozlabs.org) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VC4CG6Fwdz3btX for ; Sun, 7 Apr 2024 17:50:32 +1000 (AEST) Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4VC47C1yhVzwRPw; Sun, 7 Apr 2024 15:47:03 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 5A70414010C; Sun, 7 Apr 2024 15:49:55 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 7 Apr 2024 15:49:54 +0800 Message-ID: <4d45fffc-877a-4ad1-ad02-a33341e467e7@huawei.com> Date: Sun, 7 Apr 2024 15:49:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/7] arch/mm/fault: accelerate pagefault when badaccess Content-Language: en-US To: Andrew Morton References: <20240403083805.1818160-1-wangkefeng.wang@huawei.com> <20240403134539.fde3a6c594f2d88409be30ed@linux-foundation.org> From: Kefeng Wang In-Reply-To: <20240403134539.fde3a6c594f2d88409be30ed@linux-foundation.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm100001.china.huawei.com (7.185.36.93) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, linux-s390@vger.kernel.org, Albert Ou , linuxppc-dev@lists.ozlabs.org, Peter Zijlstra , Catalin Marinas , Paul Walmsley , Russell King , surenb@google.com, Dave Hansen , linux-riscv@lists.infradead.org, Palmer Dabbelt , Nicholas Piggin , Andy Lutomirski , Alexander Gordeev , Will Deacon , Gerald Schaefer , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 2024/4/4 4:45, Andrew Morton wrote: > On Wed, 3 Apr 2024 16:37:58 +0800 Kefeng Wang wrote: > >> After VMA lock-based page fault handling enabled, if bad access met >> under per-vma lock, it will fallback to mmap_lock-based handling, >> so it leads to unnessary mmap lock and vma find again. A test from >> lmbench shows 34% improve after this changes on arm64, >> >> lat_sig -P 1 prot lat_sig 0.29194 -> 0.19198 >> >> Only build test on other archs except arm64. > > Thanks. So we now want a bunch of architectures to runtime test this. Do > we have a selftest in place which will adequately do this? I don't find such selftest, and badaccess would lead to coredump, the performance should not affect most scene, so no selftest is acceptable. lmbench is easy to use to measure the performance. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B0F6CD128A for ; Sun, 7 Apr 2024 07:50:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ag4ANpfuLqBQuRkguwkXvRR85cOn5LSRGzcGULz8lYM=; b=LmVMBvedyDCrI0 q3b5phhyex+KQaJmk0l1yvd8lMdVddA9vSgNuNqdR1QeUVdx4En83FnRF/3ZQ6J2TRVBiGtAf86EH +SKoEUGLiRc7G0WbGbmRysvPVETZLjU2O9XKIcrmRBr2Xix53ifo18NJ5GLUfOlGONuGalYgO4FPm RaI0P5IXCzgJ2FB17ZYsyBlS6CoCG+BAbzqskW8NlSBYOdbOS3kl/jeqiTJqM2AvSh9RyzOByak9R bogHA01fLRGdyTM/hqbuVQvF1DNSCVy11i40NKLvgYaXRktlu4/7rBvwCBmiu9U/fNqTIeTh9hydS 7sjBEeQ46g4e0mejGuaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtNI7-0000000C2V2-1Szs; Sun, 07 Apr 2024 07:50:15 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtNI3-0000000C2Sg-1Or2; Sun, 07 Apr 2024 07:50:13 +0000 Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4VC47C1yhVzwRPw; Sun, 7 Apr 2024 15:47:03 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 5A70414010C; Sun, 7 Apr 2024 15:49:55 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 7 Apr 2024 15:49:54 +0800 Message-ID: <4d45fffc-877a-4ad1-ad02-a33341e467e7@huawei.com> Date: Sun, 7 Apr 2024 15:49:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/7] arch/mm/fault: accelerate pagefault when badaccess Content-Language: en-US To: Andrew Morton CC: Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Dave Hansen , Andy Lutomirski , Peter Zijlstra , , , , , , , References: <20240403083805.1818160-1-wangkefeng.wang@huawei.com> <20240403134539.fde3a6c594f2d88409be30ed@linux-foundation.org> From: Kefeng Wang In-Reply-To: <20240403134539.fde3a6c594f2d88409be30ed@linux-foundation.org> X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm100001.china.huawei.com (7.185.36.93) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240407_005011_896750_14BA352C X-CRM114-Status: UNSURE ( 8.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024/4/4 4:45, Andrew Morton wrote: > On Wed, 3 Apr 2024 16:37:58 +0800 Kefeng Wang wrote: > >> After VMA lock-based page fault handling enabled, if bad access met >> under per-vma lock, it will fallback to mmap_lock-based handling, >> so it leads to unnessary mmap lock and vma find again. A test from >> lmbench shows 34% improve after this changes on arm64, >> >> lat_sig -P 1 prot lat_sig 0.29194 -> 0.19198 >> >> Only build test on other archs except arm64. > > Thanks. So we now want a bunch of architectures to runtime test this. Do > we have a selftest in place which will adequately do this? I don't find such selftest, and badaccess would lead to coredump, the performance should not affect most scene, so no selftest is acceptable. lmbench is easy to use to measure the performance. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel