All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chee, Tien Fong" <tien.fong.chee@altera.com>
To: dinesh.maniyam@altera.com, u-boot@lists.denx.de
Cc: Marek Vasut <marex@denx.de>,
	Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>,
	Tom Rini <trini@konsulko.com>,
	Michal Simek <michal.simek@amd.com>,
	Kok Kiang <kok.kiang.hea@altera.com>,
	Boon Khai <boon.khai.ng@altera.com>,
	Alif <alif.zakuan.yuslaimi@altera.com>,
	Tien Fong Chee <tien.fong.chee@intel.com>
Subject: Re: [PATCH] arm: socfpga: Reset MPFE NoC after programming peripheral / combined RBF
Date: Fri, 17 Apr 2026 16:42:12 +0800	[thread overview]
Message-ID: <4d496d68-a6ca-4ff0-a463-aeaca0febf3a@altera.com> (raw)
In-Reply-To: <20260325054638.13533-1-dinesh.maniyam@altera.com>

Hi Dinesh,


On 25/3/2026 1:46 pm, dinesh.maniyam@altera.com wrote:
> From: Dinesh Maniyam <dinesh.maniyam@altera.com>
>
> This patch triggers warm reset to recover the MPFE NoC from corruption
> due to high frequency transient clock output from HPS EMIF IOPLL at
> VCO startup after peripheral RBF is programmed.
>

As described in the commit message is not acceptable until the 
warm-reset / NoC recovery logic appears in the

series or the message is narrowed to “add SYSMGR ROM-code offset 
definitions for …”.


>
> Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> Signed-off-by: Dinesh Maniyam <dinesh.maniyam@altera.com>
> ---
>   arch/arm/mach-socfpga/include/mach/system_manager_arria10.h | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/mach-socfpga/include/mach/system_manager_arria10.h b/arch/arm/mach-socfpga/include/mach/system_manager_arria10.h
> index 0afe63e647e..73e953465a4 100644
> --- a/arch/arm/mach-socfpga/include/mach/system_manager_arria10.h
> +++ b/arch/arm/mach-socfpga/include/mach/system_manager_arria10.h
> @@ -37,6 +37,10 @@
>   #define SYSMGR_A10_ISW_HANDOFF_BASE		0x230
>   #define SYSMGR_A10_ISW_HANDOFF_7		0x1c
>   
> +#define SYSMGR_A10_ROMCODE_CTRL			0x204
> +#define SYSMGR_A10_ROMCODE_QSPIRESETCOMMAND	0x208
> +#define SYSMGR_A10_ISW_HANDOFF			0x230


Redundant offset / naming: SYSMGR_A10_ISW_HANDOFF is 0x230, the same 
value as SYSMGR_A10_ISW_HANDOFF_BASE

> +
>   #define SYSMGR_SDMMC				SYSMGR_A10_SDMMC
>   
>   #define SYSMGR_SDMMC_SMPLSEL_SHIFT	4

  reply	other threads:[~2026-04-17  8:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25  5:46 [PATCH] arm: socfpga: Reset MPFE NoC after programming peripheral / combined RBF dinesh.maniyam
2026-04-17  8:42 ` Chee, Tien Fong [this message]
2026-07-29  5:53   ` Maniyam, Dinesh via U-Boot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d496d68-a6ca-4ff0-a463-aeaca0febf3a@altera.com \
    --to=tien.fong.chee@altera.com \
    --cc=alif.zakuan.yuslaimi@altera.com \
    --cc=boon.khai.ng@altera.com \
    --cc=dinesh.maniyam@altera.com \
    --cc=kok.kiang.hea@altera.com \
    --cc=marex@denx.de \
    --cc=michal.simek@amd.com \
    --cc=simon.k.r.goldschmidt@gmail.com \
    --cc=tien.fong.chee@intel.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.