All of lore.kernel.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH v3 6/7] Holly DTS
Date: Mon, 7 May 2007 18:08:52 +0200	[thread overview]
Message-ID: <4d59b4ee7d3eef466bd3c25d0a71b1dc@kernel.crashing.org> (raw)
In-Reply-To: <1178549765.2990.67.camel@zod.rchland.ibm.com>

> Add Holly DTS file
>
> Signed-off-by: Stephen Winiecki <stevewin@us.ibm.com>
> Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>

Acked-by: Segher Boessenkool <segher@kernel.crashing.org>

Looks good.  Two more non-essential things:

- Did you forget the L2 cache node or do you really
   just not care about it?
- You can put an "interrupt-parent" property in the
   host bridge node instead of in all its (indirect)
   children.


Segher

  reply	other threads:[~2007-05-07 16:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-07 14:48 [PATCH v3 0/7] Add support for 750CL Holly board Josh Boyer
2007-05-07 14:50 ` [PATCH v3 1/7] Add tsi108_pci.h for common PCI functions Josh Boyer
2007-05-07 14:51 ` [PATCH v3 2/7] Generalize tsi108 PHY types Josh Boyer
2007-05-07 14:52 ` [PATCH v3 3/7] Generalize tsi108 PCI setup Josh Boyer
2007-05-07 14:53 ` [PATCH v3 4/7] Add support for 750CL Holly board Josh Boyer
2007-05-07 18:22   ` Josh Boyer
2007-05-07 19:27     ` Josh Boyer
2007-05-07 14:55 ` [PATCH v3 5/7] Holly defconfig Josh Boyer
2007-05-07 14:56 ` [PATCH v3 6/7] Holly DTS Josh Boyer
2007-05-07 16:08   ` Segher Boessenkool [this message]
2007-05-07 14:57 ` [PATCH v3 7/7] Holly bootwrapper Josh Boyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d59b4ee7d3eef466bd3c25d0a71b1dc@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=jwboyer@linux.vnet.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.