From: Jan Beulich <jbeulich@suse.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
"Stefano Stabellini" <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, cardoe@cardoe.com,
andrew.cooper3@citrix.com, wl@xen.org, iwj@xenproject.org,
anthony.perard@citrix.com,
Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH] firmware: don't build hvmloader if it is not needed
Date: Mon, 15 Feb 2021 09:29:12 +0100 [thread overview]
Message-ID: <4d9200cd-bd4b-e429-5c96-7a4399bb00b4@suse.com> (raw)
In-Reply-To: <20210213135056.GA6191@mail-itl>
On 13.02.2021 14:50, Marek Marczykowski-Górecki wrote:
> On Fri, Feb 12, 2021 at 06:05:40PM -0800, Stefano Stabellini wrote:
>> If rombios, seabios and ovmf are all disabled, don't attempt to build
>> hvmloader.
>
> What if you choose to not build any of rombios, seabios, ovmf, but use
> system one instead? Wouldn't that exclude hvmloader too?
Even further - one can disable all firmware and have every guest
config explicitly specify the firmware to use, afaict.
> This heuristic seems like a bit too much, maybe instead add an explicit
> option to skip hvmloader?
+1 (If making this configurable is needed at all - is having
hvmloader without needing it really a problem?)
Jan
next prev parent reply other threads:[~2021-02-15 8:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 2:05 [PATCH] firmware: don't build hvmloader if it is not needed Stefano Stabellini
2021-02-13 13:50 ` Marek Marczykowski-Górecki
2021-02-15 8:29 ` Jan Beulich [this message]
2021-02-16 18:31 ` Stefano Stabellini
2021-02-17 9:47 ` Jan Beulich
2021-02-17 23:45 ` Stefano Stabellini
2021-02-18 11:40 ` Jan Beulich
2021-02-19 1:42 ` Stefano Stabellini
2021-02-19 8:28 ` Jan Beulich
2021-02-22 23:05 ` Stefano Stabellini
2021-02-23 7:23 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d9200cd-bd4b-e429-5c96-7a4399bb00b4@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=cardoe@cardoe.com \
--cc=iwj@xenproject.org \
--cc=marmarek@invisiblethingslab.com \
--cc=sstabellini@kernel.org \
--cc=stefano.stabellini@xilinx.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.