All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@kernel.org>
To: mahesh.rao@altera.com, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: Matthew Gerlach <matthew.gerlach@altera.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 4/4] firmware: stratix10-svc: Add support for HWMON temperature and voltage read command.
Date: Tue, 3 Jun 2025 14:44:48 -0500	[thread overview]
Message-ID: <4dab7429-9b4f-4e76-9076-aa3eff759730@kernel.org> (raw)
In-Reply-To: <20250526-sip_svc_upstream-v3-4-6a08a4502de3@altera.com>

On 5/26/25 01:25, Mahesh Rao via B4 Relay wrote:
> From: Mahesh Rao <mahesh.rao@altera.com>
> 
> Add support for HWMON commands in stratix10
> Asynchronous communication
> 

Please add more details to your commit message. What kind of HWMON 
commands, and why do you need it. If you ever have to debug using git 
bisect, you'll find these commit message very useful.

Dinh


  reply	other threads:[~2025-06-03 19:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-26  6:25 [PATCH v3 0/4] stratix10: Add framework for asynchronous communication with SDM Mahesh Rao
2025-05-26  6:25 ` Mahesh Rao via B4 Relay
2025-05-26  6:25 ` [PATCH v3 1/4] firmware: stratix10-svc: Add mutex lock and unlock in stratix10 memory allocation/free Mahesh Rao
2025-05-26  6:25   ` Mahesh Rao via B4 Relay
2025-05-27  8:49   ` Krzysztof Kozlowski
2025-05-28 10:27     ` Mahesh Rao
2025-05-26  6:25 ` [PATCH v3 2/4] firmware: stratix10-svc: Implement ID pool management for asynchronous operations Mahesh Rao
2025-05-26  6:25   ` Mahesh Rao via B4 Relay
2025-05-26  6:25 ` [PATCH v3 3/4] firmware: stratix10-svc: Add initial support for asynchronous communication with Stratix10 service channel Mahesh Rao
2025-05-26  6:25   ` Mahesh Rao via B4 Relay
2025-05-27  8:44   ` Krzysztof Kozlowski
2025-05-28 10:29     ` Mahesh Rao
2025-05-28 11:50       ` Krzysztof Kozlowski
2025-06-04 11:19         ` Mahesh Rao
2025-05-26  6:25 ` [PATCH v3 4/4] firmware: stratix10-svc: Add support for HWMON temperature and voltage read command Mahesh Rao
2025-05-26  6:25   ` Mahesh Rao via B4 Relay
2025-06-03 19:44   ` Dinh Nguyen [this message]
2025-06-04 11:21     ` Mahesh Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4dab7429-9b4f-4e76-9076-aa3eff759730@kernel.org \
    --to=dinguyen@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mahesh.rao@altera.com \
    --cc=matthew.gerlach@altera.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.