From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AC183806DC for ; Thu, 20 Aug 2026 15:24:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787239481; cv=none; b=ssOBXnkskPZD3Xbvca+XVFs1D8pypvJK2KAC3MKUBcfOAM8JN1L7pzsesMpEk0nIjynqQLt5xmjvQGxG6kPtAPtFPAe57mqqNdBP5isldEA93Vfe8uy6P/+k5diVXfuDjsikWTAZUAu6sZjWAs3u1Sbv4upf+nKTnTsQ/8QFQPg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787239481; c=relaxed/simple; bh=5mospAeJ+WQFvDOFffDJlYorx2Ldl9egIIWSX5JuVkg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FCfkgrmYtAd4UEhKhJEd2tJCyc42bO47CCPcC8j4YaMfr2MQA6NTgIh1TaU5ZhYhL4SC8zxpevndCdXIaxnOYamZRBzyhrYMpJ2iS2VBU2Z0tcfOzG7Jot68OLeMEWleM79IFbHGzpsKEV2tH+piiHmJwQJbWjmhWC9RQdkIi+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NK6Cx7cQ; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NK6Cx7cQ" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-49556f97a9dso16847515e9.1 for ; Thu, 20 Aug 2026 08:24:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787239478; x=1787844278; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/98bX+CH+lFllKiqKstls0WsvphSuEf3qS82oTyBRRs=; b=NK6Cx7cQ7fIyzPhzqnCWqFrZAWtt8kA41FQhGcdhHhTjnDsHD8IWUoLhVxqhhjTnOK zTfnWP0xxyI213euP2FOSTpTMnYaxHR338mvS7rSFMIrwP/iRuVYZWtJfwa75EwRQO5Y 8eMD4RFLkHmWk0WnxEdiqDjc/t4tH22dGLlqZu41tBAyTseUNShFNWbO1KgWQbFP2pES 1+UaPCIIuJEmrEve710vhZ+16JW4DjPVVXQULQWyEBut7nWUL2uFArTnHLRzi5v3qe9C TpO+49jlxuW1lfSmg6Tdq/2WFWGpsrDI9CcRTOVlfslasY/Pm8CP4ssd+2zfZyrq78au fpTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787239478; x=1787844278; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/98bX+CH+lFllKiqKstls0WsvphSuEf3qS82oTyBRRs=; b=MzQ1crrNULcZa2zBTQrRKib9KO7lcK3abjPqJhftqIak3OJ7vv4uUw0SEfGA5qTXx8 +f1heEa5dkuEJn6rIUakB2ViRKKQ0tfMqRet7tEiJEDj8DhUL+gWab5mqrXtfum/TK3K TSaVtzjloHjlaIJ88nfhPo7sqUvQ4d7+l/BBXH9wD7Ufr7qtr/T5Lp2gdIfIk5MK/9hN jIE4YWRPlVm8+WSeVyGAv++z42csAiQKr+zA2x5BLYZewWW5rI/lHV2D2018kZTZgake g5SO1kRY5n52GJsZuOEkcxgMQuqwOkdhBXUyFtrZU/tDA3sAfoN4vuRFZT/JA4NyUFu5 6feA== X-Forwarded-Encrypted: i=1; AHgh+Rpwlel0YkaNKQtuI+GrYR1kPvZApU9tOdZTSuIAaWOqgyvS9GCxLNEsCh49rPubOmRLhx/KdFhk5Xw1@vger.kernel.org X-Gm-Message-State: AOJu0Yx3Hri0Q28pGbhu27WKTzS/xYGHyEDC5CuOVTc6/JyhkeVqid7W uMpoUFuFswpneva0uEDwqgrI1YQ751Wrca3+TYvVKJlUx0gXu64jTULy X-Gm-Gg: AR+sD133uNNjoR3vwzU4ovxvkWe5dFXGoDEynuzc+326JzJ70yI1H5fVFtw2ziQYkKD OT9X+MIGBoEEpgswG0RaYocASfWMWld8+dD3NqhoZVQ+ZzBPKrRKEP5iE20PUmIpUYKhEl6GpGM 9uY+GSJQTrnn3Nuq+Ufv7czuZxvUZGbn7riGigivduSc1Kyn26QixRrCa1UU5xMUh5hB2vBbROG lePyR1v4WpxPEyDCnekfVbgKTkgpUuUpDW4kfPgXE8PwvxBFhw6Qc+3Vn0ay/SWmrjC/gYhmonY ckhB4sDwF+nTnGzOaiSsIX5To218OYtaDjWGTwDYu7ZJB2a8EYhC+nyBDT49delunLD/2qIKlVL tRsuA+m3LMxAV+mTTO4M5b87mLQ1EWoYpCPolOgn9fDfjNAqK/R1Zm1z3vevKFuxUkxzLuO99HT 7NeXvZRGwyymzxtOaOeRKXtD3tJEVsWxsIGrZHok8aUtZZnsyFLcU3n2TLBGCRV+iHWK+mxkLu1 +PW8USse3CUfiokcZmEv0L4zx2ECA== X-Received: by 2002:a05:600c:6748:b0:497:fecd:5b00 with SMTP id 5b1f17b1804b1-499aa1d0670mr268427225e9.9.1787239477402; Thu, 20 Aug 2026 08:24:37 -0700 (PDT) Received: from [192.168.1.118] (83.31.75.144.ipv4.supernova.orange.pl. [83.31.75.144]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482b14c33b3sm12618644f8f.27.2026.08.20.08.24.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2026 08:24:36 -0700 (PDT) Message-ID: <4dc461a9-68f8-407d-b458-695ac263ca37@gmail.com> Date: Thu, 20 Aug 2026 17:24:35 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/7] arm64: dts: qcom: Add Motorola One To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kees Cook , Tony Luck , "Guilherme G. Piccoli" Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20260820-next-patches-v2-0-7130d68183d9@gmail.com> <20260820-next-patches-v2-3-7130d68183d9@gmail.com> Content-Language: en-US From: Adam Skladowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/20/26 12:17, Konrad Dybcio wrote: > On 8/20/26 11:42 AM, Adam Skladowski wrote: >> Add a devicetree for the Motorola One smartphone, which is based >> on the Jacala/MSM8953 SoC. >> >> Supported functionality as of this initial submission: >> * I2C peripherals (Touchscreen,NFC) >> * Power Button, Volume Keys >> * Regulators (PM8953) >> * Remoteprocs (ADSP, MPSS, WCNSS) >> * USB >> >> Device tree also contains supply maps to other subsystems like MDSS >> but due to missing dependencies like panel those are disabled. >> >> Signed-off-by: Adam Skladowski >> --- > > > [...] > >> + typec-portc@22 { >> + compatible = "fcs,fusb302"; >> + reg = <0x22>; >> + interrupts-extended = <&tlmm 9 IRQ_TYPE_LEVEL_LOW>; >> + >> + pinctrl-names = "default"; >> + pinctrl-0 = <&fusb302_int_default>; > nit: outlying sort > > >> + >> + usb-role-switch = <&usb3>; >> + vbus-supply = <&fusb302_vbus>; >> + >> + connector { >> + compatible = "usb-c-connector"; >> + label = "USB-C"; >> + power-role = "dual"; >> + data-role = "dual"; >> + try-power-role = "sink"; >> + typec-power-opmode = "default"; >> + source-pdos = > + PDO_FIXED_DUAL_ROLE | >> + PDO_FIXED_DATA_SWAP | >> + PDO_FIXED_USB_COMM)>; >> + sink-pdos = > + PDO_FIXED_DUAL_ROLE | >> + PDO_FIXED_DATA_SWAP | >> + PDO_FIXED_USB_COMM)>; >> + op-sink-microwatt = <2000000>; > This is inconsistent with the sink-PDOs you defined (5 V 3 A vs 2 W) > > Konrad To be honest i don't get what's this about. Based on docs it says its minimal W value taken by port and based on PMI8950 Charger it should be about 100mA@5V while SMB1351 can also take as low as 70mA@5V I could see it being higher when port is used to power SBC or something.