From: "Christian Löhle" <CLoehle@hyperstone.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
Linux MMC List <linux-mmc@vger.kernel.org>
Cc: Avri Altman <Avri.Altman@wdc.com>
Subject: [PATCHv4 2/2] mmc-utils: Allow for custom sanitize timeout
Date: Sat, 15 Oct 2022 11:19:31 +0000 [thread overview]
Message-ID: <4ddb5a5510d74645b2724d274c96ab02@hyperstone.com> (raw)
Some cards with certain preconditioning require a higher timeout
when sanitizing. Let the user set the maximum timeout.
Signed-off-by: Christian Loehle <cloehle@hyperstone.com>
---
-v4: Fix argument order in help text
mmc.c | 2 +-
mmc_cmds.c | 10 +++++++---
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/mmc.c b/mmc.c
index 6c56387..4c09b79 100644
--- a/mmc.c
+++ b/mmc.c
@@ -150,7 +150,7 @@ static struct Command commands[] = {
NULL
},
{ do_sanitize, -1,
- "sanitize", "<device>\n"
+ "sanitize", "<device> [timeout_ms]\n"
"Send Sanitize command to the <device>.\nThis will delete the unmapped memory region of the device.",
NULL
},
diff --git a/mmc_cmds.c b/mmc_cmds.c
index 3337ded..9e0571f 100644
--- a/mmc_cmds.c
+++ b/mmc_cmds.c
@@ -1986,12 +1986,16 @@ int do_sanitize(int nargs, char **argv)
{
int fd, ret;
char *device;
+ unsigned int timeout = 0;
- if (nargs != 2) {
- fprintf(stderr, "Usage: mmc sanitize </path/to/mmcblkX>\n");
+ if (nargs != 2 && nargs != 3) {
+ fprintf(stderr, "Usage: mmc sanitize </path/to/mmcblkX> [timeout_in_ms]\n");
exit(1);
}
+ if (nargs == 3)
+ timeout = strtol(argv[2], NULL, 10);
+
device = argv[1];
fd = open(device, O_RDWR);
@@ -2000,7 +2004,7 @@ int do_sanitize(int nargs, char **argv)
exit(1);
}
- ret = write_extcsd_value(fd, EXT_CSD_SANITIZE_START, 1, 0);
+ ret = write_extcsd_value(fd, EXT_CSD_SANITIZE_START, 1, timeout);
if (ret) {
fprintf(stderr, "Could not write 0x%02x to EXT_CSD[%d] in %s\n",
1, EXT_CSD_SANITIZE_START, device);
--
2.37.3
Hyperstone GmbH | Reichenaustr. 39a | 78467 Konstanz
Managing Director: Dr. Jan Peter Berns.
Commercial register of local courts: Freiburg HRB381782
next reply other threads:[~2022-10-15 11:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 11:19 Christian Löhle [this message]
2022-10-15 11:31 ` [PATCHv4 2/2] mmc-utils: Allow for custom sanitize timeout Christian Löhle
2022-10-24 17:01 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ddb5a5510d74645b2724d274c96ab02@hyperstone.com \
--to=cloehle@hyperstone.com \
--cc=Avri.Altman@wdc.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.