From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13818C4360F for ; Tue, 2 Apr 2019 16:03:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D664A20840 for ; Tue, 2 Apr 2019 16:03:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="biuwqF4X" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730687AbfDBQDi (ORCPT ); Tue, 2 Apr 2019 12:03:38 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:44312 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729662AbfDBQDi (ORCPT ); Tue, 2 Apr 2019 12:03:38 -0400 Received: by mail-pl1-f196.google.com with SMTP id g12so6490862pll.11 for ; Tue, 02 Apr 2019 09:03:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hzqZmS8s0oIhdHfKPJr/vvZmze2xoI8xP6tEZUolsKM=; b=biuwqF4X77KZ+59ONLjPJ5Idpt7/rBN62dARG9hsYLWfGtHn6z8u02ncTduE4S2CYa aIzmddapkOjhRDwutgB5VKtXJiZsTOeblb9FG0AzTH+C27NoDPxw2u5ZRCyzb/0E0A6+ g0k8WNhr7klbYztQ+StEjfZJbtILfBVplSvD/d8uJksAkHXghlefhroRUmH/P4jpE/MM mdI+ft1XpNSkUE5BPMBKO+0rWW7Dge3xGP2vrrLwEvYcLYrBYQwszOCFjeCQMcAw1ibO zha9WJoL41EZ3nHayHSAbRNkO0424VpZ+omZVdo8sodcd2uRkKTUNFDc1KCkVPpbg/wO LEJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hzqZmS8s0oIhdHfKPJr/vvZmze2xoI8xP6tEZUolsKM=; b=rkJuz71GVBLPDyPQcdiAyj3AAO7B55SBQdu4tt0T4Npv++3GsaBvP6M8vqw4O6nB7g z61Yl82cRxp343TG65VcrgA/jQnNpPaaqYX10oBrOSANe1GHUOMocfcbzNjsp6+IyeZh rPyBu+C2RYo8B6pAni4U1AdmjGUe4hxOXRrrCrJ01PkieaQ+aorL79ih3dvx+NEnCcJt m3SyF+uBQH7FHqjpoJRSh8eoUcNfZ5BhN/Psl1bIqasMBuUgxPkkJcrVCWCKcwJE03ew i/5h6EKWdH8gAAXV3SSFz5ADEkh1z0bxdKDDQOKKyfTTbF8CGI0Q/mD8ZuUJO7vQNFki xPNw== X-Gm-Message-State: APjAAAX4+eDxVkMpFzBGw+8ASpQhoL6BIj/RyWSYJNYIkhL6/o/m4FEb fiPb2tzdG/E7p8H7Q0lkpbUXLr89 X-Google-Smtp-Source: APXvYqz8PK//I8zHCGlPIOYgbzrwGW1kPuA+tkryXgEB/o9ocWRtLlJUDOgxRHb74ut/YC4YafxEbA== X-Received: by 2002:a17:902:b43:: with SMTP id 61mr70810823plq.83.1554221017290; Tue, 02 Apr 2019 09:03:37 -0700 (PDT) Received: from ?IPv6:2601:282:800:fd80:9c25:bc88:7770:eafa? ([2601:282:800:fd80:9c25:bc88:7770:eafa]) by smtp.googlemail.com with ESMTPSA id y12sm36223308pgq.64.2019.04.02.09.03.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Apr 2019 09:03:36 -0700 (PDT) Subject: Re: [PATCH v3 net-next 1/5] ipv4: Update fib_table_lookup tracepoint to take common nexthop To: Martin Lau , David Ahern Cc: "davem@davemloft.net" , "netdev@vger.kernel.org" , "idosch@mellanox.com" References: <20190402030234.26802-1-dsahern@kernel.org> <20190402030234.26802-2-dsahern@kernel.org> <20190402160058.efxurtjpgxa7mxa4@kafai-mbp.dhcp.thefacebook.com> From: David Ahern Message-ID: <4e015b18-cd94-76ba-e922-34d4c91c9f89@gmail.com> Date: Tue, 2 Apr 2019 10:03:34 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190402160058.efxurtjpgxa7mxa4@kafai-mbp.dhcp.thefacebook.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/2/19 10:01 AM, Martin Lau wrote: > On Mon, Apr 01, 2019 at 08:02:30PM -0700, David Ahern wrote: >> From: David Ahern >> >> Update fib_table_lookup tracepoint to take a fib_nh_common struct and >> dump the v6 gateway address if the nexthop uses it. >> >> Signed-off-by: David Ahern >> --- >> include/trace/events/fib.h | 45 ++++++++++++++++++++++++++------------------- >> net/ipv4/fib_trie.c | 2 +- >> 2 files changed, 27 insertions(+), 20 deletions(-) >> >> diff --git a/include/trace/events/fib.h b/include/trace/events/fib.h >> index 61ea7a24c8e5..7f83b6eafc5c 100644 >> --- a/include/trace/events/fib.h >> +++ b/include/trace/events/fib.h >> @@ -13,9 +13,9 @@ >> TRACE_EVENT(fib_table_lookup, >> >> TP_PROTO(u32 tb_id, const struct flowi4 *flp, >> - const struct fib_nh *nh, int err), >> + const struct fib_nh_common *nhc, int err), >> >> - TP_ARGS(tb_id, flp, nh, err), >> + TP_ARGS(tb_id, flp, nhc, err), >> >> TP_STRUCT__entry( >> __field( u32, tb_id ) >> @@ -28,14 +28,17 @@ TRACE_EVENT(fib_table_lookup, >> __field( __u8, flags ) >> __array( __u8, src, 4 ) >> __array( __u8, dst, 4 ) >> - __array( __u8, gw, 4 ) >> - __array( __u8, saddr, 4 ) > saddr is no longer useful? > I have not found it useful, and I use this tracepoint a lot. The line length is really long as is and adding the ipv6 address just makes it worse.