From: David Ahern <dsahern@gmail.com>
To: Ido Schimmel <idosch@idosch.org>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org
Cc: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de,
roopa@nvidia.com, nikolay@nvidia.com, msoltyspl@yandex.pl,
mlxsw@nvidia.com, Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH nf-next v2 2/2] selftests: fib_tests: Add test cases for interaction with mangling
Date: Wed, 14 Apr 2021 10:27:17 -0700 [thread overview]
Message-ID: <4e05edd4-e03c-bf95-0375-68970815d523@gmail.com> (raw)
In-Reply-To: <20210414082033.1568363-3-idosch@idosch.org>
On 4/14/21 1:20 AM, Ido Schimmel wrote:
> From: Ido Schimmel <idosch@nvidia.com>
>
> Test that packets are correctly routed when netfilter mangling rules are
> present.
>
> Without previous patch:
>
> # ./fib_tests.sh -t ipv4_mangle
>
> IPv4 mangling tests
> TEST: Connection with correct parameters [ OK ]
> TEST: Connection with incorrect parameters [ OK ]
> TEST: Connection with correct parameters - mangling [FAIL]
> TEST: Connection with correct parameters - no mangling [ OK ]
> TEST: Connection check - server side [FAIL]
>
> Tests passed: 3
> Tests failed: 2
>
> # ./fib_tests.sh -t ipv6_mangle
>
> IPv6 mangling tests
> TEST: Connection with correct parameters [ OK ]
> TEST: Connection with incorrect parameters [ OK ]
> TEST: Connection with correct parameters - mangling [FAIL]
> TEST: Connection with correct parameters - no mangling [ OK ]
> TEST: Connection check - server side [FAIL]
>
> Tests passed: 3
> Tests failed: 2
>
> With previous patch:
>
> # ./fib_tests.sh -t ipv4_mangle
>
> IPv4 mangling tests
> TEST: Connection with correct parameters [ OK ]
> TEST: Connection with incorrect parameters [ OK ]
> TEST: Connection with correct parameters - mangling [ OK ]
> TEST: Connection with correct parameters - no mangling [ OK ]
> TEST: Connection check - server side [ OK ]
>
> Tests passed: 5
> Tests failed: 0
>
> # ./fib_tests.sh -t ipv6_mangle
>
> IPv6 mangling tests
> TEST: Connection with correct parameters [ OK ]
> TEST: Connection with incorrect parameters [ OK ]
> TEST: Connection with correct parameters - mangling [ OK ]
> TEST: Connection with correct parameters - no mangling [ OK ]
> TEST: Connection check - server side [ OK ]
>
> Tests passed: 5
> Tests failed: 0
>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
> tools/testing/selftests/net/fib_tests.sh | 152 ++++++++++++++++++++++-
> 1 file changed, 151 insertions(+), 1 deletion(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
Thanks, Ido.
next prev parent reply other threads:[~2021-04-14 17:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 8:20 [PATCH nf-next v2 0/2] netfilter: Dissect flow after packet mangling Ido Schimmel
2021-04-14 8:20 ` [PATCH nf-next v2 1/2] " Ido Schimmel
2021-04-14 8:20 ` [PATCH nf-next v2 2/2] selftests: fib_tests: Add test cases for interaction with mangling Ido Schimmel
2021-04-14 17:27 ` David Ahern [this message]
2021-04-18 18:49 ` [PATCH nf-next v2 0/2] netfilter: Dissect flow after packet mangling Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e05edd4-e03c-bf95-0375-68970815d523@gmail.com \
--to=dsahern@gmail.com \
--cc=coreteam@netfilter.org \
--cc=fw@strlen.de \
--cc=idosch@idosch.org \
--cc=idosch@nvidia.com \
--cc=kadlec@netfilter.org \
--cc=mlxsw@nvidia.com \
--cc=msoltyspl@yandex.pl \
--cc=netfilter-devel@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=pablo@netfilter.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.