From: Jonas Jelonek <jelonek.jonas@gmail.com>
To: Sven Eckelmann <sven@narfation.org>,
Chris Packham <chris.packham@alliedtelesis.co.nz>,
Andi Shyti <andi.shyti@kernel.org>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Harshal Gohel <hg@simonwunderlich.de>,
Simon Wunderlich <sw@simonwunderlich.de>
Subject: Re: [PATCH i2c-host v4 5/5] i2c: rtl9300: Implement I2C block read and write
Date: Sun, 10 Aug 2025 00:11:20 +0200 [thread overview]
Message-ID: <4e192acc-3364-4318-b31b-120a37af6a2f@gmail.com> (raw)
In-Reply-To: <20250809-i2c-rtl9300-multi-byte-v4-5-d71dd5eb6121@narfation.org>
Hi Sven,
On 09.08.2025 08:40, Sven Eckelmann wrote:
> @@ -314,6 +343,7 @@ static u32 rtl9300_i2c_func(struct i2c_adapter *a)
> {
> return I2C_FUNC_SMBUS_QUICK | I2C_FUNC_SMBUS_BYTE |
> I2C_FUNC_SMBUS_BYTE_DATA | I2C_FUNC_SMBUS_WORD_DATA |
> + I2C_FUNC_SMBUS_READ_I2C_BLOCK | I2C_FUNC_SMBUS_WRITE_I2C_BLOCK |
> I2C_FUNC_SMBUS_BLOCK_DATA;
> }
>
Is there a specific reason you explicitly use I2C_FUNC_SMBUS_READ_I2C_BLOCK and
*_WRITE_* instead of I2C_FUNC_SMBUS_I2C_BLOCK ?
Best regards,
Jonas Jelonek
next prev parent reply other threads:[~2025-08-09 22:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-09 6:40 [PATCH i2c-host-fixes v4 0/5] i2c: rtl9300: Fix multi-byte I2C operations Sven Eckelmann
2025-08-09 6:40 ` [PATCH i2c-host-fixes v4 1/5] i2c: rtl9300: Fix out-of-bounds bug in rtl9300_i2c_smbus_xfer Sven Eckelmann
2025-08-09 17:34 ` Wolfram Sang
2025-08-09 6:40 ` [PATCH i2c-host-fixes v4 2/5] i2c: rtl9300: Fix multi-byte I2C write Sven Eckelmann
2025-08-09 6:40 ` [PATCH i2c-host-fixes v4 3/5] i2c: rtl9300: Increase timeout for transfer polling Sven Eckelmann
2025-08-09 6:40 ` [PATCH i2c-host-fixes v4 4/5] i2c: rtl9300: Add missing count byte for SMBus Block Ops Sven Eckelmann
2025-08-09 6:40 ` [PATCH i2c-host v4 5/5] i2c: rtl9300: Implement I2C block read and write Sven Eckelmann
2025-08-09 22:11 ` Jonas Jelonek [this message]
2025-08-10 5:59 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e192acc-3364-4318-b31b-120a37af6a2f@gmail.com \
--to=jelonek.jonas@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=hg@simonwunderlich.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sven@narfation.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.