Re: [RFC PATCH 11/31] lib: Kconfig: add a config symbol for getting memory map updates

[Heinrich Schuchardt <xypron.glpk@gmx.de>]

On 6/8/24 05:53, Heinrich Schuchardt wrote:
>
>
> Am 7. Juni 2024 20:52:20 MESZ schrieb Sughosh Ganu <sughosh.ganu@linaro.org>:
>> Add a Kconfig symbol to enable getting updates on any memory map
>> changes that might be done by some other module. This notification
>> mechanism can then be used to have a synchronous view of allocated and
>> free memory.
>>
>> Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
>> ---
>> lib/Kconfig | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/lib/Kconfig b/lib/Kconfig
>> index 189e6eb31a..9ea02ae006 100644
>> --- a/lib/Kconfig
>> +++ b/lib/Kconfig
>> @@ -74,6 +74,15 @@ config HAVE_PRIVATE_LIBGCC
>> config LIB_UUID
>> 	bool
>>
>> +config MEM_MAP_UPDATE_NOTIFY
>> +	bool "Get notified of any changes to the memory map"

Looking at later patches it seems you are sending memory map events from
different memory maps: LMB and EFI.

%s/to the memory map/to a memory map/

>
> To the "LMB memory map"?
>
>> +	default y if EVENT && LMB && EFI_LOADER
>
> I am missing 'depends on EVENT && LMB' here. This should allow to simplify the 'default' statement. But why not use select?

Sending messaging makes only sense if two memory management systems are
present. How about:

depends on EVENT && LMB && EFI_LOADER
default y

>
> Best regards
>
> Heinrich
>
>
>
>> +	help
>> +	  Enable this option to get notification on any changes to the
>> +	  memory that is allocated or freed. This will allow different
>> +	  modules that allocate memory to have a synchronous view of available
>> +	  and allocated memory.

Mentioning LMB and EFI here would be helpful:

help
   U-Boot manages memory allocation in multiple modules: LMB and EFI.
   To keep them synchronized memory change messages are used.
   Enable this symbol to ensure synchronization.

Best regards

Heinrich

>> +
>> config RANDOM_UUID
>> 	bool "GPT Random UUID generation"
>> 	select LIB_UUID