From: <Codrin.Ciubotariu@microchip.com>
To: <broonie@kernel.org>, <lgirdwood@gmail.com>, <peda@axentia.se>
Cc: alsa-devel@alsa-project.org, Ludovic.Desroches@microchip.com,
alexandre.belloni@bootlin.com, Nicolas.Ferre@microchip.com
Subject: Re: [PATCH v2] ASoC: atmel: Convert to new style DAI format definitions
Date: Thu, 16 Sep 2021 07:57:33 +0000 [thread overview]
Message-ID: <4e31450e-55b2-3ad8-8481-e4868952d2ed@microchip.com> (raw)
In-Reply-To: <20210915181048.40070-1-broonie@kernel.org>
On 15.09.2021 21:10, Mark Brown wrote:
> Convert the Atmel drivers to use the new style defines for clocking in DAI
> formats.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Thanks!
> switch (dev->fmt & SND_SOC_DAIFMT_MASTER_MASK) {
> - case SND_SOC_DAIFMT_CBS_CFS:
> + case SND_SOC_DAIFMT_CBC_CFC:
> /* codec is slave, so cpu is master */
...
>
> - case SND_SOC_DAIFMT_CBM_CFM:
> + case SND_SOC_DAIFMT_CBP_CFP:
> /* codec is master, so cpu is slave */
probably these comments should also be changed.
next prev parent reply other threads:[~2021-09-16 7:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 18:10 [PATCH v2] ASoC: atmel: Convert to new style DAI format definitions Mark Brown
2021-09-16 7:57 ` Codrin.Ciubotariu [this message]
2021-09-16 9:11 ` Peter Rosin
2021-09-16 15:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e31450e-55b2-3ad8-8481-e4868952d2ed@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.