From: Jens Axboe <axboe@kernel.dk>
To: Anuj Gupta <anuj20.g@samsung.com>
Cc: vincent.fu@samsung.com, fio@vger.kernel.org,
ankit.kumar@samsung.com, anuj1072538@gmail.com
Subject: Re: [PATCH] t/io_uring: fix error handling for setup_ring
Date: Thu, 27 Apr 2023 05:48:01 -0600 [thread overview]
Message-ID: <4e368610-30aa-4f2a-202b-d93050ea1f02@kernel.dk> (raw)
In-Reply-To: <20230427151004.1146679-1-anuj20.g@samsung.com>
On 4/27/23 9:10 AM, Anuj Gupta wrote:
> s->sq_ring.ring_entries and s->cq_ring.ring_entries will be NULL,
> incase setup_ring fails. This will cause a segmentation fault.
>
> In case setup_ring fails, bail out by setting finish.
Any reason why we don't just use the return code of submitter_init()
on whether to abort or not?
--
Jens Axboe
next prev parent reply other threads:[~2023-04-27 11:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230427094952epcas5p32967ed548e18e60ea3134a03aa046bb8@epcas5p3.samsung.com>
2023-04-27 15:10 ` [PATCH] t/io_uring: fix error handling for setup_ring Anuj Gupta
2023-04-27 11:48 ` Jens Axboe [this message]
2023-04-27 11:53 ` Jens Axboe
2023-04-27 12:26 ` Anuj gupta
2023-04-27 13:22 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e368610-30aa-4f2a-202b-d93050ea1f02@kernel.dk \
--to=axboe@kernel.dk \
--cc=ankit.kumar@samsung.com \
--cc=anuj1072538@gmail.com \
--cc=anuj20.g@samsung.com \
--cc=fio@vger.kernel.org \
--cc=vincent.fu@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.