From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3890AC433F5 for ; Fri, 3 Sep 2021 06:01:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D57B60FA0 for ; Fri, 3 Sep 2021 06:01:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236242AbhICGB7 (ORCPT ); Fri, 3 Sep 2021 02:01:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233634AbhICGB7 (ORCPT ); Fri, 3 Sep 2021 02:01:59 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F337C061760; Thu, 2 Sep 2021 23:00:59 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id i28so7877293ljm.7; Thu, 02 Sep 2021 23:00:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SS3V2W7eXZoP72eB0dNOwnog6SXuQ/C6UHFp2+JfZGw=; b=R9dDX2T14oDoEKx683zCy++Xv/CAPNNlfzWgOaJhaFiOcwdCpmNxJ5SELcoEYEAiFy M9KKB4uXxOB2d7rrmmcTEWdfGN4Yu09YpEgg0YTMr1BTKrcmNoiFH91FoMpnLdz+z3li 68V9RLI2aaJjRI015cLpYjuPpSRePCbs9Wbm9z7iO96yBukOUnv2jUCsjh21qIBhN5eL ucdgNuXFLM571qwPSTVw6TZDWAL1diXBnkqpMBQyNCkB1CQCDVlq449Y5zUiKlnRrrwd w0sfS5Cj+xNK/y4anrGdLy7Kkbp8BWb7l43eQrEfV8TdFCmIcVXZHXDyExuazqjdYBtl cwCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SS3V2W7eXZoP72eB0dNOwnog6SXuQ/C6UHFp2+JfZGw=; b=RRb+2Z4W3yhOOPXRXjGqME9OCxeUAPio4FqFEzHtq9cyGKsW2dUMqRM+FBiqKikTQh DXWbZXytLfBrR+OeEIEC8//rF/7FU+D0tqhqxNGhaV7PohdtMoY+nDXX9M4aFp8TqWq+ L5lFF7KkYVqfIPw7ENzHr2BlW7Mp7vJUjnqEAajphkzclaQN2f1Ug3QSnv8Pv4BxX7s9 CjEzQ14ZSfEqn2/vnH7exazl15QDkyfVHcEVt+R8NaB0LjGU1aM6FK9jfQKM0yaBqIXm a1Xm9xBX3zGRyrU+9JSsBTKBusweac6DKZQYt+JTW7hyAvRJOb+5ODrpsNrpivlOIr8/ 1QXQ== X-Gm-Message-State: AOAM532Z8h8EDkie/buZkN6fF/QvoR6xpmJQrjgnG0DoXlyxqcKsSeKz 033d9TNNYmL5xs8SmfGuU843UlnzXM8= X-Google-Smtp-Source: ABdhPJyJCkOBGaqkZOl8FXnvhO3LuowRf0vib98qqnnyYHT6qHeOk/hFrHs33I31k6easfCeqUMX8w== X-Received: by 2002:a05:651c:11c7:: with SMTP id z7mr1606998ljo.464.1630648857737; Thu, 02 Sep 2021 23:00:57 -0700 (PDT) Received: from [192.168.2.145] (46-138-26-37.dynamic.spd-mgts.ru. [46.138.26.37]) by smtp.googlemail.com with ESMTPSA id u10sm397071lft.252.2021.09.02.23.00.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Sep 2021 23:00:57 -0700 (PDT) Subject: Re: [PATCH 3/3] PM: domains: Add a ->dev_get_performance_state() callback to genpd To: Ulf Hansson , "Rafael J . Wysocki" , Viresh Kumar , linux-pm@vger.kernel.org Cc: Dmitry Baryshkov , Jonathan Hunter , Thierry Reding , Rajendra Nayak , Stephan Gerhold , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210902101634.827187-1-ulf.hansson@linaro.org> <20210902101634.827187-4-ulf.hansson@linaro.org> From: Dmitry Osipenko Message-ID: <4e36e732-6ca3-1d00-e6dd-38bb8877577b@gmail.com> Date: Fri, 3 Sep 2021 09:00:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210902101634.827187-4-ulf.hansson@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org 02.09.2021 13:16, Ulf Hansson пишет: > Hardware may be preprogrammed to a specific performance state, which may > not be zero initially during boot. This may lead to that genpd's current > performance state becomes inconsistent with the state of the hardware. To > deal with this, the driver for a device that is being attached to its > genpd, need to request an initial performance state vote, which is > typically done by calling some of the OPP APIs while probing. > > In some cases this would lead to boilerplate code in the drivers. Let's > make it possible to avoid this, by adding a new optional callback to genpd > and invoke it per device during the attach process. In this way, the genpd > provider driver can inform genpd about the initial performance state that > is needed for the device. > > Signed-off-by: Ulf Hansson > --- > drivers/base/power/domain.c | 8 +++++--- > include/linux/pm_domain.h | 2 ++ > 2 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index 800adf831cae..1a6f3538af8d 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -2640,13 +2640,15 @@ static void genpd_dev_pm_sync(struct device *dev) > genpd_queue_power_off_work(pd); > } > > -static int genpd_get_default_performance_state(struct device *dev, > +static int genpd_get_default_performance_state(struct generic_pm_domain *genpd, > + struct device *dev, > unsigned int index) > { > int pstate = of_get_required_opp_performance_state(dev->of_node, index); > > if (pstate == -ENODEV || pstate == -EOPNOTSUPP) > - return 0; > + pstate = genpd->dev_get_performance_state ? > + genpd->dev_get_performance_state(genpd, dev) : 0; > > return pstate; > } > @@ -2701,7 +2703,7 @@ static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev, > } > > /* Set the default performance state */ > - pstate = genpd_get_default_performance_state(dev, index); > + pstate = genpd_get_default_performance_state(pd, dev, index); If base device is suspended, then its performance state is zero. When device will be rpm-resumed, then its performance should be set to the default state. You're setting performance state of the wrong device, it should be the base device and not the virtual domain device. These all is handled properly by my patch [1]. Hence it's complicated for the reason. [1] https://patchwork.ozlabs.org/project/linux-tegra/patch/20210831135450.26070-5-digetx@gmail.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CA96C4332F for ; Fri, 3 Sep 2021 06:04:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C1F460FE6 for ; Fri, 3 Sep 2021 06:04:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4C1F460FE6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=7eqGO2AF2ri9ut1drb41r1ub+BxLmR/L5kJNAQs7v2M=; b=ITa7Cq4WZ1RKCdyIWfUcAxLNr6 bJTLxu4TDJEBmXoZhSBTmwIast+AAK6v9aubsNto9M8UvuE19KGttspbLi770EPNt85viRunfxERR 1xbuHIGTWB7HfQbBLSzPq/BxZMr939XjigpdqX4OeWLER7Z6WvF6tSqVKfB2Y2vREq/mDTl9clNGS Q10QAOJkXm/txCR3c9VPjxhPHj1/AMTwPw2pobq55SYyN6sPxSVcDU8h5ztn60dAhr3H8pFFHbOvS dIFy5puLAQK3VWqjh08ZIYFr7364q63QRpJfKvz97XlJZTvV6Ikp3nLr9W70oN1Wrp4I/VUVTFph0 fWhgQP0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mM2GV-00B1L1-T6; Fri, 03 Sep 2021 06:01:28 +0000 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mM2G4-00B1De-Pg for linux-arm-kernel@lists.infradead.org; Fri, 03 Sep 2021 06:01:02 +0000 Received: by mail-lj1-x22f.google.com with SMTP id q21so7875848ljj.6 for ; Thu, 02 Sep 2021 23:00:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SS3V2W7eXZoP72eB0dNOwnog6SXuQ/C6UHFp2+JfZGw=; b=R9dDX2T14oDoEKx683zCy++Xv/CAPNNlfzWgOaJhaFiOcwdCpmNxJ5SELcoEYEAiFy M9KKB4uXxOB2d7rrmmcTEWdfGN4Yu09YpEgg0YTMr1BTKrcmNoiFH91FoMpnLdz+z3li 68V9RLI2aaJjRI015cLpYjuPpSRePCbs9Wbm9z7iO96yBukOUnv2jUCsjh21qIBhN5eL ucdgNuXFLM571qwPSTVw6TZDWAL1diXBnkqpMBQyNCkB1CQCDVlq449Y5zUiKlnRrrwd w0sfS5Cj+xNK/y4anrGdLy7Kkbp8BWb7l43eQrEfV8TdFCmIcVXZHXDyExuazqjdYBtl cwCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SS3V2W7eXZoP72eB0dNOwnog6SXuQ/C6UHFp2+JfZGw=; b=jR/KHxyl3RNz4zkJJgD8KvHi/EI7/xAzOwsmT/dZaSWVOqaNtF9kLR7p2+AqMQMXaO 5Rt7PvxJuw8Fyw/cp8tF9cG5wsmq233L00QHGfIjUIlAY1pJ2hRoLv+xITWohB+lEPnE sggnyQZ/876F5gRoynImJYCDL25R0ykmvuP/GGNCGv/Ij3Zo9eVtyEgM/bZZ9m5p7KoZ 70TTIX09iHTqwFfmVOTMahDGc2cpzq28rOKVutDopmN8hAd3aHDW+k8ATle9ra9RDJ16 CM3pG/jol/JtrXee3/vpLmv11Ia9l2mN77bT4grSWg4rak0nu6ncRSpGi/vwR3JFcBoK 1yUA== X-Gm-Message-State: AOAM533yHpcHOIUjVuc/MHDjoiHjC3flKvzlDWmQUKfSVv2aUeOa7g8Q iyBYLhIC5bGnJT2cKUxMIJ0xk0qXPzo= X-Google-Smtp-Source: ABdhPJyJCkOBGaqkZOl8FXnvhO3LuowRf0vib98qqnnyYHT6qHeOk/hFrHs33I31k6easfCeqUMX8w== X-Received: by 2002:a05:651c:11c7:: with SMTP id z7mr1606998ljo.464.1630648857737; Thu, 02 Sep 2021 23:00:57 -0700 (PDT) Received: from [192.168.2.145] (46-138-26-37.dynamic.spd-mgts.ru. [46.138.26.37]) by smtp.googlemail.com with ESMTPSA id u10sm397071lft.252.2021.09.02.23.00.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Sep 2021 23:00:57 -0700 (PDT) Subject: Re: [PATCH 3/3] PM: domains: Add a ->dev_get_performance_state() callback to genpd To: Ulf Hansson , "Rafael J . Wysocki" , Viresh Kumar , linux-pm@vger.kernel.org Cc: Dmitry Baryshkov , Jonathan Hunter , Thierry Reding , Rajendra Nayak , Stephan Gerhold , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210902101634.827187-1-ulf.hansson@linaro.org> <20210902101634.827187-4-ulf.hansson@linaro.org> From: Dmitry Osipenko Message-ID: <4e36e732-6ca3-1d00-e6dd-38bb8877577b@gmail.com> Date: Fri, 3 Sep 2021 09:00:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210902101634.827187-4-ulf.hansson@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210902_230100_907308_E3DAD820 X-CRM114-Status: GOOD ( 31.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org MDIuMDkuMjAyMSAxMzoxNiwgVWxmIEhhbnNzb24g0L/QuNGI0LXRgjoKPiBIYXJkd2FyZSBtYXkg YmUgcHJlcHJvZ3JhbW1lZCB0byBhIHNwZWNpZmljIHBlcmZvcm1hbmNlIHN0YXRlLCB3aGljaCBt YXkKPiBub3QgYmUgemVybyBpbml0aWFsbHkgZHVyaW5nIGJvb3QuIFRoaXMgbWF5IGxlYWQgdG8g dGhhdCBnZW5wZCdzIGN1cnJlbnQKPiBwZXJmb3JtYW5jZSBzdGF0ZSBiZWNvbWVzIGluY29uc2lz dGVudCB3aXRoIHRoZSBzdGF0ZSBvZiB0aGUgaGFyZHdhcmUuIFRvCj4gZGVhbCB3aXRoIHRoaXMs IHRoZSBkcml2ZXIgZm9yIGEgZGV2aWNlIHRoYXQgaXMgYmVpbmcgYXR0YWNoZWQgdG8gaXRzCj4g Z2VucGQsIG5lZWQgdG8gcmVxdWVzdCBhbiBpbml0aWFsIHBlcmZvcm1hbmNlIHN0YXRlIHZvdGUs IHdoaWNoIGlzCj4gdHlwaWNhbGx5IGRvbmUgYnkgY2FsbGluZyBzb21lIG9mIHRoZSBPUFAgQVBJ cyB3aGlsZSBwcm9iaW5nLgo+IAo+IEluIHNvbWUgY2FzZXMgdGhpcyB3b3VsZCBsZWFkIHRvIGJv aWxlcnBsYXRlIGNvZGUgaW4gdGhlIGRyaXZlcnMuIExldCdzCj4gbWFrZSBpdCBwb3NzaWJsZSB0 byBhdm9pZCB0aGlzLCBieSBhZGRpbmcgYSBuZXcgb3B0aW9uYWwgY2FsbGJhY2sgdG8gZ2VucGQK PiBhbmQgaW52b2tlIGl0IHBlciBkZXZpY2UgZHVyaW5nIHRoZSBhdHRhY2ggcHJvY2Vzcy4gSW4g dGhpcyB3YXksIHRoZSBnZW5wZAo+IHByb3ZpZGVyIGRyaXZlciBjYW4gaW5mb3JtIGdlbnBkIGFi b3V0IHRoZSBpbml0aWFsIHBlcmZvcm1hbmNlIHN0YXRlIHRoYXQKPiBpcyBuZWVkZWQgZm9yIHRo ZSBkZXZpY2UuCj4gCj4gU2lnbmVkLW9mZi1ieTogVWxmIEhhbnNzb24gPHVsZi5oYW5zc29uQGxp bmFyby5vcmc+Cj4gLS0tCj4gIGRyaXZlcnMvYmFzZS9wb3dlci9kb21haW4uYyB8IDggKysrKyst LS0KPiAgaW5jbHVkZS9saW51eC9wbV9kb21haW4uaCAgIHwgMiArKwo+ICAyIGZpbGVzIGNoYW5n ZWQsIDcgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9iYXNlL3Bvd2VyL2RvbWFpbi5jIGIvZHJpdmVycy9iYXNlL3Bvd2VyL2RvbWFpbi5jCj4g aW5kZXggODAwYWRmODMxY2FlLi4xYTZmMzUzOGFmOGQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9i YXNlL3Bvd2VyL2RvbWFpbi5jCj4gKysrIGIvZHJpdmVycy9iYXNlL3Bvd2VyL2RvbWFpbi5jCj4g QEAgLTI2NDAsMTMgKzI2NDAsMTUgQEAgc3RhdGljIHZvaWQgZ2VucGRfZGV2X3BtX3N5bmMoc3Ry dWN0IGRldmljZSAqZGV2KQo+ICAJZ2VucGRfcXVldWVfcG93ZXJfb2ZmX3dvcmsocGQpOwo+ICB9 Cj4gIAo+IC1zdGF0aWMgaW50IGdlbnBkX2dldF9kZWZhdWx0X3BlcmZvcm1hbmNlX3N0YXRlKHN0 cnVjdCBkZXZpY2UgKmRldiwKPiArc3RhdGljIGludCBnZW5wZF9nZXRfZGVmYXVsdF9wZXJmb3Jt YW5jZV9zdGF0ZShzdHJ1Y3QgZ2VuZXJpY19wbV9kb21haW4gKmdlbnBkLAo+ICsJCQkJCSAgICAg ICBzdHJ1Y3QgZGV2aWNlICpkZXYsCj4gIAkJCQkJICAgICAgIHVuc2lnbmVkIGludCBpbmRleCkK PiAgewo+ICAJaW50IHBzdGF0ZSA9IG9mX2dldF9yZXF1aXJlZF9vcHBfcGVyZm9ybWFuY2Vfc3Rh dGUoZGV2LT5vZl9ub2RlLCBpbmRleCk7Cj4gIAo+ICAJaWYgKHBzdGF0ZSA9PSAtRU5PREVWIHx8 IHBzdGF0ZSA9PSAtRU9QTk9UU1VQUCkKPiAtCQlyZXR1cm4gMDsKPiArCQlwc3RhdGUgPSBnZW5w ZC0+ZGV2X2dldF9wZXJmb3JtYW5jZV9zdGF0ZSA/Cj4gKwkJCSBnZW5wZC0+ZGV2X2dldF9wZXJm b3JtYW5jZV9zdGF0ZShnZW5wZCwgZGV2KSA6IDA7Cj4gIAo+ICAJcmV0dXJuIHBzdGF0ZTsKPiAg fQo+IEBAIC0yNzAxLDcgKzI3MDMsNyBAQCBzdGF0aWMgaW50IF9fZ2VucGRfZGV2X3BtX2F0dGFj aChzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBkZXZpY2UgKmJhc2VfZGV2LAo+ICAJfQo+ICAK PiAgCS8qIFNldCB0aGUgZGVmYXVsdCBwZXJmb3JtYW5jZSBzdGF0ZSAqLwo+IC0JcHN0YXRlID0g Z2VucGRfZ2V0X2RlZmF1bHRfcGVyZm9ybWFuY2Vfc3RhdGUoZGV2LCBpbmRleCk7Cj4gKwlwc3Rh dGUgPSBnZW5wZF9nZXRfZGVmYXVsdF9wZXJmb3JtYW5jZV9zdGF0ZShwZCwgZGV2LCBpbmRleCk7 CgpJZiBiYXNlIGRldmljZSBpcyBzdXNwZW5kZWQsIHRoZW4gaXRzIHBlcmZvcm1hbmNlIHN0YXRl IGlzIHplcm8uCgpXaGVuIGRldmljZSB3aWxsIGJlIHJwbS1yZXN1bWVkLCB0aGVuIGl0cyBwZXJm b3JtYW5jZSBzaG91bGQgYmUgc2V0IHRvCnRoZSBkZWZhdWx0IHN0YXRlLgoKWW91J3JlIHNldHRp bmcgcGVyZm9ybWFuY2Ugc3RhdGUgb2YgdGhlIHdyb25nIGRldmljZSwgaXQgc2hvdWxkIGJlIHRo ZQpiYXNlIGRldmljZSBhbmQgbm90IHRoZSB2aXJ0dWFsIGRvbWFpbiBkZXZpY2UuCgpUaGVzZSBh bGwgaXMgaGFuZGxlZCBwcm9wZXJseSBieSBteSBwYXRjaCBbMV0uIEhlbmNlIGl0J3MgY29tcGxp Y2F0ZWQKZm9yIHRoZSByZWFzb24uCgpbMV0KaHR0cHM6Ly9wYXRjaHdvcmsub3psYWJzLm9yZy9w cm9qZWN0L2xpbnV4LXRlZ3JhL3BhdGNoLzIwMjEwODMxMTM1NDUwLjI2MDcwLTUtZGlnZXR4QGdt YWlsLmNvbS8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK