From: Florian Fainelli <f.fainelli@gmail.com>
To: George McCollister <george.mccollister@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
Rob Herring <robh@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>
Subject: Re: [PATCH net-next v4 2/3] net: dsa: add Arrow SpeedChips XRS700x driver
Date: Thu, 14 Jan 2021 10:37:55 -0800 [thread overview]
Message-ID: <4e4b8672-fcbf-5abc-d988-907b9e8dcdc4@gmail.com> (raw)
In-Reply-To: <CAFSKS=Ox9W0baAgC4fzjxW-adosF6ReLGyT5PY5_DvT9GHdQsQ@mail.gmail.com>
On 1/14/21 10:35 AM, George McCollister wrote:
>> Nothing frees up the successfully allocated p->mib_data[] in case of
>> errors so you would be leaking here.
>
> In case of an error probe will end up returning an error and the
> memory will be free'd since it was allocated with a devm_ function,
> won't it?
Sorry completely missed that xrs700x_alloc_port_mib() used a
devm_kzalloc(), this is fine.
--
Florian
next prev parent reply other threads:[~2021-01-14 18:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 14:59 [PATCH net-next v4 0/3] Arrow SpeedChips XRS700x DSA Driver George McCollister
2021-01-13 14:59 ` [PATCH net-next v4 1/3] dsa: add support for Arrow XRS700x tag trailer George McCollister
2021-01-14 1:05 ` Vladimir Oltean
2021-01-14 1:48 ` Andrew Lunn
2021-01-14 15:03 ` George McCollister
2021-01-13 14:59 ` [PATCH net-next v4 2/3] net: dsa: add Arrow SpeedChips XRS700x driver George McCollister
2021-01-14 1:56 ` Vladimir Oltean
2021-01-14 16:53 ` George McCollister
2021-01-14 18:12 ` Andrew Lunn
2021-01-14 18:32 ` Vladimir Oltean
2021-01-14 18:47 ` George McCollister
2021-01-14 19:00 ` Vladimir Oltean
2021-01-14 17:28 ` Florian Fainelli
2021-01-14 18:35 ` George McCollister
2021-01-14 18:37 ` Florian Fainelli [this message]
2021-01-13 14:59 ` [PATCH net-next v4 3/3] dt-bindings: net: dsa: add bindings for xrs700x switches George McCollister
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e4b8672-fcbf-5abc-d988-907b9e8dcdc4@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=george.mccollister@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.