From: Martin KaFai Lau <martin.lau@linux.dev>
To: oe-kbuild-all@lists.linux.dev, kernel test robot <lkp@intel.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Martin KaFai Lau <martin.lau@kernel.org>
Subject: Re: [bpf-next:master 6/17] kernel/bpf/verifier.c:19785 convert_ctx_accesses() warn: inconsistent indenting
Date: Tue, 3 Sep 2024 10:46:03 -0700 [thread overview]
Message-ID: <4e5afba2-fe0a-4501-a21e-fd373d105bc0@linux.dev> (raw)
In-Reply-To: <202408311622.4GzlzN33-lkp@intel.com>
On 8/31/24 2:00 AM, kernel test robot wrote:
> smatch warnings:
> kernel/bpf/verifier.c:19785 convert_ctx_accesses() warn: inconsistent indenting
>
[ ... ]
> 19769 } else if (insn->code == (BPF_JMP | BPF_EXIT) &&
> 19770 epilogue_cnt &&
> 19771 i + delta < subprogs[1].start) {
> 19772 /* Generate epilogue for the main prog */
> 19773 if (epilogue_idx) {
> 19774 /* jump back to the earlier generated epilogue */
> 19775 insn_buf[0] = BPF_JMP32_A(epilogue_idx - i - delta - 1);
> 19776 cnt = 1;
> 19777 } else {
> 19778 memcpy(insn_buf, epilogue_buf,
> 19779 epilogue_cnt * sizeof(*epilogue_buf));
> 19780 cnt = epilogue_cnt;
> 19781 /* epilogue_idx cannot be 0. It must have at
> 19782 * least one ctx ptr saving insn before the
> 19783 * epilogue.
> 19784 */
> 19785 epilogue_idx = i + delta;
There is one extra space by mistake. I will address it together during the
inline_bpf_loop() followup.
prev parent reply other threads:[~2024-09-03 17:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-31 9:00 [bpf-next:master 6/17] kernel/bpf/verifier.c:19785 convert_ctx_accesses() warn: inconsistent indenting kernel test robot
2024-09-03 17:46 ` Martin KaFai Lau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e5afba2-fe0a-4501-a21e-fd373d105bc0@linux.dev \
--to=martin.lau@linux.dev \
--cc=ast@kernel.org \
--cc=lkp@intel.com \
--cc=martin.lau@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.