From: "David Hildenbrand (Red Hat)" <david@kernel.org>
To: Balbir Singh <balbirs@nvidia.com>, linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Nico Pache <npache@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>
Subject: Re: [PATCH] mm/huge_memory: softleaf device private fixes in remove_migration_pmd()
Date: Wed, 12 Nov 2025 12:37:50 +0100 [thread overview]
Message-ID: <4e6286a6-721d-45cd-a4ea-e79e90e14fc7@kernel.org> (raw)
In-Reply-To: <20251112044634.963360-2-balbirs@nvidia.com>
On 12.11.25 05:46, Balbir Singh wrote:
> commit a6ca2ba46390 ("mm: replace pmd_to_swp_entry() with softleaf_from_pmd()")
So should this be squashed into Lorenzo patch, or incorporated in his
series in case he has to resend?
> does not work with device private THP entries. softleaf_is_migration_young()
> asserts that the entry be a migration entry, but in the current code, the
> entry might already be replaced by a device private entry by the time the
> check is made. The issue exists with commit
> 7385dbdbf841 ("mm/rmap: extend rmap and migration support device-private entries")
>
Because this confuses me. If it's already a problem in the
commit-to-go-upstream-first, it should be fixed in that commit?
--
Cheers
David
next prev parent reply other threads:[~2025-11-12 11:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 4:46 [PATCH] mm/huge_memory.c: introduce split_unmapped_folio_to_order Balbir Singh
2025-11-12 4:46 ` [PATCH] mm/huge_memory: softleaf device private fixes in remove_migration_pmd() Balbir Singh
2025-11-12 11:37 ` David Hildenbrand (Red Hat) [this message]
2025-11-13 5:03 ` Balbir Singh
2025-11-13 7:32 ` David Hildenbrand (Red Hat)
2025-11-12 13:43 ` Lorenzo Stoakes
2025-11-12 21:07 ` Balbir Singh
2025-11-12 23:55 ` Balbir Singh
2025-11-12 10:00 ` [PATCH] mm/huge_memory.c: introduce split_unmapped_folio_to_order David Hildenbrand (Red Hat)
2025-11-12 10:17 ` Balbir Singh
2025-11-12 11:34 ` David Hildenbrand (Red Hat)
2025-11-12 23:49 ` Balbir Singh
2025-11-13 21:39 ` Balbir Singh
2025-11-13 21:45 ` Zi Yan
2025-11-13 21:56 ` Balbir Singh
2025-11-14 0:23 ` Zi Yan
2025-11-18 20:17 ` David Hildenbrand (Red Hat)
2025-11-13 15:36 ` Francois Dugast
2025-11-13 16:02 ` Lorenzo Stoakes
2025-11-13 16:24 ` Zi Yan
2025-11-13 19:07 ` David Hildenbrand (Red Hat)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e6286a6-721d-45cd-a4ea-e79e90e14fc7@kernel.org \
--to=david@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=balbirs@nvidia.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.