All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Barry Song <baohua@kernel.org>
Cc: akpm@linux-foundation.org, axelrasmussen@google.com,
	baoquan.he@linux.dev, david@kernel.org, hannes@cmpxchg.org,
	kasong@tencent.com, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, liuxiang.277@bytedance.com, ljs@kernel.org,
	mhocko@kernel.org, qi.zheng@linux.dev, shakeel.butt@linux.dev,
	weixugc@google.com, yuanchu@google.com, zhangbo56@xiaomi.com
Subject: Re: [RFC PATCH v2] mm: vmscan: avoid anon scanning for GFP_NOIO with low swapcache in MGLRU
Date: Fri, 23 Oct 2026 09:36:05 +0800	[thread overview]
Message-ID: <4e647816-0b8b-4a75-8777-8580a574d752@linux.alibaba.com> (raw)
In-Reply-To: <CAGsJ_4z9GZkpV+mpoGogma4oSX4cHy+2UDzyUQSjjOLOfekEPg@mail.gmail.com>



On 10/23/26 5:19 AM, Barry Song wrote:
> On Thu, Oct 22, 2026 at 7:26 PM Baolin Wang
> <baolin.wang@linux.alibaba.com> wrote:
> [...]
> 
>>>>                    }
>>>>
>>>>                    if (should_run_aging(lruvec, max_seq, sc, swappiness)) {
>>>> -                       if (try_to_inc_max_seq(lruvec, max_seq,
>>>> swappiness, false))
>>>
>>> This is quite tricky. If we pass swappiness=0, anon aging will be
>>> skipped. Do we want that for GFP_NOIO cases? I mean, these are not
>>> real cases where anon aging should be disabled.
>>
>> No, we have real use cases where 'vm_swappiness' is set to 0, which
>> means the workload never reclaims anon folios. So in this case we don't
>> need to age anon folios.
> 
> My concern is that setting swappiness to 0 for GFP_NOIO also skips
> anon aging, making it behave the same as a real swappiness=0.

It will not. We will force anon aging for GFP_NOIO case.

> However, GFP_NOIO is only a temporary state, and subsequent
> allocations may not use GFP_NOIO.


  reply	other threads:[~2026-10-23  1:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 15:18 [RFC PATCH v2] mm: vmscan: avoid anon scanning for GFP_NOIO with low swapcache in MGLRU Xiang Liu
2026-10-21  7:28 ` Baolin Wang
2026-10-21 21:55   ` Barry Song
2026-10-22  8:49     ` Baolin Wang
2026-10-22 10:27       ` Barry Song (Xiaomi)
2026-10-22 11:26         ` Baolin Wang
2026-10-22 21:19           ` Barry Song
2026-10-23  1:36             ` Baolin Wang [this message]
2026-10-23  1:40               ` Barry Song
2026-10-27  5:14                 ` Xiang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e647816-0b8b-4a75-8777-8580a574d752@linux.alibaba.com \
    --to=baolin.wang@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=baohua@kernel.org \
    --cc=baoquan.he@linux.dev \
    --cc=david@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=kasong@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liuxiang.277@bytedance.com \
    --cc=ljs@kernel.org \
    --cc=mhocko@kernel.org \
    --cc=qi.zheng@linux.dev \
    --cc=shakeel.butt@linux.dev \
    --cc=weixugc@google.com \
    --cc=yuanchu@google.com \
    --cc=zhangbo56@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.