Re: [Intel-wired-lan] [PATCH iwl-next v2 0/5] ice: refactor PTP feature flags

[Przemek Kitszel <przemyslaw.kitszel@intel.com>]

On 8/17/23 02:00, Jacob Keller wrote:
> This series refactors and extends the feature flag detection for a couple of
> PTP feature flags. This includes ICE_F_GNSS and ICE_F_SMA_CTRL. Instead of
> blindly assuming the feature is enabled on all E810-T devices, check the
> netlist to confirm that the feature is supported on that device and
> platform.
> 
> For SMA control, this allows the driver to fallback to the fixed pin
> configuration that is supported by default E810 configurations when the SMA
> control is not accessible.
> 
> For GNSS, this ensures that we do not attempt to read the GNSS portion of
> the device if its not present, avoiding some unnecessary warning messages.
> 
> For ICE_F_SMA_CTRL this could be seen as a fix, but given the scope of the
> code I decided that its next material. I think of it more as extending the
> feature capability to support pins on more platforms.
> 
> Changes since v1:
> * add a patch to fix E810-T pin counts when SMA is disabled
> * use FIELD_PREP in ice_find_netlist_node
> * reduce scope of variables in ice_find_netlist_node
> * remove unnecessary local variable in ice_find_netlist_node
> * rename "present" functions to use "in_netlist" terminology, and move
>    them into ice_common.c
> * call ice_is_gps_in_netlist_e810t() from ice_gnss_is_gps_present()
> 
> Jacob Keller (5):
>    ice: remove ICE_F_PTP_EXTTS feature flag
>    ice: fix pin assignment for E810-T without SMA control
>    ice: don't enable PTP related capabilities on non-owner PFs
>    ice: check the netlist before enabling ICE_F_SMA_CTRL
>    ice: check netlist before enabling ICE_F_GNSS
> 
>   drivers/net/ethernet/intel/ice/ice.h          |  1 -
>   .../net/ethernet/intel/ice/ice_adminq_cmd.h   |  8 +-
>   drivers/net/ethernet/intel/ice/ice_common.c   | 77 +++++++++++++++++++
>   drivers/net/ethernet/intel/ice/ice_common.h   |  2 +
>   drivers/net/ethernet/intel/ice/ice_gnss.c     |  3 +
>   drivers/net/ethernet/intel/ice/ice_lib.c      | 11 +--
>   drivers/net/ethernet/intel/ice/ice_ptp.c      | 12 +--
>   7 files changed, 101 insertions(+), 13 deletions(-)
> 
> 
> base-commit: 361b86237e1afbf2c3be7cb604b6aac6f8b8c38c

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan