All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <th.huth@posteo.de>
To: "QEMU Developers" <qemu-devel@nongnu.org>,
	"Daniel P. Berrange" <berrange@redhat.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>
Cc: "Reinoud Zandijk" <reinoud@netbsd.org>,
	"Ryo ONODERA" <ryoon@netbsd.org>,
	"Brad Smith" <brad@comstyle.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: QEMU's tests/unit/test-iov times out on NetBSD and OpenBSD
Date: Fri, 19 Jan 2024 15:55:49 +0000	[thread overview]
Message-ID: <4e802a6d-fb97-4e49-ab78-2a75371e464d@posteo.de> (raw)


  Hi,

since we recently introduced test timouts in QEMU's meson set up, I noticed 
that the tests/unit/test-iov times out when doing "make vm-build-netbsd 
BUILD_TARGET=check-unit" (or vm-build-openbsd).

And indeed, when increasing the timeout, you can see that the test-iov runs 
for multiple minutes on these BSDs while it finishes within few seconds on 
Linux.

I had a closer look at the test, and the problem seems to be the

  usleep(g_test_rand_int_range(0, 30));

in the test_io() function. If I get that right, the usleep() seems to be 
more or less precise on (modern) Linux, but it seems like it sleeps for 
multiple milliseconds (not microseconds) on the BSDs. Since it is used in a 
nested loop, these milliseconds add up to a long time in total during the test.

Does anybody have an idea how to fix that? Is there a more precise (but stil 
portable) way to sleep less long here? Or could we maybe remove the usleep() 
here completely (it does not seem to have a real benefit for testing as far 
as I can see)?

  Thanks,
   Thomas


             reply	other threads:[~2024-01-19 15:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-19 15:55 Thomas Huth [this message]
2024-01-19 16:07 ` QEMU's tests/unit/test-iov times out on NetBSD and OpenBSD Daniel P. Berrangé
2024-01-19 16:13   ` Thomas Huth
2024-01-19 17:33     ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e802a6d-fb97-4e49-ab78-2a75371e464d@posteo.de \
    --to=th.huth@posteo.de \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=brad@comstyle.com \
    --cc=f4bug@amsat.org \
    --cc=mjt@tls.msk.ru \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=reinoud@netbsd.org \
    --cc=ryoon@netbsd.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.