All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Olivain <ju.o@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Asaf Kahlon <asafka7@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/python-ml-dtypes: skip dependency check
Date: Tue, 14 May 2024 19:26:54 +0200	[thread overview]
Message-ID: <4e9d5bc99a30a885dddb8aba6145f56d@free.fr> (raw)
In-Reply-To: <20240514154250.1453970-1-james.hilliard1@gmail.com>

Hi James,

Thanks for the patch!

I successfully tested it on branch master at commit 9764258 with 
command:

     support/testing/run-tests \
         -d dl -o output_folder \
         tests.package.test_python_ml_dtypes

On 14/05/2024 17:42, James Hilliard wrote:
> This package pins overly strict numpy dependency versions apparently
> for compatibility reasons that don't appear relevant to buildroot.
> 
> This package also appears to pin an overly strict setuptools version
> for unclear reasons.
> 
> See:
> https://github.com/jax-ml/ml_dtypes/blob/v0.3.2/pyproject.toml#L51-L55
> 
> To fix this lets just set the --skip-dependency-check build option and
> ignore the build dependency version mismatches since they don't appear
> to cause any build issues.
> 
> This error was introduced when we migrated setuptools to pep517 in
> 8937db8dd595e0988751e5dbb568e870b07b39cc.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Tested-by: Julien Olivain <ju.o@free.fr>

> ---
>  package/python-ml-dtypes/python-ml-dtypes.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/python-ml-dtypes/python-ml-dtypes.mk 
> b/package/python-ml-dtypes/python-ml-dtypes.mk
> index 676137ecf1..8097265078 100644
> --- a/package/python-ml-dtypes/python-ml-dtypes.mk
> +++ b/package/python-ml-dtypes/python-ml-dtypes.mk
> @@ -10,6 +10,7 @@ PYTHON_ML_DTYPES_SITE = 
> https://files.pythonhosted.org/packages/39/7d/8d85fcba86
>  PYTHON_ML_DTYPES_LICENSE = Apache-2.0
>  PYTHON_ML_DTYPES_LICENSE_FILES = LICENSE
>  PYTHON_ML_DTYPES_SETUP_TYPE = setuptools
> +PYTHON_ML_DTYPES_BUILD_OPTS = --skip-dependency-check
> 
>  PYTHON_ML_DTYPES_DEPENDENCIES = \
>  	host-python-numpy \
> --
> 2.34.1

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-05-14 17:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-14 15:42 [Buildroot] [PATCH 1/1] package/python-ml-dtypes: skip dependency check James Hilliard
2024-05-14 17:26 ` Julien Olivain [this message]
2024-05-15 14:01   ` Romain Naour
2024-05-15 15:10     ` James Hilliard
2024-05-22 11:47       ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e9d5bc99a30a885dddb8aba6145f56d@free.fr \
    --to=ju.o@free.fr \
    --cc=asafka7@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=james.hilliard1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.