From: "Reddy Guddati, Santhosh" <santhosh.reddy.guddati@intel.com>
To: Vinod Govindapillai <vinod.govindapillai@intel.com>,
<igt-dev@lists.freedesktop.org>
Cc: <swati2.sharma@intel.com>
Subject: Re: [PATCH i-g-t v4 10/12] tests/intel/kms_fbcon_fbt: find the correct fbc status of a pipe
Date: Thu, 16 Jul 2026 13:11:15 +0530 [thread overview]
Message-ID: <4ea22e8a-8753-462d-8bcb-6f49aaabc7d9@intel.com> (raw)
In-Reply-To: <20260601204407.39934-11-vinod.govindapillai@intel.com>
On 02-06-2026 02:14, Vinod Govindapillai wrote:
> Use the right function for access the fbc status from crtc debugfs
> entry.
>
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
Reviewed-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>
> ---
> tests/intel/kms_fbcon_fbt.c | 17 ++++++++---------
> 1 file changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/tests/intel/kms_fbcon_fbt.c b/tests/intel/kms_fbcon_fbt.c
> index 96136f8ff..fdd8515cc 100644
> --- a/tests/intel/kms_fbcon_fbt.c
> +++ b/tests/intel/kms_fbcon_fbt.c
> @@ -83,12 +83,9 @@ static void wait_user(const char *msg)
> static bool fbc_supported_on_chipset(struct drm_info *drm)
> {
> char buf[FBC_STATUS_BUF_LEN];
> - int ret;
>
> - ret = igt_debugfs_simple_read(drm->debugfs_fd, "i915_fbc_status",
> - buf, sizeof(buf));
> - if (ret < 0)
> - return false;
> + intel_fbc_get_status_crtc_index(drm->fd, drm->crtc_index, buf,
> + sizeof(buf));
>
> return !strstr(buf, "FBC unsupported on this chipset\n") &&
> !strstr(buf, "stolen memory not initialised\n");
> @@ -103,8 +100,9 @@ static void fbc_print_status(struct drm_info *drm)
> {
> static char buf[FBC_STATUS_BUF_LEN];
>
> - igt_debugfs_simple_read(drm->debugfs_fd, "i915_fbc_status", buf,
> - sizeof(buf));
> + intel_fbc_get_status_crtc_index(drm->fd, drm->crtc_index, buf,
> + sizeof(buf));
> +
> igt_debug("FBC status: %s\n", buf);
> }
>
> @@ -112,8 +110,9 @@ static bool fbc_check_status(struct drm_info *drm, bool enabled)
> {
> char buf[FBC_STATUS_BUF_LEN];
>
> - igt_debugfs_simple_read(drm->debugfs_fd, "i915_fbc_status", buf,
> - sizeof(buf));
> + intel_fbc_get_status_crtc_index(drm->fd, drm->crtc_index, buf,
> + sizeof(buf));
> +
> if (enabled)
> return strstr(buf, "FBC enabled\n");
> else
next prev parent reply other threads:[~2026-07-16 7:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 20:43 [PATCH i-g-t v4 00/12] updates to fbc tests Vinod Govindapillai
2026-06-01 20:43 ` [PATCH i-g-t v4 01/12] lib/i915/fbc: extract intel_fbc_get_fbc_status() Vinod Govindapillai
2026-07-10 4:50 ` Reddy Guddati, Santhosh
2026-06-01 20:43 ` [PATCH i-g-t v4 02/12] tests/intel/kms_frontbuffer_tracking: use intel_fbc_get_status() Vinod Govindapillai
2026-07-10 5:11 ` Reddy Guddati, Santhosh
2026-06-01 20:43 ` [PATCH i-g-t v4 03/12] tests/intel/kms_frontbuffer_tracking: update the outdated fbc status reasons Vinod Govindapillai
2026-07-10 5:16 ` Reddy Guddati, Santhosh
2026-06-01 20:43 ` [PATCH i-g-t v4 04/12] tests/intel/kms_frontbuffer_tracking: consolidate fbc tests skip checks Vinod Govindapillai
2026-07-16 7:37 ` Reddy Guddati, Santhosh
2026-06-01 20:44 ` [PATCH i-g-t v4 05/12] tests/intel/kms_frontbuffer_tracking: use a bigger buffer for fbc status Vinod Govindapillai
2026-06-01 20:44 ` [PATCH i-g-t v4 06/12] tests/intel/kms_fbcon_fbt: " Vinod Govindapillai
2026-06-01 20:44 ` [PATCH i-g-t v4 07/12] tests/intel/kms_fbcon_fbt: update the outdated fbc skip reasons Vinod Govindapillai
2026-07-10 5:21 ` Reddy Guddati, Santhosh
2026-06-01 20:44 ` [PATCH i-g-t v4 08/12] tests/intel/kms_fbcon_fbt: refactor the code to get the right fbc status Vinod Govindapillai
2026-07-10 5:43 ` Reddy Guddati, Santhosh
2026-06-01 20:44 ` [PATCH i-g-t v4 09/12] tests/intel/kms_fbcon_fbt: find and store the crtc index Vinod Govindapillai
2026-07-10 5:44 ` Reddy Guddati, Santhosh
2026-06-01 20:44 ` [PATCH i-g-t v4 10/12] tests/intel/kms_fbcon_fbt: find the correct fbc status of a pipe Vinod Govindapillai
2026-07-16 7:41 ` Reddy Guddati, Santhosh [this message]
2026-06-01 20:44 ` [PATCH i-g-t v4 11/12] tests/intel/kms_fbcon_fbt: use common routine to skip tests on fbc status Vinod Govindapillai
2026-07-16 7:46 ` Reddy Guddati, Santhosh
2026-06-01 20:44 ` [PATCH i-g-t v4 12/12] tests/intel/fbc: detatiled debug info for unsupported plane size for fbc Vinod Govindapillai
2026-07-10 5:06 ` Reddy Guddati, Santhosh
2026-06-02 0:06 ` ✓ i915.CI.BAT: success for updates to fbc tests (rev4) Patchwork
2026-06-02 0:08 ` ✓ Xe.CI.BAT: " Patchwork
2026-06-02 9:29 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-06-02 10:41 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ea22e8a-8753-462d-8bcb-6f49aaabc7d9@intel.com \
--to=santhosh.reddy.guddati@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=swati2.sharma@intel.com \
--cc=vinod.govindapillai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.