From mboxrd@z Thu Jan 1 00:00:00 1970 From: ayman.bagabas@gmail.com Date: Tue, 15 Oct 2019 13:20:35 +0000 Subject: Re: [PATCH] platform/x86: huawei-wmi: make validation stricter in huawei_wmi_battery_set() Message-Id: <4eaef0a107796895fc59989d1481676f794fcac5.camel@gmail.com> List-Id: References: <20191015083837.GA29104@mwanda> <20191015124623.GF21344@kadam> In-Reply-To: <20191015124623.GF21344@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1254" Content-Transfer-Encoding: base64 To: Dan Carpenter Cc: Darren Hart , Andy Shevchenko , Takashi Iwai , Mattias Jacobsson <2pi@mok.nu>, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org T24gVHVlLCAyMDE5LTEwLTE1IGF0IDE1OjQ2ICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOgo+ IE9uIFR1ZSwgT2N0IDE1LCAyMDE5IGF0IDA4OjIxOjU5QU0gLTA0MDAsIEF5bWFuIEJhZ2FiYXMg d3JvdGU6Cj4gPiBIaSBEYW4KPiA+IAo+ID4gT24gVHVlLCBPY3QgMTUsIDIwMTksIDQ6MzkgQU0g RGFuIENhcnBlbnRlciA8Cj4gPiBkYW4uY2FycGVudGVyQG9yYWNsZS5jb20+Cj4gPiB3cm90ZToK PiA+IAo+ID4gPiBJIGRvbid0IHRoaW5rIGl0IG1ha2VzIHNlbnNlIGZvciAiZW5kIiB0byBiZSBu ZWdhdGl2ZSBvciBmb3IgZXZlbgo+ID4gPiBmb3IgaXQKPiA+ID4gdG8gYmUgbGVzcyB0aGFuICJz dGFydCIuICBUaGF0IGFsc28gbWVhbnMgdGhhdCAic3RhcnQiIGNhbid0IGJlCj4gPiA+IG1vcmUK PiA+ID4gdGhhbiAxMDAgd2hpY2ggaXMgZ29vZC4KPiA+ID4gCj4gPiAKPiA+IFdoaWxlIHRoaXMg bWFrZXMgc2Vuc2UsIHlvdSBydW4gaW50byBpc3N1ZXMgd2hlcmUgeW91IGNhbm5vdCBzZXQKPiA+ ICJzdGFydCIKPiA+IGJlZm9yZSAiZW5kIiBhbmQgdmljZSB2ZXJzYS4KPiA+IAo+ID4gVGFrZSB0 aGlzIHNjZW5hcmlvLCB5b3UgaGF2ZSBzdGFydHAgYW5kIGVuZJAsIG5vdyB5b3Ugd2FudCB0bwo+ ID4gc2V0IHRoZXNlCj4gPiB0byBzdGFydEAgYW5kIGVuZGAsIHlvdSB3b3VsZCBoYXZlIHRvIHNl dCAic3RhcnQiIGZpcnN0IGJlZm9yZQo+ID4geW91IGNhbgo+ID4gY2hhbmdlIHRoZSB2YWx1ZSBv ZiAiZW5kIiBvdGhlcndpc2UgeW91IHdpbGwgcnVuIGludG8gRUlOVkFMLiBOb3cKPiA+IGltYWdp bmUKPiA+IHlvdSB3YW5uYSBnbyB0aGUgb3Bwb3NpdGUgZGlyZWN0aW9uLCB5b3Ugd291bGQgaGF2 ZSB0byBzZXQgImVuZCIKPiA+IGJlZm9yZSB5b3UKPiA+IGNhbiBjaGFuZ2UgInN0YXJ0Ii4KPiA+ IEkgdGhpbmsgaGF2aW5nIGEgbGl0dGxlIHdpZ2dsZSByb29tIGlzIGZpbmUgZm9yIHN1Y2ggc2Nl bmFyaW9zLgo+ID4gCj4gCj4gSSBoYXZlbid0IHRlc3RlZCB0aGlzIGNvZGUuLi4gIFdoYXQgeW91 J3JlIGRlc2NyaWJpbmcgc291bmRzIHJlYWxseQo+IHZlcnkgd2VpcmQgdG8gbWUsIGJ1dCBJIHdp bGwgYWNjZXB0IHRoYXQgeW91IGtub3cgbW9yZSBhYm91dCB5b3VyCj4gdXNlIGNhc2VzIHRoYW4g SSBkby4KPiAKPiBNeSBvdGhlciBjb25jZXJuIGlzIHRoYXQgcmlnaHQgbm93IHlvdSBjYW4gc2V0 IHN0YXJ0ID4gMTAwIG9yIGVuZCA8Cj4gMC4KCldlIHNob3VsZCBjaGVjayBmb3IgdGhlc2UgY2Fz ZXMuCgo+IAo+IHJlZ2FyZHMsCj4gZGFuIGNhcnBlbnRlcgo+IAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: ayman.bagabas@gmail.com Subject: Re: [PATCH] platform/x86: huawei-wmi: make validation stricter in huawei_wmi_battery_set() Date: Tue, 15 Oct 2019 09:20:35 -0400 Message-ID: <4eaef0a107796895fc59989d1481676f794fcac5.camel@gmail.com> References: <20191015083837.GA29104@mwanda> <20191015124623.GF21344@kadam> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20191015124623.GF21344@kadam> Sender: linux-kernel-owner@vger.kernel.org To: Dan Carpenter Cc: Darren Hart , Andy Shevchenko , Takashi Iwai , Mattias Jacobsson <2pi@mok.nu>, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org On Tue, 2019-10-15 at 15:46 +0300, Dan Carpenter wrote: > On Tue, Oct 15, 2019 at 08:21:59AM -0400, Ayman Bagabas wrote: > > Hi Dan > > > > On Tue, Oct 15, 2019, 4:39 AM Dan Carpenter < > > dan.carpenter@oracle.com> > > wrote: > > > > > I don't think it makes sense for "end" to be negative or for even > > > for it > > > to be less than "start". That also means that "start" can't be > > > more > > > than 100 which is good. > > > > > > > While this makes sense, you run into issues where you cannot set > > "start" > > before "end" and vice versa. > > > > Take this scenario, you have start=70 and end=90, now you want to > > set these > > to start=40 and end=60, you would have to set "start" first before > > you can > > change the value of "end" otherwise you will run into EINVAL. Now > > imagine > > you wanna go the opposite direction, you would have to set "end" > > before you > > can change "start". > > I think having a little wiggle room is fine for such scenarios. > > > > I haven't tested this code... What you're describing sounds really > very weird to me, but I will accept that you know more about your > use cases than I do. > > My other concern is that right now you can set start > 100 or end < > 0. We should check for these cases. > > regards, > dan carpenter >