From: Malcolm Priestley <tvboxspy@gmail.com>
To: Antti Palosaari <crope@iki.fi>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 2/7] af9015 Remove call to get config from probe.
Date: Sat, 12 Nov 2011 18:22:16 +0000 [thread overview]
Message-ID: <4ebeb95d.e813b40a.37be.5102@mx.google.com> (raw)
In-Reply-To: <4EBE9C3C.4070201@iki.fi>
On Sat, 2011-11-12 at 18:18 +0200, Antti Palosaari wrote:
> On 11/12/2011 05:55 PM, Malcolm Priestley wrote:
> > Remove get config from probe and move to identify_state.
> >
> > intf->cur_altsetting->desc.bInterfaceNumber is always expected to be zero, so there
> > no point in checking for it.
>
> Are you sure? IIRC there is HID remote on interface 1 or 2 or so (some
> other than 0). Please double check.
>
> > Calling from probe seems to cause a race condition with some USB controllers.
>
> Why?
>
Is some other module going to claim the device?
Would it not be better use usb_set_interface to set it back to 0?
Rather than failing it back to the user.
Regards
Malcolm
next prev parent reply other threads:[~2011-11-12 18:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-12 15:55 [PATCH 2/7] af9015 Remove call to get config from probe Malcolm Priestley
2011-11-12 16:18 ` Antti Palosaari
2011-11-12 18:22 ` Malcolm Priestley [this message]
2011-11-12 19:36 ` Antti Palosaari
2011-11-13 12:04 ` Malcolm Priestley
2011-11-13 12:34 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ebeb95d.e813b40a.37be.5102@mx.google.com \
--to=tvboxspy@gmail.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.