From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAB19399031 for ; Wed, 12 Aug 2026 06:37:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786516637; cv=none; b=XjrzHP/l8ypB4q3d37KIuv3iS1T9jD9PMx/FHg04J6uYaR8LqwTW1gAJerxQ1HDwiaDF5Y6PRMFaceC8Bm7KrYuk3tUP/28SGz+4cYn4eU2Ww88aEsBZRXEpsgduK9lC6t1+ptPZbfrdp66amH5AX6Zek9EqjYwCbIAZ+2ChtdE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786516637; c=relaxed/simple; bh=Fb6l6texhcQH2qwr1NvnJjPxPB8hHtgQueF3SaRCv+E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ib15uJST8KWytPBUoZ7Y0Xv34bRMJ+5tMrZWF6iRHGL7/Ra3iW5EtUMzhv6sHelm6gxNJu60uiLpnN+4mB3jP5g+2r9aJZ09g8emS1+/8iyv1htgtjmTvk41++KR66r2qVvzCZTrDyeCAJDBeFGdFFwGSosP7ftkO0AcDIb9BQQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=r9prKHY9; arc=none smtp.client-ip=115.124.30.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="r9prKHY9" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1786516629; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=YeSAu1TQ+Djh26JZhr0kK3+RliVckpg31TWgDiRN4/0=; b=r9prKHY9ilrtKh53Ftx1OTDJfqMC8Wv4X1Yz+KoNmdfR5h/Spu56ApOdUceqk1bPG4CCkCWt6BrrRhGTR9YWaLsPv8VYQAJILJKG2IcmKWhA6cPJja6vwl/zjMVheoaMjzGGABhsVvH0BRDJk5ZNzQkp+k+fXMOn0fRJOjr4ab8= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033045133197;MF=kanie@linux.alibaba.com;NM=1;PH=DS;RN=13;SR=0;TI=SMTPD_---0X8qgyE1_1786516627; Received: from 30.178.83.207(mailfrom:kanie@linux.alibaba.com fp:SMTPD_---0X8qgyE1_1786516627 cluster:ay36) by smtp.aliyun-inc.com; Wed, 12 Aug 2026 14:37:09 +0800 Message-ID: <4ed92a11-04e9-4551-8177-402c850add1d@linux.alibaba.com> Date: Wed, 12 Aug 2026 14:37:06 +0800 Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/8] cxl: Assorted fixes To: Richard Cheng Cc: Alison Schofield , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Vishal Verma , Dan Williams , Ira Weiny , Li Ming , Robert Richter , linux-cxl@vger.kernel.org, xlpang@linux.alibaba.com, oliver.yang@linux.alibaba.com References: <20260811113608.2815625-1-kanie@linux.alibaba.com> From: Guixin Liu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2026/8/12 14:29, Richard Cheng 写道: > On Wed, Aug 12, 2026 at 10:10:35AM +0800, Guixin Liu wrote: >> >> 在 2026/8/12 03:57, Alison Schofield 写道: >>> On Tue, Aug 11, 2026 at 07:36:00PM +0800, Guixin Liu wrote: >>>> This is a batch of fixes found while auditing drivers/cxl. They are >>>> independent of each other and can be applied individually or dropped in >>>> any combination; they are only sent together because they came out of the >>>> same pass over the code. >>> Hi Guixin Liu. >>> >>> Thanks for taking a look at CXL and putting these fixes together. I >>> appreciate that the intent here is to make the individual fixes easy to >>> take or drop. From the maintainer side, though, a grab bag of independent >>> findings from an audit has somewhat the opposite effect. It leaves us >>> with the audit results and the homework. :) >>> >>> We have been working through this kind of cleanup in focused functional >>> areas, like features, HDM enumeration, etc. Please take a similar approach >>> rather than collecting unrelated findings into a single series. Address >>> one area at a time. >> Sorry, this is my first time sending patch to cxl mailing list, >> I will pay attention to these next time, thanks. >>> As part of that work, please check mailing list traffic and cxl/next for >>> fixes that have already been posted or merged, and review the pre-existing >>> complaints reported by the Sashiko bot against your patchset: >>> https://sashiko.dev/#/patchset/20260811113608.2815625-1-kanie%40linux.alibaba.com >> Sure, I will check before, >> >> but why dosen't Sashiko reply directly in the current email? I can't reply >> Sashiko. >>> Please also follow the conventions we use for fix commit messages. They >>> should not narrate the code change, but rather describe what happens today, >>> why that is wrong and its impact, then state how the patch fixes it. >>> For an example of switching from code narration to behavior description, >>> take a look at my recent reply to a commit message w similar issue: >>> https://lore.kernel.org/linux-cxl/ant2Z1mzHCrzmzXn@aschofie-mobl2.lan/ >> Got that, thanks. >> >> Best Regards, >> Guixin Liu > Hi Guixin, > > I think some of your fixes are already addressed. > For what I've known, the first 2 patches are already covered in my patch series > > https://lore.kernel.org/linux-cxl/20260708074228.43654-1-icheng@nvidia.com/ > > Best regards, > Richard Cheng. Yes，I removed 1,2,7 patch, and sent the rest separately. Best Regards, Guixin Liu > > >>> This up-front triage is becoming increasingly important as we see more >>> AI-assisted audits and fix submissions. Without it, maintainers end up >>> determining whether each finding is still present, already being >>> addressed, significant enough to fix, and where it fits with ongoing >>> work. That review burden does not scale with the volume of AI-generated >>> findings. >>> >>> Rather than reworking this series as a whole, please apply this feedback >>> to focused CXL fixes you submit going forward. >>> >>> Thanks, >>> Alison >>> >>>> Guixin Liu (8): >>>> cxl/features: Validate the fwctl RPC input length >>>> cxl/features: Bound the Get Feature output by the user output buffer >>>> cxl/core: Fix dport use-after-free via the einj_inject debugfs file >>>> cxl/pci: Fix NULL pointer dereference in reset detection >>>> cxl/hdm: Fix out of bounds read of the decoder target list >>>> cxl/cdat: Fix uninitialized stack use in endpoint bandwidth gathering >>>> cxl/mce: Validate the memdev and endpoint before use >>>> cxl/region: Unregister the pmem region bridge on setup failure >>>> >>>> drivers/cxl/core/cdat.c | 6 +++--- >>>> drivers/cxl/core/features.c | 15 ++++++++++++++- >>>> drivers/cxl/core/hdm.c | 12 ++++++++++++ >>>> drivers/cxl/core/mce.c | 8 ++++++-- >>>> drivers/cxl/core/pci.c | 8 ++++++++ >>>> drivers/cxl/core/port.c | 18 ++++++++++++++---- >>>> drivers/cxl/core/region_pmem.c | 6 ++++-- >>>> 7 files changed, 61 insertions(+), 12 deletions(-) >>>> >>>> >>>> base-commit: d58772d8520c7ef247c4b95c9bd76d3a25da9ff5 >>>> -- >>>> 2.43.7 >>>> >>