From: Andrea Arcangeli <andrea@cpushare.com>
To: linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>
Subject: [PATCH 06 of 11] balance_pgdat doesn't return the number of pages freed
Date: Thu, 03 Jan 2008 03:09:12 +0100 [thread overview]
Message-ID: <4ef302dd29164e19111c.1199326152@v2.random> (raw)
In-Reply-To: <patchbomb.1199326146@v2.random>
# HG changeset patch
# User Andrea Arcangeli <andrea@suse.de>
# Date 1199324665 -3600
# Node ID 4ef302dd29164e19111c49bb0db2ad4840eace18
# Parent fc9148f0ddd0ef11be29dba89e3fc96df8f0b9bf
balance_pgdat doesn't return the number of pages freed
nr_reclaimed would be the number of pages freed in the last pass.
Signed-off-by: Andrea Arcangeli <andrea@suse.de>
diff --git a/mm/vmscan.c b/mm/vmscan.c
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1298,8 +1298,6 @@ out:
* For kswapd, balance_pgdat() will work across all this node's zones until
* they are all at pages_high.
*
- * Returns the number of pages which were actually freed.
- *
* There is special handling here for zones which are full of pinned pages.
* This can happen if the pages are all mlocked, or if they are all used by
* device drivers (say, ZONE_DMA). Or if they are all in use by hugetlb.
@@ -1315,7 +1313,7 @@ out:
* the page allocator fallback scheme to ensure that aging of pages is balanced
* across the zones.
*/
-static unsigned long balance_pgdat(pg_data_t *pgdat, int order)
+static void balance_pgdat(pg_data_t *pgdat, int order)
{
int all_zones_ok;
int priority;
@@ -1475,8 +1473,6 @@ out:
goto loop_again;
}
-
- return nr_reclaimed;
}
/*
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-01-03 2:09 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-03 2:09 [PATCH 00 of 11] oom deadlock fixes Andrea Arcangeli
2008-01-03 2:09 ` [PATCH 01 of 11] limit shrink zone scanning Andrea Arcangeli
2008-01-07 19:11 ` Christoph Lameter
2008-01-03 2:09 ` [PATCH 02 of 11] avoid oom deadlock in nfs_create_request Andrea Arcangeli
2008-01-07 19:13 ` Christoph Lameter
2008-01-03 2:09 ` [PATCH 03 of 11] prevent oom deadlocks during read/write operations Andrea Arcangeli
2008-01-07 19:15 ` Christoph Lameter
2008-01-07 19:26 ` Andrea Arcangeli
2008-01-03 2:09 ` [PATCH 04 of 11] avoid selecting already killed tasks Andrea Arcangeli
2008-01-03 9:40 ` David Rientjes
2008-01-03 13:41 ` Andrea Arcangeli
2008-01-03 18:47 ` David Rientjes
2008-01-03 19:54 ` Andrea Arcangeli
2008-01-03 20:49 ` David Rientjes
2008-01-07 19:17 ` Christoph Lameter
2008-01-03 2:09 ` [PATCH 05 of 11] reduce the probability of an OOM livelock Andrea Arcangeli
2008-01-07 19:32 ` Christoph Lameter
2008-01-03 2:09 ` Andrea Arcangeli [this message]
2008-01-07 19:33 ` [PATCH 06 of 11] balance_pgdat doesn't return the number of pages freed Christoph Lameter
2008-01-03 2:09 ` [PATCH 07 of 11] don't depend on PF_EXITING tasks to go away Andrea Arcangeli
2008-01-03 9:52 ` David Rientjes
2008-01-03 13:29 ` Andrea Arcangeli
2008-01-03 2:09 ` [PATCH 08 of 11] stop useless vm trashing while we wait the TIF_MEMDIE task to exit Andrea Arcangeli
2008-01-03 2:09 ` [PATCH 09 of 11] oom select should only take rss into account Andrea Arcangeli
2008-01-07 19:35 ` Christoph Lameter
2008-01-03 2:09 ` [PATCH 10 of 11] limit reclaim if enough pages have been freed Andrea Arcangeli
2008-01-07 19:37 ` Christoph Lameter
2008-01-08 7:28 ` Andrea Arcangeli
2008-01-03 2:09 ` [PATCH 11 of 11] not-wait-memdie Andrea Arcangeli
2008-01-03 9:55 ` David Rientjes
2008-01-03 13:06 ` Andrea Arcangeli
2008-01-03 18:54 ` David Rientjes
2008-01-07 19:43 ` Christoph Lameter
2008-01-08 1:57 ` David Rientjes
2008-01-08 3:25 ` Nick Piggin
2008-01-08 3:37 ` David Rientjes
2008-01-08 7:42 ` Nick Piggin
2008-01-08 7:45 ` Andrea Arcangeli
2008-01-08 7:37 ` Andrea Arcangeli
2008-01-08 7:31 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ef302dd29164e19111c.1199326152@v2.random \
--to=andrea@cpushare.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.