From: Jonathan Cameron <jic23@kernel.org>
To: Brian Masney <masneyb@onstation.org>
Cc: gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH 3/4] staging: iio: isl29018: rename Kconfig variable to match existing light drivers in mainline.
Date: Sun, 9 Oct 2016 11:33:17 +0100 [thread overview]
Message-ID: <4efa6955-eaca-312a-009b-5d487688d1b7@kernel.org> (raw)
In-Reply-To: <1475801317-29449-3-git-send-email-masneyb@onstation.org>
On 07/10/16 01:48, Brian Masney wrote:
> Rename CONFIG_SENSORS_ISL29018 to CONFIG_ISL29018 for consistency with
> the other light drivers in mainline.
>
> Signed-off-by: Brian Masney <masneyb@onstation.org>
I'm always a bit split on these. It would be lovely to tidy
it up, but it may cause unnecessary breakage to people's
configs for a very minor gain. Hence I'm not going to apply this.
Jonathan
> ---
> drivers/staging/iio/light/Kconfig | 2 +-
> drivers/staging/iio/light/Makefile | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/light/Kconfig b/drivers/staging/iio/light/Kconfig
> index ca8d6e6..b0e2948 100644
> --- a/drivers/staging/iio/light/Kconfig
> +++ b/drivers/staging/iio/light/Kconfig
> @@ -3,7 +3,7 @@
> #
> menu "Light sensors"
>
> -config SENSORS_ISL29018
> +config ISL29018
> tristate "ISL 29018 light and proximity sensor"
> depends on I2C
> select REGMAP_I2C
> diff --git a/drivers/staging/iio/light/Makefile b/drivers/staging/iio/light/Makefile
> index 9960fdf..89d6b02 100644
> --- a/drivers/staging/iio/light/Makefile
> +++ b/drivers/staging/iio/light/Makefile
> @@ -2,7 +2,7 @@
> # Makefile for industrial I/O Light sensors
> #
>
> -obj-$(CONFIG_SENSORS_ISL29018) += isl29018.o
> +obj-$(CONFIG_ISL29018) += isl29018.o
> obj-$(CONFIG_SENSORS_ISL29028) += isl29028.o
> obj-$(CONFIG_TSL2583) += tsl2583.o
> obj-$(CONFIG_TSL2x7x) += tsl2x7x_core.o
>
next prev parent reply other threads:[~2016-10-09 10:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 0:48 [PATCH 1/4] staging: iio: isl29018: add documentation about the infrared suppression Brian Masney
2016-10-07 0:48 ` [PATCH 2/4] staging: iio: isl29018: document device tree bindings Brian Masney
2016-10-09 8:48 ` Jonathan Cameron
2016-10-09 8:48 ` Jonathan Cameron
2016-10-07 0:48 ` [PATCH 3/4] staging: iio: isl29018: rename Kconfig variable to match existing light drivers in mainline Brian Masney
2016-10-09 10:33 ` Jonathan Cameron [this message]
2016-10-07 0:48 ` [PATCH 4/4] staging: iio: isl29018: move out of staging Brian Masney
2016-10-09 9:45 ` Jonathan Cameron
2016-10-09 10:35 ` Brian Masney
2016-10-09 10:39 ` Jonathan Cameron
2016-10-09 8:43 ` [PATCH 1/4] staging: iio: isl29018: add documentation about the infrared suppression Jonathan Cameron
2016-10-09 8:51 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4efa6955-eaca-312a-009b-5d487688d1b7@kernel.org \
--to=jic23@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-iio@vger.kernel.org \
--cc=masneyb@onstation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.