All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleksii Kurochko <oleksii.kurochko@gmail.com>
To: "Szymon Acedański" <accek@invisiblethingslab.com>,
	xen-devel@lists.xenproject.org
Cc: "Jan Beulich" <jbeulich@suse.com>,
	"Daniel P. Smith" <dpsmith@apertussolutions.com>,
	"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v2] xen/efi: Use blexit() instead of BUG_ON() in read_file()
Date: Tue, 2 Jun 2026 17:18:05 +0200	[thread overview]
Message-ID: <4f125442-e5ff-4f43-a30b-8aca8a6a04fe@gmail.com> (raw)
In-Reply-To: <20260602131737.2983084-1-accek@invisiblethingslab.com>



On 6/2/26 3:17 PM, Szymon Acedański wrote:
> Follow-up to 880e40b187aa, which added a BUG_ON() guard in read_file().
> 
> But as Jan pointed out, before ExitBootServices BUG_ON()
> is not functional. It results in a hang with no message.
> 
> On the other hand blexit() prints a message and returns back
> to the bootloader.
> 
> Fixes: 880e40b187aa ("xen/efi: Fix boot from a device without a file system")
> Reported-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Szymon Acedański <accek@invisiblethingslab.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Release-Acked-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>

Thanks.

~ Oleksii


      parent reply	other threads:[~2026-06-02 15:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02 13:17 [PATCH v2] xen/efi: Use blexit() instead of BUG_ON() in read_file() Szymon Acedański
2026-06-02 14:06 ` Marek Marczykowski-Górecki
2026-06-02 15:18 ` Oleksii Kurochko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f125442-e5ff-4f43-a30b-8aca8a6a04fe@gmail.com \
    --to=oleksii.kurochko@gmail.com \
    --cc=accek@invisiblethingslab.com \
    --cc=dpsmith@apertussolutions.com \
    --cc=jbeulich@suse.com \
    --cc=marmarek@invisiblethingslab.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.