From: Dan Murphy <dmurphy@ti.com>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>
Cc: <linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v20 12/17] leds: lp55xx: Add multicolor framework support to lp55xx
Date: Mon, 27 Apr 2020 13:17:16 -0500 [thread overview]
Message-ID: <4f149443-87f9-ca3f-e131-2b494cbfed84@ti.com> (raw)
In-Reply-To: <24aa265c-46ca-1643-7781-9ddbf734405b@gmail.com>
Jacek
On 4/26/20 11:07 AM, Jacek Anaszewski wrote:
> Hi Dan,
>
> One nit below.
>
> On 4/23/20 5:55 PM, Dan Murphy wrote:
>> Add multicolor framework support for the lp55xx family.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>> drivers/leds/Kconfig | 1 +
>> drivers/leds/leds-lp5521.c | 14 +-
>> drivers/leds/leds-lp5523.c | 14 +-
>> drivers/leds/leds-lp5562.c | 13 +-
>> drivers/leds/leds-lp55xx-common.c | 178 +++++++++++++++++++---
>> drivers/leds/leds-lp55xx-common.h | 11 +-
>> drivers/leds/leds-lp8501.c | 14 +-
>> include/linux/platform_data/leds-lp55xx.h | 8 +
>> 8 files changed, 207 insertions(+), 46 deletions(-)
>>
> [...]
>> diff --git a/drivers/leds/leds-lp55xx-common.h
>> b/drivers/leds/leds-lp55xx-common.h
>> index b9b1041e8143..a9d7ba3f2fd1 100644
>> --- a/drivers/leds/leds-lp55xx-common.h
>> +++ b/drivers/leds/leds-lp55xx-common.h
>> @@ -12,6 +12,8 @@
>> #ifndef _LEDS_LP55XX_COMMON_H
>> #define _LEDS_LP55XX_COMMON_H
>> +#include <linux/led-class-multicolor.h>
>> +
>> enum lp55xx_engine_index {
>> LP55XX_ENGINE_INVALID,
>> LP55XX_ENGINE_1,
>> @@ -109,6 +111,9 @@ struct lp55xx_device_config {
>> /* access brightness register */
>> int (*brightness_fn)(struct lp55xx_led *led);
>> + /* perform brightness value to multiple LEDs */
>> + int (*multicolor_brightness_fn)(struct lp55xx_led *led);
>
> Isn't some word missing here? IMO it should be rephrased.
> Maybe "write multi color brightness to hw" ?
>
But brightness_fn does not say write_brightness_fn so I think this would
look weird to add write to the function name
Dan
next prev parent reply other threads:[~2020-04-27 18:23 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 15:55 [PATCH v20 00/17] Multicolor Framework (array edition) Dan Murphy
2020-04-23 15:55 ` [PATCH v20 01/17] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2020-04-23 15:55 ` [PATCH v20 02/17] leds: Add multicolor ID to the color ID list Dan Murphy
2020-04-25 19:52 ` Pavel Machek
2020-04-27 17:12 ` Dan Murphy
2020-04-28 8:43 ` Pavel Machek
2020-04-28 12:02 ` Dan Murphy
2020-04-23 15:55 ` [PATCH v20 03/17] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2020-04-25 19:53 ` Pavel Machek
2020-04-27 17:12 ` Dan Murphy
2020-04-25 20:23 ` Pavel Machek
2020-04-26 16:24 ` Jacek Anaszewski
2020-04-26 19:48 ` Pavel Machek
2020-04-27 19:33 ` Dan Murphy
2020-04-28 8:41 ` Pavel Machek
2020-04-26 16:46 ` Jacek Anaszewski
2020-04-23 15:55 ` [PATCH v20 04/17] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2020-04-25 20:24 ` Pavel Machek
2020-04-27 19:02 ` Dan Murphy
2020-04-23 15:55 ` [PATCH v20 05/17] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2020-04-23 15:55 ` [PATCH v20 06/17] dt: bindings: lp55xx: Be consistent in the document with LED acronym Dan Murphy
2020-04-23 15:55 ` [PATCH v20 07/17] dt: bindings: lp55xx: Update binding for Multicolor Framework Dan Murphy
2020-04-23 15:55 ` [PATCH v20 08/17] ARM: dts: n900: Add reg property to the LP5523 channel node Dan Murphy
2020-04-23 15:55 ` [PATCH v20 09/17] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 " Dan Murphy
2020-04-25 20:31 ` Pavel Machek
2020-04-23 15:55 ` [PATCH v20 10/17] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes Dan Murphy
2020-04-27 19:06 ` Dan Murphy
2020-04-23 15:55 ` [PATCH v20 11/17] leds: lp55xx: Convert LED class registration to devm_* Dan Murphy
2020-04-23 15:55 ` [PATCH v20 12/17] leds: lp55xx: Add multicolor framework support to lp55xx Dan Murphy
2020-04-25 20:37 ` Pavel Machek
2020-04-26 16:07 ` Jacek Anaszewski
2020-04-27 18:17 ` Dan Murphy [this message]
2020-04-27 19:42 ` Jacek Anaszewski
2020-04-27 19:58 ` Dan Murphy
2020-04-23 15:55 ` [PATCH v20 13/17] leds: lp5523: Update the lp5523 code to add multicolor brightness function Dan Murphy
2020-04-25 20:38 ` Pavel Machek
2020-04-23 15:55 ` [PATCH v20 14/17] leds: lp5521: Add multicolor framework multicolor brightness support Dan Murphy
2020-04-25 20:39 ` Pavel Machek
2020-04-23 15:55 ` [PATCH v20 15/17] leds: lp55xx: Fix checkpatch file permissions issues Dan Murphy
2020-04-23 15:55 ` [PATCH v20 16/17] leds: lp5523: Fix checkpatch issues in the code Dan Murphy
2020-04-23 15:55 ` [PATCH v20 17/17] dt: bindings: Update lp55xx binding to recommended LED naming Dan Murphy
2020-04-25 20:48 ` [PATCH v20 00/17] Multicolor Framework (array edition) Pavel Machek
2020-04-27 17:18 ` Dan Murphy
2020-04-27 19:05 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f149443-87f9-ca3f-e131-2b494cbfed84@ti.com \
--to=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.