From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laura Abbott Subject: Re: [PATCH] staging: android: ion: fix sys heap pool's gfp_flags Date: Tue, 19 Feb 2019 13:18:49 -0800 Message-ID: <4f28e830-fd2b-c24b-3ffe-e711bb3cf3d3@redhat.com> References: <1549004386-38778-1-git-send-email-saberlily.xia@hisilicon.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1549004386-38778-1-git-send-email-saberlily.xia@hisilicon.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Qing Xia , sumit.semwal@linaro.org, gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com, maco@android.com Cc: linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org, daniel.liuyi@hisilicon.com, yudongbin@hisilicon.com, kongfei@hisilicon.com, puck.chen@hisilicon.com List-Id: dri-devel@lists.freedesktop.org On 1/31/19 10:59 PM, Qing Xia wrote: > In the first loop, gfp_flags will be modified to high_order_gfp_flags, > and there will be no chance to change back to low_order_gfp_flags. > > Fixes: e7f63771 ("ION: Sys_heap: Add cached pool to spead up cached buffer alloc") > Signed-off-by: Qing Xia > --- > drivers/staging/android/ion/ion_system_heap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c > index 0383f75..20f2103 100644 > --- a/drivers/staging/android/ion/ion_system_heap.c > +++ b/drivers/staging/android/ion/ion_system_heap.c > @@ -223,10 +223,10 @@ static void ion_system_heap_destroy_pools(struct ion_page_pool **pools) > static int ion_system_heap_create_pools(struct ion_page_pool **pools) > { > int i; > - gfp_t gfp_flags = low_order_gfp_flags; > > for (i = 0; i < NUM_ORDERS; i++) { > struct ion_page_pool *pool; > + gfp_t gfp_flags = low_order_gfp_flags; > > if (orders[i] > 4) > gfp_flags = high_order_gfp_flags; > Acked-by: Laura Abbott